From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Magnus Damm <magnus.damm@gmail.com>
Cc: takuya.sakata.wz@bp.renesas.com, u-boot@lists.denx.de,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
Subject: Re: [U-Boot] [RFC] ARM: rmobile: create DT memory nodes for R8A7795 3.0 and newer
Date: Tue, 19 Jun 2018 08:56:37 +0300 [thread overview]
Message-ID: <2538185.ecTHDDYmKt@avalon> (raw)
In-Reply-To: <CANqRtoQZTZ_34yzpT0+dpM1gu6gmPP-QAhdwgRXwoWeVOpdeaA@mail.gmail.com>
Hi Magnus,
On Tuesday, 19 June 2018 08:43:31 EEST Magnus Damm wrote:
> On Tue, Jun 19, 2018 at 11:15 AM, Laurent Pinchart wrote:
> > On Sunday, 17 June 2018 03:08:02 EEST Marek Vasut wrote:
> >> On 06/16/2018 05:44 PM, Laurent Pinchart wrote:
> >>> On Saturday, 16 June 2018 02:42:30 EEST Marek Vasut wrote:
> >>>> On 06/16/2018 01:21 AM, Laurent Pinchart wrote:
> >>>>> On Friday, 15 June 2018 15:00:31 EEST Marek Vasut wrote:
> >>>>>> On 06/15/2018 01:43 PM, Marek Vasut wrote:
[snip]
> >>>>>>> Yet, I have to wonder if ATF doesn't already contain some sort of
> >>>>>>> standard SMC call to get memory topology. It surprises me that it
> >>>>>>> wouldn't.
> >>>>>>
> >>>>>> In fact, Laurent (CCed) was solving some similar issue with lossy
> >>>>>> decomp and I think this involved some passing of memory layout
> >>>>>> information from ATF to U-Boot too, or am I mistaken ?
> >>>>>
> >>>>> That's correct, ATF stores information about the memory layout at a
> >>>>> fixed address in system memory, and U-Boot can read it.
> >>>>
> >>>> Well, that sounds good ! Maybe we can avoid adding SMC call altogether
> >>>> then? :)
> >>>
> >>> I'd prefer that, yes.
> >>>
> >>> Let's not duplicate the mechanism used to pass FCNL information from
> >>> ATF to U- Boot, but instead create a data table format that can store
> >>> all the information we need, in an easily extensible way.
> >>>
> >>> To see how the mechanism is implemented for FCNL, search for 47FD7000
> >>> in the Renesas ATF sources
> >>> (git://github.com/renesas-rcar/arm-trusted-firmware.git).
> >>
> >> For everyone involved, can you explain what FCNL is ? ;-)
> >
> > FCNL is Frame Compression Near Lossless. It's a way to reduce memory
> > bandwidth by transparent compression and decompression of video frames.
> > Compression is handled by an IP core called FCP, and decompression is
> > handled by the DRAM controller. ATF programs the DRAM controller with
> > ranges of memory addresses that will be dynamically decompressed. The
> > registers containing those ranges are accessible in secure mode only, so
> > neither U-Boot nor Linux can read them. That's why ATF has to pass the
> > information to U-Boot, in order to add the ranges as reserved memory in
> > DT.
>
> Thanks for the clarification. I wonder how much of the split between
> ATF and "the rest" can be adjusted. It smells like just a software
> architecture policy, my gut feeling is that LIFEC can be programmed to
> adjust the assignment between secure side and "regular". At least it
> can do so for a wide range of bus masters. However if this is the case
> for FCNL remains to be seen.
>
> As a side note, for FCNL I personally would prefer a more dynamic
> solution where we manage physically contiguous ranges from Linux
> during run time instead of relying of statically setup windows.
So would I, but whether we can be allowed to access those registers from Linux
isn't my decision :-/
> >> Any yes, I agree this sounds good. I had a discussion on the U-Boot IRC
> >> about passing the memory configuration around and the result is
> >> basically the same -- pass a table from ATF to U-Boot. If there's
> >> already something, great.
--
Regards,
Laurent Pinchart
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC] ARM: rmobile: create DT memory nodes for R8A7795 3.0 and newer
Date: Tue, 19 Jun 2018 08:56:37 +0300 [thread overview]
Message-ID: <2538185.ecTHDDYmKt@avalon> (raw)
In-Reply-To: <CANqRtoQZTZ_34yzpT0+dpM1gu6gmPP-QAhdwgRXwoWeVOpdeaA@mail.gmail.com>
Hi Magnus,
On Tuesday, 19 June 2018 08:43:31 EEST Magnus Damm wrote:
> On Tue, Jun 19, 2018 at 11:15 AM, Laurent Pinchart wrote:
> > On Sunday, 17 June 2018 03:08:02 EEST Marek Vasut wrote:
> >> On 06/16/2018 05:44 PM, Laurent Pinchart wrote:
> >>> On Saturday, 16 June 2018 02:42:30 EEST Marek Vasut wrote:
> >>>> On 06/16/2018 01:21 AM, Laurent Pinchart wrote:
> >>>>> On Friday, 15 June 2018 15:00:31 EEST Marek Vasut wrote:
> >>>>>> On 06/15/2018 01:43 PM, Marek Vasut wrote:
[snip]
> >>>>>>> Yet, I have to wonder if ATF doesn't already contain some sort of
> >>>>>>> standard SMC call to get memory topology. It surprises me that it
> >>>>>>> wouldn't.
> >>>>>>
> >>>>>> In fact, Laurent (CCed) was solving some similar issue with lossy
> >>>>>> decomp and I think this involved some passing of memory layout
> >>>>>> information from ATF to U-Boot too, or am I mistaken ?
> >>>>>
> >>>>> That's correct, ATF stores information about the memory layout at a
> >>>>> fixed address in system memory, and U-Boot can read it.
> >>>>
> >>>> Well, that sounds good ! Maybe we can avoid adding SMC call altogether
> >>>> then? :)
> >>>
> >>> I'd prefer that, yes.
> >>>
> >>> Let's not duplicate the mechanism used to pass FCNL information from
> >>> ATF to U- Boot, but instead create a data table format that can store
> >>> all the information we need, in an easily extensible way.
> >>>
> >>> To see how the mechanism is implemented for FCNL, search for 47FD7000
> >>> in the Renesas ATF sources
> >>> (git://github.com/renesas-rcar/arm-trusted-firmware.git).
> >>
> >> For everyone involved, can you explain what FCNL is ? ;-)
> >
> > FCNL is Frame Compression Near Lossless. It's a way to reduce memory
> > bandwidth by transparent compression and decompression of video frames.
> > Compression is handled by an IP core called FCP, and decompression is
> > handled by the DRAM controller. ATF programs the DRAM controller with
> > ranges of memory addresses that will be dynamically decompressed. The
> > registers containing those ranges are accessible in secure mode only, so
> > neither U-Boot nor Linux can read them. That's why ATF has to pass the
> > information to U-Boot, in order to add the ranges as reserved memory in
> > DT.
>
> Thanks for the clarification. I wonder how much of the split between
> ATF and "the rest" can be adjusted. It smells like just a software
> architecture policy, my gut feeling is that LIFEC can be programmed to
> adjust the assignment between secure side and "regular". At least it
> can do so for a wide range of bus masters. However if this is the case
> for FCNL remains to be seen.
>
> As a side note, for FCNL I personally would prefer a more dynamic
> solution where we manage physically contiguous ranges from Linux
> during run time instead of relying of statically setup windows.
So would I, but whether we can be allowed to access those registers from Linux
isn't my decision :-/
> >> Any yes, I agree this sounds good. I had a discussion on the U-Boot IRC
> >> about passing the memory configuration around and the result is
> >> basically the same -- pass a table from ATF to U-Boot. If there's
> >> already something, great.
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2018-06-19 5:56 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-15 9:40 [RFC] ARM: rmobile: create DT memory nodes for R8A7795 3.0 and newer Ulrich Hecht
2018-06-15 9:40 ` [U-Boot] " Ulrich Hecht
2018-06-15 9:40 ` [RFC ATF] Add SMCCC_RENESAS_MEMCONF SMC call Ulrich Hecht
2018-06-15 9:40 ` [U-Boot] " Ulrich Hecht
2018-06-15 10:09 ` [U-Boot] [RFC] ARM: rmobile: create DT memory nodes for R8A7795 3.0 and newer Marek Vasut
2018-06-15 10:09 ` Marek Vasut
2018-06-15 10:37 ` Ulrich Hecht
2018-06-15 10:37 ` [U-Boot] " Ulrich Hecht
2018-06-15 11:43 ` Marek Vasut
2018-06-15 11:43 ` Marek Vasut
2018-06-15 12:00 ` Marek Vasut
2018-06-15 12:00 ` Marek Vasut
2018-06-15 23:21 ` Laurent Pinchart
2018-06-15 23:21 ` [U-Boot] " Laurent Pinchart
2018-06-15 23:42 ` Marek Vasut
2018-06-15 23:42 ` [U-Boot] " Marek Vasut
2018-06-16 15:44 ` Laurent Pinchart
2018-06-16 15:44 ` [U-Boot] " Laurent Pinchart
2018-06-17 0:08 ` Marek Vasut
2018-06-17 0:08 ` [U-Boot] " Marek Vasut
2018-06-19 2:15 ` Laurent Pinchart
2018-06-19 2:15 ` Laurent Pinchart
2018-06-19 5:43 ` Magnus Damm
2018-06-19 5:43 ` [U-Boot] " Magnus Damm
2018-06-19 5:56 ` Laurent Pinchart [this message]
2018-06-19 5:56 ` Laurent Pinchart
2018-06-19 6:44 ` Magnus Damm
2018-06-19 6:58 ` Geert Uytterhoeven
2018-06-19 6:58 ` [U-Boot] " Geert Uytterhoeven
2018-06-19 7:11 ` Laurent Pinchart
2018-06-19 7:11 ` Laurent Pinchart
2018-06-19 7:17 ` Geert Uytterhoeven
2018-06-19 7:17 ` [U-Boot] " Geert Uytterhoeven
2018-06-20 4:55 ` Marek Vasut
2018-06-20 4:55 ` [U-Boot] " Marek Vasut
2018-06-28 17:24 ` Eugeniu Rosca
2018-06-28 17:24 ` Eugeniu Rosca
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2538185.ecTHDDYmKt@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=geert@linux-m68k.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=takuya.sakata.wz@bp.renesas.com \
--cc=u-boot@lists.denx.de \
--cc=ulrich.hecht+renesas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.