All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Cc: linux-renesas-soc@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v2 00/11] r8a77965: M3-N DU Enablement
Date: Sat, 28 Apr 2018 00:26:34 +0300	[thread overview]
Message-ID: <254152681.Kc1dWBUcyC@avalon> (raw)
In-Reply-To: <20180427165722.19445-1-kieran.bingham+renesas@ideasonboard.com>

Hi Kieran,

On Friday, 27 April 2018 19:57:11 EEST Kieran Bingham wrote:
> This series enables the DU for the M3-N R8A77965 SoC, and provides
> output on the VGA and HDMI connectors.
> 
> LVDS is not yet supported or tested.
> 
> 
> Patch 9 has the following checkpatch.pl warnings of which I have
> ignored:
> 
> ===========================================================================
> WARNING: line over 80 characters
> #44: FILE: arch/arm64/boot/dts/renesas/r8a77965.dtsi:1126:
> +                                               remote-endpoint =
> <&du_out_hdmi0>;
> 
> WARNING: line over 80 characters
> #60: FILE: arch/arm64/boot/dts/renesas/r8a77965.dtsi:1164:
> +                                               remote-endpoint =
> <&dw_hdmi0_in>;
> ===========================================================================
> 
> I don't think the remote endpoints can be shorter unless the <&phandles>
> are on a line on their own and that seems silly.
> 
> This series is available via git at the following URL:
>  git://git.kernel.org/pub/scm/linux/kernel/git/kbingham/rcar.git
>  du/m3n/enablement/v2

That's based on renesas-drivers that includes branches not ready for upstream 
yet. The patches don't apply cleanly on top of my drm/du/next branch (itself 
based on top of Dave's drm-next branch). Please don't use renesas-drivers for 
patch development and submission.

> Kieran Bingham (11):
>   dt-bindings: display: renesas: Add R-Car M3-N HDMI TX DT bindings
>   pinctrl: sh-pfc: r8a77965: Add DU RGB output pins, groups and
>     functions
>   drm: rcar-du: Split CRTC handling to support hardware indexing
>   drm: rcar-du: Allow DU groups to work with hardware indexing
>   drm: rcar-du: Add R8A77965 support
>   arm64: dts: r8a77965: Add FCPF and FCPV instances
>   arm64: dts: r8a77965: Add VSP instances
>   arm64: dts: r8a77965: Populate the DU instance placeholder
>   arm64: dts: r8a77965: Add HDMI encoder instance
>   arm64: dts: r8a77965-salvator-x: Enable DU external clocks and HDMI
>   arm64: dts: r8a77965-salvator-xs: Enable DU external clocks and HDMI
> 
>  .../display/bridge/renesas,dw-hdmi.txt        |   1 +
>  .../boot/dts/renesas/r8a77965-salvator-x.dts  |  28 ++++
>  .../boot/dts/renesas/r8a77965-salvator-xs.dts |  29 ++++
>  arch/arm64/boot/dts/renesas/r8a77965.dtsi     | 131 +++++++++++++++++-
>  drivers/gpu/drm/rcar-du/rcar_du_crtc.c        |  26 ++--
>  drivers/gpu/drm/rcar-du/rcar_du_crtc.h        |   3 +-
>  drivers/gpu/drm/rcar-du/rcar_du_drv.c         |  51 +++++--
>  drivers/gpu/drm/rcar-du/rcar_du_drv.h         |   4 +-
>  drivers/gpu/drm/rcar-du/rcar_du_group.c       |  14 +-
>  drivers/gpu/drm/rcar-du/rcar_du_group.h       |   2 +
>  drivers/gpu/drm/rcar-du/rcar_du_kms.c         |  23 ++-
>  drivers/pinctrl/sh-pfc/pfc-r8a77965.c         | 116 ++++++++++++++++
>  12 files changed, 387 insertions(+), 41 deletions(-)


-- 
Regards,

Laurent Pinchart

WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Cc: linux-renesas-soc@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v2 00/11] r8a77965: M3-N DU Enablement
Date: Sat, 28 Apr 2018 00:26:34 +0300	[thread overview]
Message-ID: <254152681.Kc1dWBUcyC@avalon> (raw)
In-Reply-To: <20180427165722.19445-1-kieran.bingham+renesas@ideasonboard.com>

Hi Kieran,

On Friday, 27 April 2018 19:57:11 EEST Kieran Bingham wrote:
> This series enables the DU for the M3-N R8A77965 SoC, and provides
> output on the VGA and HDMI connectors.
> 
> LVDS is not yet supported or tested.
> 
> 
> Patch 9 has the following checkpatch.pl warnings of which I have
> ignored:
> 
> ===========================================================================
> WARNING: line over 80 characters
> #44: FILE: arch/arm64/boot/dts/renesas/r8a77965.dtsi:1126:
> +                                               remote-endpoint =
> <&du_out_hdmi0>;
> 
> WARNING: line over 80 characters
> #60: FILE: arch/arm64/boot/dts/renesas/r8a77965.dtsi:1164:
> +                                               remote-endpoint =
> <&dw_hdmi0_in>;
> ===========================================================================
> 
> I don't think the remote endpoints can be shorter unless the <&phandles>
> are on a line on their own and that seems silly.
> 
> This series is available via git at the following URL:
>  git://git.kernel.org/pub/scm/linux/kernel/git/kbingham/rcar.git
>  du/m3n/enablement/v2

That's based on renesas-drivers that includes branches not ready for upstream 
yet. The patches don't apply cleanly on top of my drm/du/next branch (itself 
based on top of Dave's drm-next branch). Please don't use renesas-drivers for 
patch development and submission.

> Kieran Bingham (11):
>   dt-bindings: display: renesas: Add R-Car M3-N HDMI TX DT bindings
>   pinctrl: sh-pfc: r8a77965: Add DU RGB output pins, groups and
>     functions
>   drm: rcar-du: Split CRTC handling to support hardware indexing
>   drm: rcar-du: Allow DU groups to work with hardware indexing
>   drm: rcar-du: Add R8A77965 support
>   arm64: dts: r8a77965: Add FCPF and FCPV instances
>   arm64: dts: r8a77965: Add VSP instances
>   arm64: dts: r8a77965: Populate the DU instance placeholder
>   arm64: dts: r8a77965: Add HDMI encoder instance
>   arm64: dts: r8a77965-salvator-x: Enable DU external clocks and HDMI
>   arm64: dts: r8a77965-salvator-xs: Enable DU external clocks and HDMI
> 
>  .../display/bridge/renesas,dw-hdmi.txt        |   1 +
>  .../boot/dts/renesas/r8a77965-salvator-x.dts  |  28 ++++
>  .../boot/dts/renesas/r8a77965-salvator-xs.dts |  29 ++++
>  arch/arm64/boot/dts/renesas/r8a77965.dtsi     | 131 +++++++++++++++++-
>  drivers/gpu/drm/rcar-du/rcar_du_crtc.c        |  26 ++--
>  drivers/gpu/drm/rcar-du/rcar_du_crtc.h        |   3 +-
>  drivers/gpu/drm/rcar-du/rcar_du_drv.c         |  51 +++++--
>  drivers/gpu/drm/rcar-du/rcar_du_drv.h         |   4 +-
>  drivers/gpu/drm/rcar-du/rcar_du_group.c       |  14 +-
>  drivers/gpu/drm/rcar-du/rcar_du_group.h       |   2 +
>  drivers/gpu/drm/rcar-du/rcar_du_kms.c         |  23 ++-
>  drivers/pinctrl/sh-pfc/pfc-r8a77965.c         | 116 ++++++++++++++++
>  12 files changed, 387 insertions(+), 41 deletions(-)


-- 
Regards,

Laurent Pinchart



_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2018-04-27 21:26 UTC|newest]

Thread overview: 71+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-27 16:57 [PATCH v2 00/11] r8a77965: M3-N DU Enablement Kieran Bingham
2018-04-27 16:57 ` Kieran Bingham
2018-04-27 16:57 ` [PATCH v2 01/11] dt-bindings: display: renesas: Add R-Car M3-N HDMI TX DT bindings Kieran Bingham
2018-04-27 16:57   ` Kieran Bingham
2018-04-27 21:17   ` Laurent Pinchart
2018-04-27 21:17     ` Laurent Pinchart
2018-04-27 16:57 ` [PATCH v2 02/11] pinctrl: sh-pfc: r8a77965: Add DU RGB output pins, groups and functions Kieran Bingham
2018-04-27 16:57   ` Kieran Bingham
2018-04-27 16:57 ` [PATCH v2 03/11] drm: rcar-du: Split CRTC handling to support hardware indexing Kieran Bingham
2018-04-27 16:57   ` Kieran Bingham
2018-04-27 21:21   ` Laurent Pinchart
2018-04-27 16:57 ` [PATCH v2 04/11] drm: rcar-du: Allow DU groups to work with " Kieran Bingham
2018-04-27 16:57   ` Kieran Bingham
2018-04-27 16:57 ` [PATCH v2 05/11] drm: rcar-du: Add R8A77965 support Kieran Bingham
2018-04-27 16:57   ` Kieran Bingham
2018-04-27 16:57 ` [PATCH v2 06/11] arm64: dts: r8a77965: Add FCPF and FCPV instances Kieran Bingham
2018-04-27 16:57   ` Kieran Bingham
2018-04-27 16:57   ` Kieran Bingham
2018-04-30  7:27   ` Simon Horman
2018-04-30  7:27     ` Simon Horman
2018-04-27 16:57 ` [PATCH v2 07/11] arm64: dts: r8a77965: Add VSP instances Kieran Bingham
2018-04-27 16:57   ` Kieran Bingham
2018-04-27 16:57   ` Kieran Bingham
2018-04-30  7:28   ` Simon Horman
2018-04-30  7:28     ` Simon Horman
2018-04-27 16:57 ` [PATCH v2 08/11] arm64: dts: r8a77965: Populate the DU instance placeholder Kieran Bingham
2018-04-27 16:57   ` Kieran Bingham
2018-04-27 16:57   ` Kieran Bingham
2018-04-30  7:30   ` Simon Horman
2018-04-30  7:30     ` Simon Horman
2018-04-27 16:57 ` [PATCH v2 09/11] arm64: dts: r8a77965: Add HDMI encoder instance Kieran Bingham
2018-04-27 16:57   ` Kieran Bingham
2018-04-27 16:57   ` Kieran Bingham
2018-04-30  7:32   ` Simon Horman
2018-04-30  7:32     ` Simon Horman
2018-04-27 16:57 ` [PATCH v2 10/11] arm64: dts: r8a77965-salvator-x: Enable DU external clocks and HDMI Kieran Bingham
2018-04-27 16:57   ` Kieran Bingham
2018-04-27 16:57   ` Kieran Bingham
2018-04-27 21:34   ` Laurent Pinchart
2018-04-27 21:34     ` Laurent Pinchart
2018-04-27 21:34     ` Laurent Pinchart
2018-04-30  7:34     ` Simon Horman
2018-04-30  7:34       ` Simon Horman
2018-05-28  9:06   ` Geert Uytterhoeven
2018-05-28  9:06     ` Geert Uytterhoeven
2018-05-28  9:06     ` Geert Uytterhoeven
2018-05-29  1:44     ` Kuninori Morimoto
2018-05-29  1:44       ` Kuninori Morimoto
2018-05-29  6:48       ` Geert Uytterhoeven
2018-05-29  6:48         ` Geert Uytterhoeven
2018-05-29  6:48         ` Geert Uytterhoeven
2018-05-29  8:08         ` Kuninori Morimoto
2018-05-29  8:08           ` Kuninori Morimoto
2018-05-29  8:08           ` Kuninori Morimoto
2018-05-29  9:08     ` Kieran Bingham
2018-05-29  9:08       ` Kieran Bingham
2018-05-29  9:08       ` Kieran Bingham
2018-05-29  9:12       ` Geert Uytterhoeven
2018-05-29  9:12         ` Geert Uytterhoeven
2018-05-29  9:12         ` Geert Uytterhoeven
2018-04-27 16:57 ` [PATCH v2 11/11] arm64: dts: r8a77965-salvator-xs: " Kieran Bingham
2018-04-27 16:57   ` Kieran Bingham
2018-04-27 16:57   ` Kieran Bingham
2018-04-27 21:32   ` Laurent Pinchart
2018-04-27 21:32     ` Laurent Pinchart
2018-04-27 21:32     ` Laurent Pinchart
2018-04-27 21:40     ` Kieran Bingham
2018-04-27 21:40       ` Kieran Bingham
2018-04-27 21:40       ` Kieran Bingham
2018-04-27 21:26 ` Laurent Pinchart [this message]
2018-04-27 21:26   ` [PATCH v2 00/11] r8a77965: M3-N DU Enablement Laurent Pinchart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=254152681.Kc1dWBUcyC@avalon \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=kieran.bingham+renesas@ideasonboard.com \
    --cc=linux-renesas-soc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.