All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jernej Škrabec" <jernej.skrabec@gmail.com>
To: Dang Huynh <danct12@disroot.org>
Cc: danct12@disroot.org, Rob Herring <robh+dt@kernel.org>,
	Maxime Ripard <mripard@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: allwinner: pinetab: Add HDMI support
Date: Tue, 14 Sep 2021 22:26:51 +0200	[thread overview]
Message-ID: <2558517.IGp7HM5rsX@kista> (raw)
In-Reply-To: <20210914193732.3047668-1-danct12@disroot.org>

Hi!

Dne torek, 14. september 2021 ob 21:37:32 CEST je Dang Huynh napisal(a):
> This patch enables HDMI display on PINE64 PineTab.
> 
> The PineTab has a HDMI Type C (mini) port.
> 
> Signed-off-by: Dang Huynh <danct12@disroot.org>
> ---
>  .../boot/dts/allwinner/sun50i-a64-pinetab.dts | 26 +++++++++++++++++++
>  1 file changed, 26 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinetab.dts b/arch/
arm64/boot/dts/allwinner/sun50i-a64-pinetab.dts
> index 6a4af14718f5..adb0b28b06d8 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinetab.dts
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinetab.dts
> @@ -35,6 +35,17 @@ chosen {
>  		stdout-path = "serial0:115200n8";
>  	};
>  
> +	hdmi-connector {
> +		compatible = "hdmi-connector";
> +		type = "c";
> +
> +		port {
> +			hdmi_con_in: endpoint {
> +				remote-endpoint = <&hdmi_out_con>;
> +			};
> +		};
> +	};
> +
>  	i2c-csi {
>  		compatible = "i2c-gpio";
>  		sda-gpios = <&pio 4 13 GPIO_ACTIVE_HIGH>; /* PE13 */
> @@ -410,6 +421,21 @@ &reg_rtc_ldo {
>  	regulator-name = "vcc-rtc";
>  };
>  
> +&simplefb_hdmi {
> +	vcc-hdmi-supply = <&reg_dldo1>;

You have to set status to okay here.

With that fixed, you can add:
Reviewed-by: Jernej Skrabec <jernej.skrabec@gmail.com>

Best regards,
Jernej

> +};
> +
> +&hdmi {
> +	hvcc-supply = <&reg_dldo1>;
> +	status = "okay";
> +};
> +
> +&hdmi_out {
> +	hdmi_out_con: endpoint {
> +		remote-endpoint = <&hdmi_con_in>;
> +	};
> +};
> +
>  &sound {
>  	status = "okay";
>  	simple-audio-card,aux-devs = <&codec_analog>, <&speaker_amp>;
> -- 
> 2.33.0
> 
> 



WARNING: multiple messages have this Message-ID (diff)
From: "Jernej Škrabec" <jernej.skrabec@gmail.com>
To: Dang Huynh <danct12@disroot.org>
Cc: danct12@disroot.org, Rob Herring <robh+dt@kernel.org>,
	Maxime Ripard <mripard@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: allwinner: pinetab: Add HDMI support
Date: Tue, 14 Sep 2021 22:26:51 +0200	[thread overview]
Message-ID: <2558517.IGp7HM5rsX@kista> (raw)
In-Reply-To: <20210914193732.3047668-1-danct12@disroot.org>

Hi!

Dne torek, 14. september 2021 ob 21:37:32 CEST je Dang Huynh napisal(a):
> This patch enables HDMI display on PINE64 PineTab.
> 
> The PineTab has a HDMI Type C (mini) port.
> 
> Signed-off-by: Dang Huynh <danct12@disroot.org>
> ---
>  .../boot/dts/allwinner/sun50i-a64-pinetab.dts | 26 +++++++++++++++++++
>  1 file changed, 26 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinetab.dts b/arch/
arm64/boot/dts/allwinner/sun50i-a64-pinetab.dts
> index 6a4af14718f5..adb0b28b06d8 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinetab.dts
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinetab.dts
> @@ -35,6 +35,17 @@ chosen {
>  		stdout-path = "serial0:115200n8";
>  	};
>  
> +	hdmi-connector {
> +		compatible = "hdmi-connector";
> +		type = "c";
> +
> +		port {
> +			hdmi_con_in: endpoint {
> +				remote-endpoint = <&hdmi_out_con>;
> +			};
> +		};
> +	};
> +
>  	i2c-csi {
>  		compatible = "i2c-gpio";
>  		sda-gpios = <&pio 4 13 GPIO_ACTIVE_HIGH>; /* PE13 */
> @@ -410,6 +421,21 @@ &reg_rtc_ldo {
>  	regulator-name = "vcc-rtc";
>  };
>  
> +&simplefb_hdmi {
> +	vcc-hdmi-supply = <&reg_dldo1>;

You have to set status to okay here.

With that fixed, you can add:
Reviewed-by: Jernej Skrabec <jernej.skrabec@gmail.com>

Best regards,
Jernej

> +};
> +
> +&hdmi {
> +	hvcc-supply = <&reg_dldo1>;
> +	status = "okay";
> +};
> +
> +&hdmi_out {
> +	hdmi_out_con: endpoint {
> +		remote-endpoint = <&hdmi_con_in>;
> +	};
> +};
> +
>  &sound {
>  	status = "okay";
>  	simple-audio-card,aux-devs = <&codec_analog>, <&speaker_amp>;
> -- 
> 2.33.0
> 
> 



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-09-14 20:26 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-14 19:37 [PATCH] arm64: dts: allwinner: pinetab: Add HDMI support Dang Huynh
2021-09-14 19:37 ` Dang Huynh
2021-09-14 20:26 ` Jernej Škrabec [this message]
2021-09-14 20:26   ` Jernej Škrabec
2021-09-15  5:47   ` Dang Huynh
2021-09-15  5:47     ` Dang Huynh
2021-09-15 16:31     ` Jernej Škrabec
2021-09-15 16:31       ` Jernej Škrabec
2021-09-16 13:52 ` Maxime Ripard
2021-09-16 13:52   ` Maxime Ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2558517.IGp7HM5rsX@kista \
    --to=jernej.skrabec@gmail.com \
    --cc=danct12@disroot.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sunxi@lists.linux.dev \
    --cc=mripard@kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.