From: Dang Huynh <danct12@disroot.org>
To: "Jernej Škrabec" <jernej.skrabec@gmail.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Maxime Ripard <mripard@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: allwinner: pinetab: Add HDMI support
Date: Wed, 15 Sep 2021 12:47:31 +0700 [thread overview]
Message-ID: <4816863.IXWdtHWlKd@melttower> (raw)
In-Reply-To: <2558517.IGp7HM5rsX@kista>
On Wednesday, September 15, 2021 3:26:51 AM +07 Jernej Škrabec wrote:
> > +&simplefb_hdmi {
> > + vcc-hdmi-supply = <®_dldo1>;
>
> You have to set status to okay here.
>
> With that fixed, you can add:
> Reviewed-by: Jernej Skrabec <jernej.skrabec@gmail.com>
>
> Best regards,
> Jernej
>
Is it really needed? The DE2 HDMI driver can be loaded and make this pretty
much obsolete.
WARNING: multiple messages have this Message-ID (diff)
From: Dang Huynh <danct12@disroot.org>
To: "Jernej Škrabec" <jernej.skrabec@gmail.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Maxime Ripard <mripard@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: allwinner: pinetab: Add HDMI support
Date: Wed, 15 Sep 2021 12:47:31 +0700 [thread overview]
Message-ID: <4816863.IXWdtHWlKd@melttower> (raw)
In-Reply-To: <2558517.IGp7HM5rsX@kista>
On Wednesday, September 15, 2021 3:26:51 AM +07 Jernej Škrabec wrote:
> > +&simplefb_hdmi {
> > + vcc-hdmi-supply = <®_dldo1>;
>
> You have to set status to okay here.
>
> With that fixed, you can add:
> Reviewed-by: Jernej Skrabec <jernej.skrabec@gmail.com>
>
> Best regards,
> Jernej
>
Is it really needed? The DE2 HDMI driver can be loaded and make this pretty
much obsolete.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-09-15 5:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-14 19:37 [PATCH] arm64: dts: allwinner: pinetab: Add HDMI support Dang Huynh
2021-09-14 19:37 ` Dang Huynh
2021-09-14 20:26 ` Jernej Škrabec
2021-09-14 20:26 ` Jernej Škrabec
2021-09-15 5:47 ` Dang Huynh [this message]
2021-09-15 5:47 ` Dang Huynh
2021-09-15 16:31 ` Jernej Škrabec
2021-09-15 16:31 ` Jernej Škrabec
2021-09-16 13:52 ` Maxime Ripard
2021-09-16 13:52 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4816863.IXWdtHWlKd@melttower \
--to=danct12@disroot.org \
--cc=devicetree@vger.kernel.org \
--cc=jernej.skrabec@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=mripard@kernel.org \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.