All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mikel Rychliski <mikel@mikelr.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: "David (ChunMing) Zhou" <David1.Zhou@amd.com>,
	linux-pci@vger.kernel.org,
	"Matthew Garrett" <matthewgarrett@google.com>,
	amd-gfx@lists.freedesktop.org,
	"Alex Deucher" <alexander.deucher@amd.com>,
	"Christian König" <christian.koenig@amd.com>
Subject: Re: [PATCH 2/4] PCI: Use ioremap, not phys_to_virt for platform rom
Date: Tue, 03 Mar 2020 22:20:45 -0500	[thread overview]
Message-ID: <2616060.jBR9Tdob1i@glidewell> (raw)
In-Reply-To: <20200303143827.GA78253@google.com>

On Tuesday, March 3, 2020 9:38:27 AM EST Bjorn Helgaas wrote:
> Cosmetics:
> 
> s/ioremap/ioremap()/ (also in commit log)
> s/phys_to_virt/phys_to_virt()/ (also in commit log)
> s/pci_platform_rom/pci_platform_rom()/ (commit log)
> s/rom/ROM/

> This changes the interface of pci_platform_rom() (the caller is now
> responsible for doing an iounmap()).  That should be mentioned in the
> function comment, and I think the subsequent patches should be
> squashed into this one so the interface change and the caller changes
> are done simultaneously.
> 
> Also, it looks like nvbios_platform.init() (platform_init()) needs a
> similar change?

Hi Bjorn,

Thank you for your comments. I'll make the suggested changes, add an iounmap() 
in the nouveau usage, and provide a new two-patch series.
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

WARNING: multiple messages have this Message-ID (diff)
From: Mikel Rychliski <mikel@mikelr.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: amd-gfx@lists.freedesktop.org, linux-pci@vger.kernel.org,
	"Alex Deucher" <alexander.deucher@amd.com>,
	"Christian König" <christian.koenig@amd.com>,
	"David (ChunMing) Zhou" <David1.Zhou@amd.com>,
	"Matthew Garrett" <matthewgarrett@google.com>
Subject: Re: [PATCH 2/4] PCI: Use ioremap, not phys_to_virt for platform rom
Date: Tue, 03 Mar 2020 22:20:45 -0500	[thread overview]
Message-ID: <2616060.jBR9Tdob1i@glidewell> (raw)
In-Reply-To: <20200303143827.GA78253@google.com>

On Tuesday, March 3, 2020 9:38:27 AM EST Bjorn Helgaas wrote:
> Cosmetics:
> 
> s/ioremap/ioremap()/ (also in commit log)
> s/phys_to_virt/phys_to_virt()/ (also in commit log)
> s/pci_platform_rom/pci_platform_rom()/ (commit log)
> s/rom/ROM/

> This changes the interface of pci_platform_rom() (the caller is now
> responsible for doing an iounmap()).  That should be mentioned in the
> function comment, and I think the subsequent patches should be
> squashed into this one so the interface change and the caller changes
> are done simultaneously.
> 
> Also, it looks like nvbios_platform.init() (platform_init()) needs a
> similar change?

Hi Bjorn,

Thank you for your comments. I'll make the suggested changes, add an iounmap() 
in the nouveau usage, and provide a new two-patch series.

  reply	other threads:[~2020-03-04  3:53 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-03  3:34 [PATCH 0/4] Fix loading of radeon BIOS from 32-bit EFI Mikel Rychliski
2020-03-03  3:34 ` Mikel Rychliski
2020-03-03  3:34 ` [PATCH 1/4] drm/radeon: Stop directly referencing iomem Mikel Rychliski
2020-03-03  3:34   ` Mikel Rychliski
2020-03-03  3:34 ` [PATCH 2/4] PCI: Use ioremap, not phys_to_virt for platform rom Mikel Rychliski
2020-03-03  3:34   ` Mikel Rychliski
2020-03-03 14:38   ` Bjorn Helgaas
2020-03-03 14:38     ` Bjorn Helgaas
2020-03-04  3:20     ` Mikel Rychliski [this message]
2020-03-04  3:20       ` Mikel Rychliski
2020-03-17 14:28   ` Christoph Hellwig
2020-03-17 14:28     ` Christoph Hellwig
2020-03-03  3:34 ` [PATCH 3/4] drm/radeon: iounmap unused mapping Mikel Rychliski
2020-03-03  3:34   ` Mikel Rychliski
2020-03-17 14:29   ` Christoph Hellwig
2020-03-17 14:29     ` Christoph Hellwig
2020-03-03  3:34 ` [PATCH 4/4] drm/amdgpu: " Mikel Rychliski
2020-03-03  3:34   ` Mikel Rychliski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2616060.jBR9Tdob1i@glidewell \
    --to=mikel@mikelr.com \
    --cc=David1.Zhou@amd.com \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=christian.koenig@amd.com \
    --cc=helgaas@kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=matthewgarrett@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.