[LTP] [PATCH] swapping01.c: use .needs_abi_bits = 64

[LTP] [PATCH] swapping01.c: use .needs_abi_bits = 64

[Avinesh Kumar via ltp]

As this test is not designed for 32-bit systems, so this follow
commit 6b7ccccbdaf8 ("swapping01: Use .skip_in_compat = 1")

.skip_in_compat misses native 32-bit; .needs_abi_bits = 64 covers both.

Signed-off-by: Avinesh Kumar <avinesh.kumar@suse.com>
---
 testcases/kernel/mem/swapping/swapping01.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/testcases/kernel/mem/swapping/swapping01.c b/testcases/kernel/mem/swapping/swapping01.c
index c773f2226..b1489b7cf 100644
--- a/testcases/kernel/mem/swapping/swapping01.c
+++ b/testcases/kernel/mem/swapping/swapping01.c
@@ -174,7 +174,7 @@ static struct tst_test test = {
 	.min_mem_avail = 10,
 	.runtime = 600,
 	.test_all = test_swapping,
-	.skip_in_compat = 1,
+	.needs_abi_bits = 64,
 	.needs_kconfigs = (const char *[]) {
 		"CONFIG_SWAP=y",
 		NULL
-- 
2.54.0


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] swapping01.c: use .needs_abi_bits = 64

[linuxtestproject.agent]

Hi Avinesh,

On Tue, 23 Jun 2026, Avinesh Kumar wrote:
> swapping01.c: use .needs_abi_bits = 64

> As this test is not designed for 32-bit systems, so this follow
> commit 6b7ccccbdaf8 ("swapping01: Use .skip_in_compat = 1")

"so this follow commit" is not grammatically correct. Perhaps:

  "As this test is not designed for 32-bit systems, this follows
   up on commit 6b7ccccbdaf8 ..."

or:

  "Since this test is not designed for 32-bit systems, follow up
   on commit 6b7ccccbdaf8 ..."

Verdict - Needs revision

---
Note:

The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.

Regards,
LTP AI Reviewer

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH] swapping01.c: use .needs_abi_bits = 64

[Andrea Cervesato via ltp]

Reviewed-by: Andrea Cervesato <andrea.cervesato@suse.com>

--
Andrea Cervesato
SUSE QE Automation Engineer Linux
andrea.cervesato@suse.com

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH] swapping01.c: use .needs_abi_bits = 64

[Li Wang]

Merged, thanks!

Regards,
Li Wang

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp