* [LTP] [PATCH] swapping01.c: use .needs_abi_bits = 64
@ 2026-06-23 20:03 Avinesh Kumar via ltp
2026-06-23 22:14 ` [LTP] " linuxtestproject.agent
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Avinesh Kumar via ltp @ 2026-06-23 20:03 UTC (permalink / raw)
To: ltp
As this test is not designed for 32-bit systems, so this follow
commit 6b7ccccbdaf8 ("swapping01: Use .skip_in_compat = 1")
.skip_in_compat misses native 32-bit; .needs_abi_bits = 64 covers both.
Signed-off-by: Avinesh Kumar <avinesh.kumar@suse.com>
---
testcases/kernel/mem/swapping/swapping01.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/testcases/kernel/mem/swapping/swapping01.c b/testcases/kernel/mem/swapping/swapping01.c
index c773f2226..b1489b7cf 100644
--- a/testcases/kernel/mem/swapping/swapping01.c
+++ b/testcases/kernel/mem/swapping/swapping01.c
@@ -174,7 +174,7 @@ static struct tst_test test = {
.min_mem_avail = 10,
.runtime = 600,
.test_all = test_swapping,
- .skip_in_compat = 1,
+ .needs_abi_bits = 64,
.needs_kconfigs = (const char *[]) {
"CONFIG_SWAP=y",
NULL
--
2.54.0
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [LTP] swapping01.c: use .needs_abi_bits = 64
2026-06-23 20:03 [LTP] [PATCH] swapping01.c: use .needs_abi_bits = 64 Avinesh Kumar via ltp
@ 2026-06-23 22:14 ` linuxtestproject.agent
2026-06-24 8:30 ` [LTP] [PATCH] " Andrea Cervesato via ltp
2026-06-28 4:46 ` Li Wang
2 siblings, 0 replies; 4+ messages in thread
From: linuxtestproject.agent @ 2026-06-23 22:14 UTC (permalink / raw)
To: Avinesh Kumar; +Cc: ltp
Hi Avinesh,
On Tue, 23 Jun 2026, Avinesh Kumar wrote:
> swapping01.c: use .needs_abi_bits = 64
> As this test is not designed for 32-bit systems, so this follow
> commit 6b7ccccbdaf8 ("swapping01: Use .skip_in_compat = 1")
"so this follow commit" is not grammatically correct. Perhaps:
"As this test is not designed for 32-bit systems, this follows
up on commit 6b7ccccbdaf8 ..."
or:
"Since this test is not designed for 32-bit systems, follow up
on commit 6b7ccccbdaf8 ..."
Verdict - Needs revision
---
Note:
The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.
Regards,
LTP AI Reviewer
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [LTP] [PATCH] swapping01.c: use .needs_abi_bits = 64
2026-06-23 20:03 [LTP] [PATCH] swapping01.c: use .needs_abi_bits = 64 Avinesh Kumar via ltp
2026-06-23 22:14 ` [LTP] " linuxtestproject.agent
@ 2026-06-24 8:30 ` Andrea Cervesato via ltp
2026-06-28 4:46 ` Li Wang
2 siblings, 0 replies; 4+ messages in thread
From: Andrea Cervesato via ltp @ 2026-06-24 8:30 UTC (permalink / raw)
To: Avinesh Kumar via ltp; +Cc: ltp
Reviewed-by: Andrea Cervesato <andrea.cervesato@suse.com>
--
Andrea Cervesato
SUSE QE Automation Engineer Linux
andrea.cervesato@suse.com
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [LTP] [PATCH] swapping01.c: use .needs_abi_bits = 64
2026-06-23 20:03 [LTP] [PATCH] swapping01.c: use .needs_abi_bits = 64 Avinesh Kumar via ltp
2026-06-23 22:14 ` [LTP] " linuxtestproject.agent
2026-06-24 8:30 ` [LTP] [PATCH] " Andrea Cervesato via ltp
@ 2026-06-28 4:46 ` Li Wang
2 siblings, 0 replies; 4+ messages in thread
From: Li Wang @ 2026-06-28 4:46 UTC (permalink / raw)
To: Avinesh Kumar, ltp
Merged, thanks!
Regards,
Li Wang
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-06-28 4:46 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-23 20:03 [LTP] [PATCH] swapping01.c: use .needs_abi_bits = 64 Avinesh Kumar via ltp
2026-06-23 22:14 ` [LTP] " linuxtestproject.agent
2026-06-24 8:30 ` [LTP] [PATCH] " Andrea Cervesato via ltp
2026-06-28 4:46 ` Li Wang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.