From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Liviu Dudau <Liviu.Dudau@arm.com>,
Liviu Dudau <liviu@dudau.co.uk>,
linaro-kernel <linaro-kernel@lists.linaro.org>,
Catalin Marinas <Catalin.Marinas@arm.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
linux-pci <linux-pci@vger.kernel.org>,
Will Deacon <Will.Deacon@arm.com>,
LKML <linux-kernel@vger.kernel.org>,
Tanmay Inamdar <tinamdar@apm.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Bjorn Helgaas <bhelgaas@google.com>
Subject: Re: [PATCH v6 6/6] pci: Add support for creating a generic host_bridge from device tree
Date: Tue, 11 Mar 2014 11:43:39 +0100 [thread overview]
Message-ID: <2664356.LLPHGvlG5M@wuerfel> (raw)
In-Reply-To: <20140311094641.GA27064@e106497-lin.cambridge.arm.com>
On Tuesday 11 March 2014 09:46:41 Liviu Dudau wrote:
> On Tue, Mar 11, 2014 at 06:50:24AM +0000, Arnd Bergmann wrote:
> > On Monday 10 March 2014 21:56:00 Liviu Dudau wrote:
> > >
> > > PCI_IOBASE is always defined. See the discussion with Russell on this subject.
> > >
> > > include/asm-generic/io.h has at line 118:
> > >
> > > #ifndef PCI_IOBASE
> > > #define PCI_IOBASE ((void __iomem *) 0)
> > > #endif
> >
> > That is only defined for those that use asm-generic/pci.h, which most architectures
> > don't.
>
> I think it is defined for anyone that #includes <asm-generic/io.h>. There is no other
> #ifdef around that.
>
My mistake, I meant to write asm-generic/io.h.
On a related note, I would actually prefer to get rid of this PCI_IOBASE
default and move it into the architectures that really want it like this.
The default when PCI_IOBASE is not set IMHO should be to also not provide
inb/outb and ioport_map() helpers, but we need a little more infrastructure
to actually make the kernel build in all valid configuration when we remove them.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v6 6/6] pci: Add support for creating a generic host_bridge from device tree
Date: Tue, 11 Mar 2014 11:43:39 +0100 [thread overview]
Message-ID: <2664356.LLPHGvlG5M@wuerfel> (raw)
In-Reply-To: <20140311094641.GA27064@e106497-lin.cambridge.arm.com>
On Tuesday 11 March 2014 09:46:41 Liviu Dudau wrote:
> On Tue, Mar 11, 2014 at 06:50:24AM +0000, Arnd Bergmann wrote:
> > On Monday 10 March 2014 21:56:00 Liviu Dudau wrote:
> > >
> > > PCI_IOBASE is always defined. See the discussion with Russell on this subject.
> > >
> > > include/asm-generic/io.h has at line 118:
> > >
> > > #ifndef PCI_IOBASE
> > > #define PCI_IOBASE ((void __iomem *) 0)
> > > #endif
> >
> > That is only defined for those that use asm-generic/pci.h, which most architectures
> > don't.
>
> I think it is defined for anyone that #includes <asm-generic/io.h>. There is no other
> #ifdef around that.
>
My mistake, I meant to write asm-generic/io.h.
On a related note, I would actually prefer to get rid of this PCI_IOBASE
default and move it into the architectures that really want it like this.
The default when PCI_IOBASE is not set IMHO should be to also not provide
inb/outb and ioport_map() helpers, but we need a little more infrastructure
to actually make the kernel build in all valid configuration when we remove them.
Arnd
next prev parent reply other threads:[~2014-03-11 10:43 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-05 11:48 [PATCH v6 0/6] [RFC] Support for creating generic host_bridge from device tree Liviu Dudau
2014-03-05 11:48 ` Liviu Dudau
2014-03-05 11:48 ` [PATCH v6 1/6] pci: Introduce pci_register_io_range() helper function Liviu Dudau
2014-03-05 11:48 ` Liviu Dudau
2014-03-05 11:48 ` Liviu Dudau
2014-03-07 19:35 ` Grant Likely
2014-03-07 19:35 ` Grant Likely
2014-03-07 19:35 ` Grant Likely
2014-03-05 11:48 ` [PATCH v6 2/6] pci: OF: Fix the conversion of IO ranges into IO resources Liviu Dudau
2014-03-05 11:48 ` Liviu Dudau
2014-03-05 11:48 ` Liviu Dudau
2014-03-07 21:06 ` Grant Likely
2014-03-07 21:06 ` Grant Likely
2014-03-08 17:17 ` Arnd Bergmann
2014-03-08 17:17 ` Arnd Bergmann
2014-03-05 11:48 ` [PATCH v6 3/6] pci: Create pci_host_bridge before its associated bus in pci_create_root_bus Liviu Dudau
2014-03-05 11:48 ` Liviu Dudau
2014-03-07 21:07 ` Grant Likely
2014-03-07 21:07 ` Grant Likely
2014-03-05 11:48 ` [PATCH v6 4/6] pci: Introduce a domain number for pci_host_bridge Liviu Dudau
2014-03-05 11:48 ` Liviu Dudau
2014-03-07 21:09 ` Grant Likely
2014-03-07 21:09 ` Grant Likely
2014-03-05 11:48 ` [PATCH v6 5/6] pci: Export find_pci_host_bridge() function Liviu Dudau
2014-03-05 11:48 ` Liviu Dudau
2014-03-05 11:48 ` [PATCH v6 6/6] pci: Add support for creating a generic host_bridge from device tree Liviu Dudau
2014-03-05 11:48 ` Liviu Dudau
2014-03-07 21:14 ` Grant Likely
2014-03-07 21:14 ` Grant Likely
2014-03-08 10:29 ` Liviu Dudau
2014-03-08 10:29 ` Liviu Dudau
2014-03-08 10:29 ` Liviu Dudau
2014-03-08 17:15 ` Arnd Bergmann
2014-03-08 17:15 ` Arnd Bergmann
2014-03-10 14:44 ` Liviu Dudau
2014-03-10 14:44 ` Liviu Dudau
2014-03-10 15:21 ` Arnd Bergmann
2014-03-10 15:21 ` Arnd Bergmann
2014-03-10 16:33 ` Liviu Dudau
2014-03-10 16:33 ` Liviu Dudau
2014-03-10 18:59 ` Arnd Bergmann
2014-03-10 18:59 ` Arnd Bergmann
2014-03-10 19:16 ` Geert Uytterhoeven
2014-03-10 19:16 ` Geert Uytterhoeven
2014-03-10 19:28 ` Arnd Bergmann
2014-03-10 19:28 ` Arnd Bergmann
2014-03-10 19:28 ` Arnd Bergmann
2014-03-10 21:56 ` Liviu Dudau
2014-03-10 21:56 ` Liviu Dudau
2014-03-10 21:56 ` Liviu Dudau
2014-03-11 6:50 ` Arnd Bergmann
2014-03-11 6:50 ` Arnd Bergmann
2014-03-11 6:50 ` Arnd Bergmann
2014-03-11 9:46 ` Liviu Dudau
2014-03-11 9:46 ` Liviu Dudau
2014-03-11 10:43 ` Arnd Bergmann [this message]
2014-03-11 10:43 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2664356.LLPHGvlG5M@wuerfel \
--to=arnd@arndb.de \
--cc=Catalin.Marinas@arm.com \
--cc=Liviu.Dudau@arm.com \
--cc=Will.Deacon@arm.com \
--cc=benh@kernel.crashing.org \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=liviu@dudau.co.uk \
--cc=tinamdar@apm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.