From: Arnd Bergmann <arnd@arndb.de>
To: Liviu Dudau <Liviu.Dudau@arm.com>
Cc: "linux-pci" <linux-pci@vger.kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Catalin Marinas <Catalin.Marinas@arm.com>,
Will Deacon <Will.Deacon@arm.com>,
"linaro-kernel" <linaro-kernel@lists.linaro.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
LKML <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
LAKML <linux-arm-kernel@lists.infradead.org>,
Tanmay Inamdar <tinamdar@apm.com>
Subject: Re: [PATCH v6 2/6] pci: OF: Fix the conversion of IO ranges into IO resources.
Date: Sat, 8 Mar 2014 18:17:39 +0100 [thread overview]
Message-ID: <201403081817.39810.arnd@arndb.de> (raw)
In-Reply-To: <1394020137-1830-3-git-send-email-Liviu.Dudau@arm.com>
On Wednesday 05 March 2014, Liviu Dudau wrote:
> + unsigned long port = -1;
> + if (!pci_register_io_range(range->cpu_addr, range->size))
> + port = pci_address_to_pio(range->cpu_addr);
I don't remember the outcome of my suggestion to just return 'port' from
pci_register_io_range(). In my mind that would be much simpler than
adding the range in a data structure just so we can look it up in the very
next line.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v6 2/6] pci: OF: Fix the conversion of IO ranges into IO resources.
Date: Sat, 8 Mar 2014 18:17:39 +0100 [thread overview]
Message-ID: <201403081817.39810.arnd@arndb.de> (raw)
In-Reply-To: <1394020137-1830-3-git-send-email-Liviu.Dudau@arm.com>
On Wednesday 05 March 2014, Liviu Dudau wrote:
> + unsigned long port = -1;
> + if (!pci_register_io_range(range->cpu_addr, range->size))
> + port = pci_address_to_pio(range->cpu_addr);
I don't remember the outcome of my suggestion to just return 'port' from
pci_register_io_range(). In my mind that would be much simpler than
adding the range in a data structure just so we can look it up in the very
next line.
Arnd
next prev parent reply other threads:[~2014-03-08 17:18 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-05 11:48 [PATCH v6 0/6] [RFC] Support for creating generic host_bridge from device tree Liviu Dudau
2014-03-05 11:48 ` Liviu Dudau
2014-03-05 11:48 ` [PATCH v6 1/6] pci: Introduce pci_register_io_range() helper function Liviu Dudau
2014-03-05 11:48 ` Liviu Dudau
2014-03-05 11:48 ` Liviu Dudau
2014-03-07 19:35 ` Grant Likely
2014-03-07 19:35 ` Grant Likely
2014-03-07 19:35 ` Grant Likely
2014-03-05 11:48 ` [PATCH v6 2/6] pci: OF: Fix the conversion of IO ranges into IO resources Liviu Dudau
2014-03-05 11:48 ` Liviu Dudau
2014-03-05 11:48 ` Liviu Dudau
2014-03-07 21:06 ` Grant Likely
2014-03-07 21:06 ` Grant Likely
2014-03-08 17:17 ` Arnd Bergmann [this message]
2014-03-08 17:17 ` Arnd Bergmann
2014-03-05 11:48 ` [PATCH v6 3/6] pci: Create pci_host_bridge before its associated bus in pci_create_root_bus Liviu Dudau
2014-03-05 11:48 ` Liviu Dudau
2014-03-07 21:07 ` Grant Likely
2014-03-07 21:07 ` Grant Likely
2014-03-05 11:48 ` [PATCH v6 4/6] pci: Introduce a domain number for pci_host_bridge Liviu Dudau
2014-03-05 11:48 ` Liviu Dudau
2014-03-07 21:09 ` Grant Likely
2014-03-07 21:09 ` Grant Likely
2014-03-05 11:48 ` [PATCH v6 5/6] pci: Export find_pci_host_bridge() function Liviu Dudau
2014-03-05 11:48 ` Liviu Dudau
2014-03-05 11:48 ` [PATCH v6 6/6] pci: Add support for creating a generic host_bridge from device tree Liviu Dudau
2014-03-05 11:48 ` Liviu Dudau
2014-03-07 21:14 ` Grant Likely
2014-03-07 21:14 ` Grant Likely
2014-03-08 10:29 ` Liviu Dudau
2014-03-08 10:29 ` Liviu Dudau
2014-03-08 10:29 ` Liviu Dudau
2014-03-08 17:15 ` Arnd Bergmann
2014-03-08 17:15 ` Arnd Bergmann
2014-03-10 14:44 ` Liviu Dudau
2014-03-10 14:44 ` Liviu Dudau
2014-03-10 15:21 ` Arnd Bergmann
2014-03-10 15:21 ` Arnd Bergmann
2014-03-10 16:33 ` Liviu Dudau
2014-03-10 16:33 ` Liviu Dudau
2014-03-10 18:59 ` Arnd Bergmann
2014-03-10 18:59 ` Arnd Bergmann
2014-03-10 19:16 ` Geert Uytterhoeven
2014-03-10 19:16 ` Geert Uytterhoeven
2014-03-10 19:28 ` Arnd Bergmann
2014-03-10 19:28 ` Arnd Bergmann
2014-03-10 19:28 ` Arnd Bergmann
2014-03-10 21:56 ` Liviu Dudau
2014-03-10 21:56 ` Liviu Dudau
2014-03-10 21:56 ` Liviu Dudau
2014-03-11 6:50 ` Arnd Bergmann
2014-03-11 6:50 ` Arnd Bergmann
2014-03-11 6:50 ` Arnd Bergmann
2014-03-11 9:46 ` Liviu Dudau
2014-03-11 9:46 ` Liviu Dudau
2014-03-11 10:43 ` Arnd Bergmann
2014-03-11 10:43 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201403081817.39810.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=Catalin.Marinas@arm.com \
--cc=Liviu.Dudau@arm.com \
--cc=Will.Deacon@arm.com \
--cc=benh@kernel.crashing.org \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=tinamdar@apm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.