* [PATCH] fix bug in c/s 20332 Add commands to hotplug usb devices to hvm guests
@ 2009-12-14 2:53 James (song wei)
2009-12-14 8:00 ` Pasi Kärkkäinen
0 siblings, 1 reply; 4+ messages in thread
From: James (song wei) @ 2009-12-14 2:53 UTC (permalink / raw)
To: xen-devel
Signed-off-by: James Song Wei <jsong@novell.com>
diff -r b928797213ac tools/python/xen/xend/server/SrvDomain.py
--- a/tools/python/xen/xend/server/SrvDomain.py Fri Dec 11 09:17:09 2009
+0000
+++ b/tools/python/xen/xend/server/SrvDomain.py Mon Dec 14 10:41:48 2009
+0800
@@ -234,7 +234,7 @@
def op_usb_del(self, op, req):
self.acceptCommand(req)
- return req.threadRequest(self.do_usb_add, op, req)
+ return req.threadRequest(self.do_usb_del, op, req)
def do_usb_del(self, _, req):
return self.xd.domain_usb_add(self.dom.getName(), req)
--
View this message in context: http://old.nabble.com/-PATCH--fix-bug-in-c-s-20332-Add-commands-to-hotplug-usb-devices-to-hvm-guests-tp26772352p26772352.html
Sent from the Xen - Dev mailing list archive at Nabble.com.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] fix bug in c/s 20332 Add commands to hotplug usb devices to hvm guests 2009-12-14 2:53 [PATCH] fix bug in c/s 20332 Add commands to hotplug usb devices to hvm guests James (song wei) @ 2009-12-14 8:00 ` Pasi Kärkkäinen 2009-12-14 8:22 ` James (song wei) 0 siblings, 1 reply; 4+ messages in thread From: Pasi Kärkkäinen @ 2009-12-14 8:00 UTC (permalink / raw) To: James (song wei); +Cc: xen-devel On Sun, Dec 13, 2009 at 06:53:46PM -0800, James (song wei) wrote: > > Signed-off-by: James Song Wei <jsong@novell.com> > diff -r b928797213ac tools/python/xen/xend/server/SrvDomain.py > --- a/tools/python/xen/xend/server/SrvDomain.py Fri Dec 11 09:17:09 2009 > +0000 > +++ b/tools/python/xen/xend/server/SrvDomain.py Mon Dec 14 10:41:48 2009 > +0800 > @@ -234,7 +234,7 @@ > > def op_usb_del(self, op, req): > self.acceptCommand(req) > - return req.threadRequest(self.do_usb_add, op, req) > + return req.threadRequest(self.do_usb_del, op, req) > > def do_usb_del(self, _, req): > return self.xd.domain_usb_add(self.dom.getName(), req) ^^^ do_usb_del() is still using domain_usb_add() .. -- Pasi ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] fix bug in c/s 20332 Add commands to hotplug usb devices to hvm guests 2009-12-14 8:00 ` Pasi Kärkkäinen @ 2009-12-14 8:22 ` James (song wei) 2009-12-14 9:12 ` Pasi Kärkkäinen 0 siblings, 1 reply; 4+ messages in thread From: James (song wei) @ 2009-12-14 8:22 UTC (permalink / raw) To: xen-devel Sorry, thanks Pasi! -James Signed-off-by: James Song Wei <jsong@novell.com> diff -r b928797213ac tools/python/xen/xend/server/SrvDomain.py --- a/tools/python/xen/xend/server/SrvDomain.py Fri Dec 11 09:17:09 2009 +0000 +++ b/tools/python/xen/xend/server/SrvDomain.py Mon Dec 14 16:18:27 2009 +0800 @@ -234,10 +234,10 @@ def op_usb_del(self, op, req): self.acceptCommand(req) - return req.threadRequest(self.do_usb_add, op, req) + return req.threadRequest(self.do_usb_del, op, req) def do_usb_del(self, _, req): - return self.xd.domain_usb_add(self.dom.getName(), req) + return self.xd.domain_usb_del(self.dom.getName(), req) def render_POST(self, req): return self.perform(req) Pasi Kärkkäinen wrote: > > On Sun, Dec 13, 2009 at 06:53:46PM -0800, James (song wei) wrote: >> >> Signed-off-by: James Song Wei <jsong@novell.com> >> diff -r b928797213ac tools/python/xen/xend/server/SrvDomain.py >> --- a/tools/python/xen/xend/server/SrvDomain.py Fri Dec 11 09:17:09 2009 >> +0000 >> +++ b/tools/python/xen/xend/server/SrvDomain.py Mon Dec 14 10:41:48 2009 >> +0800 >> @@ -234,7 +234,7 @@ >> >> def op_usb_del(self, op, req): >> self.acceptCommand(req) >> - return req.threadRequest(self.do_usb_add, op, req) >> + return req.threadRequest(self.do_usb_del, op, req) >> >> def do_usb_del(self, _, req): >> return self.xd.domain_usb_add(self.dom.getName(), req) > ^^^ > > do_usb_del() is still using domain_usb_add() .. > > -- Pasi > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel > > -- View this message in context: http://old.nabble.com/-PATCH--fix-bug-in-c-s-20332-Add-commands-to-hotplug-usb-devices-to-hvm-guests-tp26772352p26774299.html Sent from the Xen - Dev mailing list archive at Nabble.com. ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] fix bug in c/s 20332 Add commands to hotplug usb devices to hvm guests 2009-12-14 8:22 ` James (song wei) @ 2009-12-14 9:12 ` Pasi Kärkkäinen 0 siblings, 0 replies; 4+ messages in thread From: Pasi Kärkkäinen @ 2009-12-14 9:12 UTC (permalink / raw) To: James (song wei); +Cc: xen-devel, Keir Fraser On Mon, Dec 14, 2009 at 12:22:37AM -0800, James (song wei) wrote: > > Sorry, thanks Pasi! > -James > Keir: This patch needs to go to xen-3.4-testing.hg aswell. -- Pasi > Signed-off-by: James Song Wei <jsong@novell.com> > diff -r b928797213ac tools/python/xen/xend/server/SrvDomain.py > --- a/tools/python/xen/xend/server/SrvDomain.py Fri Dec 11 09:17:09 2009 > +0000 > +++ b/tools/python/xen/xend/server/SrvDomain.py Mon Dec 14 16:18:27 2009 > +0800 > @@ -234,10 +234,10 @@ > > def op_usb_del(self, op, req): > self.acceptCommand(req) > - return req.threadRequest(self.do_usb_add, op, req) > + return req.threadRequest(self.do_usb_del, op, req) > > def do_usb_del(self, _, req): > - return self.xd.domain_usb_add(self.dom.getName(), req) > + return self.xd.domain_usb_del(self.dom.getName(), req) > > def render_POST(self, req): > return self.perform(req) > > > Pasi Kärkkäinen wrote: > > > > On Sun, Dec 13, 2009 at 06:53:46PM -0800, James (song wei) wrote: > >> > >> Signed-off-by: James Song Wei <jsong@novell.com> > >> diff -r b928797213ac tools/python/xen/xend/server/SrvDomain.py > >> --- a/tools/python/xen/xend/server/SrvDomain.py Fri Dec 11 09:17:09 2009 > >> +0000 > >> +++ b/tools/python/xen/xend/server/SrvDomain.py Mon Dec 14 10:41:48 2009 > >> +0800 > >> @@ -234,7 +234,7 @@ > >> > >> def op_usb_del(self, op, req): > >> self.acceptCommand(req) > >> - return req.threadRequest(self.do_usb_add, op, req) > >> + return req.threadRequest(self.do_usb_del, op, req) > >> > >> def do_usb_del(self, _, req): > >> return self.xd.domain_usb_add(self.dom.getName(), req) > > ^^^ > > > > do_usb_del() is still using domain_usb_add() .. > > > > -- Pasi > > > > > > _______________________________________________ > > Xen-devel mailing list > > Xen-devel@lists.xensource.com > > http://lists.xensource.com/xen-devel > > > > > > -- > View this message in context: http://old.nabble.com/-PATCH--fix-bug-in-c-s-20332-Add-commands-to-hotplug-usb-devices-to-hvm-guests-tp26772352p26774299.html > Sent from the Xen - Dev mailing list archive at Nabble.com. > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2009-12-14 9:12 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2009-12-14 2:53 [PATCH] fix bug in c/s 20332 Add commands to hotplug usb devices to hvm guests James (song wei) 2009-12-14 8:00 ` Pasi Kärkkäinen 2009-12-14 8:22 ` James (song wei) 2009-12-14 9:12 ` Pasi Kärkkäinen
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.