From: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
To: Mark Salter <msalter-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
Ard Biesheuvel
<ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
mark.rutland-5wv7dgnIgG8@public.gmane.org,
linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
matt.fleming-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
leif.lindholm-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org
Subject: Re: [PATCH 1/3] arm64: spin-table: handle unmapped cpu-release-addrs
Date: Tue, 29 Jul 2014 17:38:22 +0200 [thread overview]
Message-ID: <2687834.6RWMF06uIT@wuerfel> (raw)
In-Reply-To: <1406647824.753.12.camel-PDpCo7skNiwAicBL8TP8PQ@public.gmane.org>
On Tuesday 29 July 2014 11:30:24 Mark Salter wrote:
> On Tue, 2014-07-29 at 17:20 +0200, Arnd Bergmann wrote:
> > On Tuesday 29 July 2014 11:15:45 Mark Salter wrote:
> > > > -
> > > > - __flush_dcache_area(release_addr, sizeof(release_addr[0]));
> > > > + writeq_relaxed(__pa(secondary_holding_pen), release_addr);
> > > > + __flush_dcache_area(release_addr, sizeof(*release_addr));
> > >
> > > __flush_dcache_area((__force void *)release_addr, ...
> > >
> > > to avoid sparse warning.
> > >
> >
> > I think it would be cleaner to drop the __iomem annotation and use vmap()
> > rather than ioremap(). That requires having a 'struct page' though, which
> > I'm not sure you have.
> >
>
> You won't. If you did have a struct page, then __va() would work.
Ah, right. I was thinking of highmem, which has a struct page but no virtual
address. However, on arm64 there is obviously no highmem.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] arm64: spin-table: handle unmapped cpu-release-addrs
Date: Tue, 29 Jul 2014 17:38:22 +0200 [thread overview]
Message-ID: <2687834.6RWMF06uIT@wuerfel> (raw)
In-Reply-To: <1406647824.753.12.camel@deneb.redhat.com>
On Tuesday 29 July 2014 11:30:24 Mark Salter wrote:
> On Tue, 2014-07-29 at 17:20 +0200, Arnd Bergmann wrote:
> > On Tuesday 29 July 2014 11:15:45 Mark Salter wrote:
> > > > -
> > > > - __flush_dcache_area(release_addr, sizeof(release_addr[0]));
> > > > + writeq_relaxed(__pa(secondary_holding_pen), release_addr);
> > > > + __flush_dcache_area(release_addr, sizeof(*release_addr));
> > >
> > > __flush_dcache_area((__force void *)release_addr, ...
> > >
> > > to avoid sparse warning.
> > >
> >
> > I think it would be cleaner to drop the __iomem annotation and use vmap()
> > rather than ioremap(). That requires having a 'struct page' though, which
> > I'm not sure you have.
> >
>
> You won't. If you did have a struct page, then __va() would work.
Ah, right. I was thinking of highmem, which has a struct page but no virtual
address. However, on arm64 there is obviously no highmem.
Arnd
next prev parent reply other threads:[~2014-07-29 15:38 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-29 10:49 [PATCH 0/3] arm64/efi: improve TEXT_OFFSET handling Ard Biesheuvel
2014-07-29 10:49 ` Ard Biesheuvel
[not found] ` <1406630950-32432-1-git-send-email-ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2014-07-29 10:49 ` [PATCH 1/3] arm64: spin-table: handle unmapped cpu-release-addrs Ard Biesheuvel
2014-07-29 10:49 ` Ard Biesheuvel
[not found] ` <1406630950-32432-2-git-send-email-ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2014-07-29 15:15 ` Mark Salter
2014-07-29 15:15 ` Mark Salter
[not found] ` <1406646945.753.5.camel-PDpCo7skNiwAicBL8TP8PQ@public.gmane.org>
2014-07-29 15:17 ` Mark Salter
2014-07-29 15:17 ` Mark Salter
2014-07-29 15:20 ` Arnd Bergmann
2014-07-29 15:20 ` Arnd Bergmann
2014-07-29 15:30 ` Mark Salter
2014-07-29 15:30 ` Mark Salter
[not found] ` <1406647824.753.12.camel-PDpCo7skNiwAicBL8TP8PQ@public.gmane.org>
2014-07-29 15:38 ` Arnd Bergmann [this message]
2014-07-29 15:38 ` Arnd Bergmann
2014-07-29 16:03 ` Mark Rutland
2014-07-29 16:03 ` Mark Rutland
2014-07-29 16:13 ` Arnd Bergmann
2014-07-29 16:13 ` Arnd Bergmann
2014-07-29 16:18 ` Mark Rutland
2014-07-29 16:18 ` Mark Rutland
2014-07-29 16:24 ` Arnd Bergmann
2014-07-29 16:24 ` Arnd Bergmann
2014-07-29 10:49 ` [PATCH 2/3] arm64/efi: efistub: cover entire static mem footprint in PE/COFF .text Ard Biesheuvel
2014-07-29 10:49 ` Ard Biesheuvel
[not found] ` <1406630950-32432-3-git-send-email-ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2014-07-29 15:36 ` Mark Salter
2014-07-29 15:36 ` Mark Salter
2014-07-29 10:49 ` [PATCH 3/3] arm64/efi: efistub: don't abort if base of DRAM is occupied Ard Biesheuvel
2014-07-29 10:49 ` Ard Biesheuvel
[not found] ` <1406630950-32432-4-git-send-email-ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2014-07-29 15:29 ` Mark Salter
2014-07-29 15:29 ` Mark Salter
[not found] ` <1406647756.753.11.camel-PDpCo7skNiwAicBL8TP8PQ@public.gmane.org>
2014-07-29 18:17 ` Ard Biesheuvel
2014-07-29 18:17 ` Ard Biesheuvel
[not found] ` <CAKv+Gu8Pwi6GuGq9jbGfHyALcJKtAG+KVDcVwpYVCG9ZKrhaPA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-07-29 18:27 ` Mark Salter
2014-07-29 18:27 ` Mark Salter
[not found] ` <1406658428.753.22.camel-PDpCo7skNiwAicBL8TP8PQ@public.gmane.org>
2014-07-29 18:46 ` Ard Biesheuvel
2014-07-29 18:46 ` Ard Biesheuvel
[not found] ` <CAKv+Gu-3J+1u1vcCAOgfq6JRfSc7_pykaV2OwGRNSOORTS1=1A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-07-29 19:20 ` Mark Salter
2014-07-29 19:20 ` Mark Salter
[not found] ` <1406661621.753.34.camel-PDpCo7skNiwAicBL8TP8PQ@public.gmane.org>
2014-07-29 19:33 ` Ard Biesheuvel
2014-07-29 19:33 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2687834.6RWMF06uIT@wuerfel \
--to=arnd-r2ngtmty4d4@public.gmane.org \
--cc=ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=leif.lindholm-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=matt.fleming-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=msalter-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.