All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Heiko Stübner" <heiko@sntech.de>
To: Michael Turquette <mturquette@baylibre.com>
Cc: Jisheng Zhang <jszhang@marvell.com>,
	Stephen Boyd <sboyd@codeaurora.org>,
	linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
	pi-cheng.chen@linaro.org
Subject: Re: [Query]set clk rate must operate its coordinated clock
Date: Mon, 06 Jun 2016 10:10:37 +0200	[thread overview]
Message-ID: <2738343.ekabfXD0fs@diego> (raw)
In-Reply-To: <20160311165152.4103.82090@quark.deferred.io>

Hi Mike,

Am Freitag, 11. M=E4rz 2016, 08:51:52 schrieb Michael Turquette:
> Quoting Jisheng Zhang (2016-03-08 23:24:20)
> > I have the following clk case which I dunno the elegant solution:
> >=20
> >=20
> > cpuclk have two parents: cpupll and refclk. When set the cpuclk fre=
q, we
> > have to set its parent's freq, I.E cpupll freq. But before changing=
 the
> > cpupll's freq, we should set its refclk as its parent firstly.
> >=20
> > AFAIK, this is a common case, I have seen such requirement in rockc=
hip,
> > samsung clk driver. They solve this by notifier, but as pointed out=
 by
> > Michael in
> > http://lists.infradead.org/pipermail/linux-arm-kernel/2015-June/351=
565.ht
> > ml
> >=20
> > "This is also a hack and it points towards some missing infrastruct=
ure in
> > the clock framework."
> >=20
> > I also don't like the notifier solution, I believe the elegant solu=
tion
> > could be using the coordinated clock infrastructure. So what's the =
status
> > of this infrastructure? I can test, and I can even add some code to=
 make
> > it be ready to be merged if you guide me ;)
>=20
> Thanks for the email. I hope to finish that feature before ELC. I hav=
e
> Cc'd Pi-Cheng Chen from Mediatek who is also interested in coordinate=
d
> clock rates.

pulling this up again, did this materialize yet? :-)

Because it looks like on Rockchip we're getting yet another clock that =
needs=20
special handling (set_rate needs to go through the trusted-firmware, wh=
ile=20
reading stays the same) which might profit from that as well.


Heiko

WARNING: multiple messages have this Message-ID (diff)
From: heiko@sntech.de (Heiko Stübner)
To: linux-arm-kernel@lists.infradead.org
Subject: [Query]set clk rate must operate its coordinated clock
Date: Mon, 06 Jun 2016 10:10:37 +0200	[thread overview]
Message-ID: <2738343.ekabfXD0fs@diego> (raw)
In-Reply-To: <20160311165152.4103.82090@quark.deferred.io>

Hi Mike,

Am Freitag, 11. M?rz 2016, 08:51:52 schrieb Michael Turquette:
> Quoting Jisheng Zhang (2016-03-08 23:24:20)
> > I have the following clk case which I dunno the elegant solution:
> > 
> > 
> > cpuclk have two parents: cpupll and refclk. When set the cpuclk freq, we
> > have to set its parent's freq, I.E cpupll freq. But before changing the
> > cpupll's freq, we should set its refclk as its parent firstly.
> > 
> > AFAIK, this is a common case, I have seen such requirement in rockchip,
> > samsung clk driver. They solve this by notifier, but as pointed out by
> > Michael in
> > http://lists.infradead.org/pipermail/linux-arm-kernel/2015-June/351565.ht
> > ml
> > 
> > "This is also a hack and it points towards some missing infrastructure in
> > the clock framework."
> > 
> > I also don't like the notifier solution, I believe the elegant solution
> > could be using the coordinated clock infrastructure. So what's the status
> > of this infrastructure? I can test, and I can even add some code to make
> > it be ready to be merged if you guide me ;)
> 
> Thanks for the email. I hope to finish that feature before ELC. I have
> Cc'd Pi-Cheng Chen from Mediatek who is also interested in coordinated
> clock rates.

pulling this up again, did this materialize yet? :-)

Because it looks like on Rockchip we're getting yet another clock that needs 
special handling (set_rate needs to go through the trusted-firmware, while 
reading stays the same) which might profit from that as well.


Heiko

  parent reply	other threads:[~2016-06-06  8:10 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-09  7:24 [Query]set clk rate must operate its coordinated clock Jisheng Zhang
2016-03-09  7:24 ` Jisheng Zhang
2016-03-09  7:30 ` Jisheng Zhang
2016-03-09  7:30   ` Jisheng Zhang
2016-03-11 16:51 ` Michael Turquette
2016-03-11 16:51   ` Michael Turquette
2016-03-14  8:09   ` Jisheng Zhang
2016-03-14  8:09     ` Jisheng Zhang
2016-03-31  2:34   ` Pi-Cheng Chen
2016-03-31  2:34     ` Pi-Cheng Chen
2016-06-06  8:10   ` Heiko Stübner [this message]
2016-06-06  8:10     ` Heiko Stübner
2016-06-13 15:59     ` Georgi Djakov
2016-06-13 15:59       ` Georgi Djakov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2738343.ekabfXD0fs@diego \
    --to=heiko@sntech.de \
    --cc=jszhang@marvell.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=pi-cheng.chen@linaro.org \
    --cc=sboyd@codeaurora.org \
    --cc=sebastian.hesselbarth@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.