All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Cc: David Airlie <airlied@linux.ie>, Rob Herring <robh+dt@kernel.org>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Mark Rutland <mark.rutland@arm.com>,
	Biju Das <biju.das@bp.renesas.com>,
	Simon Horman <horms@verge.net.au>,
	Magnus Damm <magnus.damm@gmail.com>,
	Russell King <linux@armlinux.org.uk>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	"linux-renesas-soc@vger.kernel.org"
	<linux-renesas-soc@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	Chris Paterson <Chris.Paterson2@renesas.com>
Subject: Re: [PATCH 4/5] drm: rcar-du: Add R8A7744 support
Date: Fri, 23 Nov 2018 14:05:23 +0200	[thread overview]
Message-ID: <2739044.1unFEStFin@avalon> (raw)
In-Reply-To: <TY1PR01MB17707049DE6A8FD71E032157C0DB0@TY1PR01MB1770.jpnprd01.prod.outlook.com>

Hi Fabrizio,

On Thursday, 22 November 2018 17:59:32 EET Fabrizio Castro wrote:
> On 15 October 2018 23:25 Laurent Pinchart wrote:
> > On Friday, 21 September 2018 21:08:30 EEST Fabrizio Castro wrote:
> >> From: Biju Das <biju.das@bp.renesas.com>
> >> 
> >> Add support for the R8A7744 DU (which is very similar to the R8A7743
> >> DU);
> >> it has 1 DPAD (RGB) output and 1 LVDS output.
> >> 
> >> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> >> Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> >> ---
> >> 
> >>  drivers/gpu/drm/rcar-du/rcar_du_drv.c | 1 +
> >>  1 file changed, 1 insertion(+)
> >> 
> >> diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> >> b/drivers/gpu/drm/rcar-du/rcar_du_drv.c index c07d3f1..2c3d0e5 100644
> >> --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> >> +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> >> @@ -321,6 +321,7 @@ static const struct rcar_du_device_info
> >> rcar_du_r8a77970_info = {
> >>  static const struct of_device_id rcar_du_of_table[] = {
> >>  { .compatible = "renesas,du-r8a7743", .data = &rzg1_du_r8a7743_info },
> >> +{ .compatible = "renesas,du-r8a7744", .data = &rzg1_du_r8a7743_info },
> >>  { .compatible = "renesas,du-r8a7745", .data = &rzg1_du_r8a7745_info },
> >>  { .compatible = "renesas,du-r8a77470", .data = &rzg1_du_r8a77470_info
> >>  },
> >>  { .compatible = "renesas,du-r8a7779", .data = &rcar_du_r8a7779_info },
> > 
> > This looks good to me. I would also apply this change:
> > 
> > @@ -41,7 +41,7 @@ static const struct rcar_du_device_info
> > rzg1_du_r8a7743_info = {
> >         .channels_mask = BIT(1) | BIT(0),
> >         .routes = {
> >                 /*
> > -                * R8A7743 has one RGB output and one LVDS output
> > +                * R8A774[34] has one RGB output and one LVDS output
> >                  */
> >                 [RCAR_DU_OUTPUT_DPAD0] = {
> >                         .possible_crtcs = BIT(1) | BIT(0),
> > 
> > With this,
> > 
> > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > 
> > There's no need to resubmit, I've applied the patch to my tree with the
> > above change.
> 
> I was expecting to see this patch at least on linux-next by now but it looks
> like it's not in there, could you please double check what happened to it?

I've sent the R-Car DU v4.21 pull request today, it should end up in linux-
next in the near future.

-- 
Regards,

Laurent Pinchart

WARNING: multiple messages have this Message-ID (diff)
From: laurent.pinchart@ideasonboard.com (Laurent Pinchart)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/5] drm: rcar-du: Add R8A7744 support
Date: Fri, 23 Nov 2018 14:05:23 +0200	[thread overview]
Message-ID: <2739044.1unFEStFin@avalon> (raw)
In-Reply-To: <TY1PR01MB17707049DE6A8FD71E032157C0DB0@TY1PR01MB1770.jpnprd01.prod.outlook.com>

Hi Fabrizio,

On Thursday, 22 November 2018 17:59:32 EET Fabrizio Castro wrote:
> On 15 October 2018 23:25 Laurent Pinchart wrote:
> > On Friday, 21 September 2018 21:08:30 EEST Fabrizio Castro wrote:
> >> From: Biju Das <biju.das@bp.renesas.com>
> >> 
> >> Add support for the R8A7744 DU (which is very similar to the R8A7743
> >> DU);
> >> it has 1 DPAD (RGB) output and 1 LVDS output.
> >> 
> >> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> >> Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> >> ---
> >> 
> >>  drivers/gpu/drm/rcar-du/rcar_du_drv.c | 1 +
> >>  1 file changed, 1 insertion(+)
> >> 
> >> diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> >> b/drivers/gpu/drm/rcar-du/rcar_du_drv.c index c07d3f1..2c3d0e5 100644
> >> --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> >> +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> >> @@ -321,6 +321,7 @@ static const struct rcar_du_device_info
> >> rcar_du_r8a77970_info = {
> >>  static const struct of_device_id rcar_du_of_table[] = {
> >>  { .compatible = "renesas,du-r8a7743", .data = &rzg1_du_r8a7743_info },
> >> +{ .compatible = "renesas,du-r8a7744", .data = &rzg1_du_r8a7743_info },
> >>  { .compatible = "renesas,du-r8a7745", .data = &rzg1_du_r8a7745_info },
> >>  { .compatible = "renesas,du-r8a77470", .data = &rzg1_du_r8a77470_info
> >>  },
> >>  { .compatible = "renesas,du-r8a7779", .data = &rcar_du_r8a7779_info },
> > 
> > This looks good to me. I would also apply this change:
> > 
> > @@ -41,7 +41,7 @@ static const struct rcar_du_device_info
> > rzg1_du_r8a7743_info = {
> >         .channels_mask = BIT(1) | BIT(0),
> >         .routes = {
> >                 /*
> > -                * R8A7743 has one RGB output and one LVDS output
> > +                * R8A774[34] has one RGB output and one LVDS output
> >                  */
> >                 [RCAR_DU_OUTPUT_DPAD0] = {
> >                         .possible_crtcs = BIT(1) | BIT(0),
> > 
> > With this,
> > 
> > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > 
> > There's no need to resubmit, I've applied the patch to my tree with the
> > above change.
> 
> I was expecting to see this patch at least on linux-next by now but it looks
> like it's not in there, could you please double check what happened to it?

I've sent the R-Car DU v4.21 pull request today, it should end up in linux-
next in the near future.

-- 
Regards,

Laurent Pinchart

WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	Chris Paterson <Chris.Paterson2@renesas.com>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Simon Horman <horms@verge.net.au>,
	David Airlie <airlied@linux.ie>,
	Magnus Damm <magnus.damm@gmail.com>,
	Russell King <linux@armlinux.org.uk>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	Biju Das <biju.das@bp.renesas.com>,
	"linux-renesas-soc@vger.kernel.org"
	<linux-renesas-soc@vger.kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 4/5] drm: rcar-du: Add R8A7744 support
Date: Fri, 23 Nov 2018 14:05:23 +0200	[thread overview]
Message-ID: <2739044.1unFEStFin@avalon> (raw)
In-Reply-To: <TY1PR01MB17707049DE6A8FD71E032157C0DB0@TY1PR01MB1770.jpnprd01.prod.outlook.com>

Hi Fabrizio,

On Thursday, 22 November 2018 17:59:32 EET Fabrizio Castro wrote:
> On 15 October 2018 23:25 Laurent Pinchart wrote:
> > On Friday, 21 September 2018 21:08:30 EEST Fabrizio Castro wrote:
> >> From: Biju Das <biju.das@bp.renesas.com>
> >> 
> >> Add support for the R8A7744 DU (which is very similar to the R8A7743
> >> DU);
> >> it has 1 DPAD (RGB) output and 1 LVDS output.
> >> 
> >> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> >> Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> >> ---
> >> 
> >>  drivers/gpu/drm/rcar-du/rcar_du_drv.c | 1 +
> >>  1 file changed, 1 insertion(+)
> >> 
> >> diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> >> b/drivers/gpu/drm/rcar-du/rcar_du_drv.c index c07d3f1..2c3d0e5 100644
> >> --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> >> +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> >> @@ -321,6 +321,7 @@ static const struct rcar_du_device_info
> >> rcar_du_r8a77970_info = {
> >>  static const struct of_device_id rcar_du_of_table[] = {
> >>  { .compatible = "renesas,du-r8a7743", .data = &rzg1_du_r8a7743_info },
> >> +{ .compatible = "renesas,du-r8a7744", .data = &rzg1_du_r8a7743_info },
> >>  { .compatible = "renesas,du-r8a7745", .data = &rzg1_du_r8a7745_info },
> >>  { .compatible = "renesas,du-r8a77470", .data = &rzg1_du_r8a77470_info
> >>  },
> >>  { .compatible = "renesas,du-r8a7779", .data = &rcar_du_r8a7779_info },
> > 
> > This looks good to me. I would also apply this change:
> > 
> > @@ -41,7 +41,7 @@ static const struct rcar_du_device_info
> > rzg1_du_r8a7743_info = {
> >         .channels_mask = BIT(1) | BIT(0),
> >         .routes = {
> >                 /*
> > -                * R8A7743 has one RGB output and one LVDS output
> > +                * R8A774[34] has one RGB output and one LVDS output
> >                  */
> >                 [RCAR_DU_OUTPUT_DPAD0] = {
> >                         .possible_crtcs = BIT(1) | BIT(0),
> > 
> > With this,
> > 
> > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > 
> > There's no need to resubmit, I've applied the patch to my tree with the
> > above change.
> 
> I was expecting to see this patch at least on linux-next by now but it looks
> like it's not in there, could you please double check what happened to it?

I've sent the R-Car DU v4.21 pull request today, it should end up in linux-
next in the near future.

-- 
Regards,

Laurent Pinchart



_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2018-11-23 12:05 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-21 18:08 [PATCH 0/5] Add Du support to RZ/G1C and RZ/G1N Fabrizio Castro
2018-09-21 18:08 ` Fabrizio Castro
2018-09-21 18:08 ` Fabrizio Castro
2018-09-21 18:08 ` [PATCH 1/5] dt-bindings: display: renesas: du: Document the r8a77470 bindings Fabrizio Castro
2018-09-21 18:08   ` Fabrizio Castro
2018-09-21 18:08   ` Fabrizio Castro
2018-10-15 15:16   ` Rob Herring
2018-10-15 15:16     ` Rob Herring
2018-10-15 15:16     ` Rob Herring
2018-10-15 22:16   ` Laurent Pinchart
2018-10-15 22:16     ` Laurent Pinchart
2018-10-15 22:16     ` Laurent Pinchart
2018-09-21 18:08 ` [PATCH 2/5] dt-bindings: display: renesas: du: Document the r8a7744 bindings Fabrizio Castro
2018-09-21 18:08   ` Fabrizio Castro
2018-09-21 18:08   ` Fabrizio Castro
2018-10-15 15:17   ` Rob Herring
2018-10-15 15:17     ` Rob Herring
2018-10-15 15:17     ` Rob Herring
2018-10-15 22:18   ` Laurent Pinchart
2018-10-15 22:18     ` Laurent Pinchart
2018-10-15 22:18     ` Laurent Pinchart
2018-09-21 18:08 ` [PATCH 3/5] drm: rcar-du: Add r8a77470 support Fabrizio Castro
2018-09-21 18:08   ` Fabrizio Castro
2018-09-21 18:08   ` Fabrizio Castro
2018-10-15 22:22   ` Laurent Pinchart
2018-10-15 22:22     ` Laurent Pinchart
2018-10-15 22:22     ` Laurent Pinchart
2018-10-16 15:19     ` Fabrizio Castro
2018-10-16 15:19       ` Fabrizio Castro
2018-10-16 15:19       ` Fabrizio Castro
2018-09-21 18:08 ` [PATCH 4/5] drm: rcar-du: Add R8A7744 support Fabrizio Castro
2018-09-21 18:08   ` Fabrizio Castro
2018-09-21 18:08   ` Fabrizio Castro
2018-10-15 22:25   ` Laurent Pinchart
2018-10-15 22:25     ` Laurent Pinchart
2018-10-15 22:25     ` Laurent Pinchart
2018-11-22 15:59     ` Fabrizio Castro
2018-11-22 15:59       ` Fabrizio Castro
2018-11-22 15:59       ` Fabrizio Castro
2018-11-23 12:05       ` Laurent Pinchart [this message]
2018-11-23 12:05         ` Laurent Pinchart
2018-11-23 12:05         ` Laurent Pinchart
2018-11-23 12:32         ` Fabrizio Castro
2018-11-23 12:32           ` Fabrizio Castro
2018-11-23 12:32           ` Fabrizio Castro
2018-09-21 18:08 ` [PATCH 5/5] ARM: shmobile: defconfig: Enable SII902X Fabrizio Castro
2018-09-21 18:08   ` Fabrizio Castro
2018-09-21 18:08   ` Fabrizio Castro
2018-09-24  9:08   ` Simon Horman
2018-09-24  9:08     ` Simon Horman
2018-09-24  9:08     ` Simon Horman
2018-10-18 13:10     ` Simon Horman
2018-10-18 13:10       ` Simon Horman
2018-10-18 13:10       ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2739044.1unFEStFin@avalon \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=Chris.Paterson2@renesas.com \
    --cc=airlied@linux.ie \
    --cc=biju.das@bp.renesas.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=fabrizio.castro@bp.renesas.com \
    --cc=geert+renesas@glider.be \
    --cc=horms@verge.net.au \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=magnus.damm@gmail.com \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.