* IMAGE_FEATURES check broken
@ 2013-05-14 10:45 Gary Thomas
2013-05-14 10:48 ` Paul Eggleton
2013-05-14 10:56 ` Martin Jansa
0 siblings, 2 replies; 5+ messages in thread
From: Gary Thomas @ 2013-05-14 10:45 UTC (permalink / raw)
To: Yocto Project
This commit breaks systems where IMAGE_FEATURES includes "package-management":
commit d63c8a1597c9bd0a838cb59ca461ac432b630a90
Author: Paul Eggleton <paul.eggleton@linux.intel.com>
Date: Thu May 9 17:24:25 2013 +0100
classes/image: show an error on invalid IMAGE_FEATURES
A quick look at that class shows that package-management is being left
out of the "validitems". This patch fixes it:
diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass
index 2b42e12..4f07708 100644
--- a/meta/classes/image.bbclass
+++ b/meta/classes/image.bbclass
@@ -19,7 +19,7 @@ INHIBIT_DEFAULT_DEPS = "1"
# IMAGE_FEATURES may contain any available package group
IMAGE_FEATURES ?= ""
IMAGE_FEATURES[type] = "list"
-IMAGE_FEATURES[validitems] += "debug-tweaks read-only-rootfs"
+IMAGE_FEATURES[validitems] += "debug-tweaks read-only-rootfs package-management"
# rootfs bootstrap install
ROOTFS_BOOTSTRAP_INSTALL = "${@base_contains("IMAGE_FEATURES", "package-management", "", "${ROOTFS_PKGMANAGE_BOOTSTR
Am I missing something else, or was this just overlooked?
--
------------------------------------------------------------
Gary Thomas | Consulting for the
MLB Associates | Embedded world
------------------------------------------------------------
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: IMAGE_FEATURES check broken
2013-05-14 10:45 IMAGE_FEATURES check broken Gary Thomas
@ 2013-05-14 10:48 ` Paul Eggleton
2013-05-14 12:55 ` Paul Eggleton
2013-05-14 10:56 ` Martin Jansa
1 sibling, 1 reply; 5+ messages in thread
From: Paul Eggleton @ 2013-05-14 10:48 UTC (permalink / raw)
To: Gary Thomas; +Cc: yocto
On Tuesday 14 May 2013 04:45:02 Gary Thomas wrote:
> This commit breaks systems where IMAGE_FEATURES includes
> "package-management":
>
> commit d63c8a1597c9bd0a838cb59ca461ac432b630a90
> Author: Paul Eggleton <paul.eggleton@linux.intel.com>
> Date: Thu May 9 17:24:25 2013 +0100
>
> classes/image: show an error on invalid IMAGE_FEATURES
>
> A quick look at that class shows that package-management is being left
> out of the "validitems". This patch fixes it:
>
> diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass
> index 2b42e12..4f07708 100644
> --- a/meta/classes/image.bbclass
> +++ b/meta/classes/image.bbclass
> @@ -19,7 +19,7 @@ INHIBIT_DEFAULT_DEPS = "1"
> # IMAGE_FEATURES may contain any available package group
> IMAGE_FEATURES ?= ""
> IMAGE_FEATURES[type] = "list"
> -IMAGE_FEATURES[validitems] += "debug-tweaks read-only-rootfs"
> +IMAGE_FEATURES[validitems] += "debug-tweaks read-only-rootfs
> package-management"
>
> # rootfs bootstrap install
> ROOTFS_BOOTSTRAP_INSTALL = "${@base_contains("IMAGE_FEATURES",
> "package-management", "", "${ROOTFS_PKGMANAGE_BOOTSTR
>
> Am I missing something else, or was this just overlooked?
It was overlooked, I'm afraid - images that inherit core-image don't have this
problem because the package-management PACKAGE_GROUP is defined and this gets
picked up. Images that don't (which is perfectly acceptable) get the failure,
and I missed testing this case.
There is a patch pending to fix this however:
http://patchwork.openembedded.org/patch/49795/
Cheers,
Paul
--
Paul Eggleton
Intel Open Source Technology Centre
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: IMAGE_FEATURES check broken
2013-05-14 10:45 IMAGE_FEATURES check broken Gary Thomas
2013-05-14 10:48 ` Paul Eggleton
@ 2013-05-14 10:56 ` Martin Jansa
2013-05-14 11:22 ` Gary Thomas
1 sibling, 1 reply; 5+ messages in thread
From: Martin Jansa @ 2013-05-14 10:56 UTC (permalink / raw)
To: Gary Thomas; +Cc: Yocto Project
[-- Attachment #1: Type: text/plain, Size: 1419 bytes --]
On Tue, May 14, 2013 at 04:45:02AM -0600, Gary Thomas wrote:
> This commit breaks systems where IMAGE_FEATURES includes "package-management":
>
> commit d63c8a1597c9bd0a838cb59ca461ac432b630a90
> Author: Paul Eggleton <paul.eggleton@linux.intel.com>
> Date: Thu May 9 17:24:25 2013 +0100
>
> classes/image: show an error on invalid IMAGE_FEATURES
>
> A quick look at that class shows that package-management is being left
> out of the "validitems". This patch fixes it:
>
> diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass
> index 2b42e12..4f07708 100644
> --- a/meta/classes/image.bbclass
> +++ b/meta/classes/image.bbclass
> @@ -19,7 +19,7 @@ INHIBIT_DEFAULT_DEPS = "1"
> # IMAGE_FEATURES may contain any available package group
> IMAGE_FEATURES ?= ""
> IMAGE_FEATURES[type] = "list"
> -IMAGE_FEATURES[validitems] += "debug-tweaks read-only-rootfs"
> +IMAGE_FEATURES[validitems] += "debug-tweaks read-only-rootfs package-management"
>
> # rootfs bootstrap install
> ROOTFS_BOOTSTRAP_INSTALL = "${@base_contains("IMAGE_FEATURES", "package-management", "", "${ROOTFS_PKGMANAGE_BOOTSTR
>
> Am I missing something else, or was this just overlooked?
The same patch is already on oe-core ML where it belongs:
http://lists.linuxtogo.org/pipermail/openembedded-core/2013-May/039541.html
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: IMAGE_FEATURES check broken
2013-05-14 10:56 ` Martin Jansa
@ 2013-05-14 11:22 ` Gary Thomas
0 siblings, 0 replies; 5+ messages in thread
From: Gary Thomas @ 2013-05-14 11:22 UTC (permalink / raw)
To: Martin Jansa; +Cc: Yocto Project
On 2013-05-14 04:56, Martin Jansa wrote:
> On Tue, May 14, 2013 at 04:45:02AM -0600, Gary Thomas wrote:
>> This commit breaks systems where IMAGE_FEATURES includes "package-management":
>>
>> commit d63c8a1597c9bd0a838cb59ca461ac432b630a90
>> Author: Paul Eggleton <paul.eggleton@linux.intel.com>
>> Date: Thu May 9 17:24:25 2013 +0100
>>
>> classes/image: show an error on invalid IMAGE_FEATURES
>>
>> A quick look at that class shows that package-management is being left
>> out of the "validitems". This patch fixes it:
>>
>> diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass
>> index 2b42e12..4f07708 100644
>> --- a/meta/classes/image.bbclass
>> +++ b/meta/classes/image.bbclass
>> @@ -19,7 +19,7 @@ INHIBIT_DEFAULT_DEPS = "1"
>> # IMAGE_FEATURES may contain any available package group
>> IMAGE_FEATURES ?= ""
>> IMAGE_FEATURES[type] = "list"
>> -IMAGE_FEATURES[validitems] += "debug-tweaks read-only-rootfs"
>> +IMAGE_FEATURES[validitems] += "debug-tweaks read-only-rootfs package-management"
>>
>> # rootfs bootstrap install
>> ROOTFS_BOOTSTRAP_INSTALL = "${@base_contains("IMAGE_FEATURES", "package-management", "", "${ROOTFS_PKGMANAGE_BOOTSTR
>>
>> Am I missing something else, or was this just overlooked?
>
> The same patch is already on oe-core ML where it belongs:
> http://lists.linuxtogo.org/pipermail/openembedded-core/2013-May/039541.html
Thanks (I missed that one because it happened late Sunday over here)
Note: I sent my email to this list because of the comment in the commit
which referred directly to a Yocto bug. ... I have a hard time figuring
out where Yocto ends and OE-core begins ...
--
------------------------------------------------------------
Gary Thomas | Consulting for the
MLB Associates | Embedded world
------------------------------------------------------------
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: IMAGE_FEATURES check broken
2013-05-14 10:48 ` Paul Eggleton
@ 2013-05-14 12:55 ` Paul Eggleton
0 siblings, 0 replies; 5+ messages in thread
From: Paul Eggleton @ 2013-05-14 12:55 UTC (permalink / raw)
To: Gary Thomas; +Cc: yocto
On Tuesday 14 May 2013 11:48:55 Paul Eggleton wrote:
> On Tuesday 14 May 2013 04:45:02 Gary Thomas wrote:
> > This commit breaks systems where IMAGE_FEATURES includes
> > "package-management":
> >
> > commit d63c8a1597c9bd0a838cb59ca461ac432b630a90
> > Author: Paul Eggleton <paul.eggleton@linux.intel.com>
> > Date: Thu May 9 17:24:25 2013 +0100
> >
> > classes/image: show an error on invalid IMAGE_FEATURES
> >
> > A quick look at that class shows that package-management is being left
> > out of the "validitems". This patch fixes it:
> >
> > diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass
> > index 2b42e12..4f07708 100644
> > --- a/meta/classes/image.bbclass
> > +++ b/meta/classes/image.bbclass
> > @@ -19,7 +19,7 @@ INHIBIT_DEFAULT_DEPS = "1"
> >
> > # IMAGE_FEATURES may contain any available package group
> > IMAGE_FEATURES ?= ""
> > IMAGE_FEATURES[type] = "list"
> >
> > -IMAGE_FEATURES[validitems] += "debug-tweaks read-only-rootfs"
> > +IMAGE_FEATURES[validitems] += "debug-tweaks read-only-rootfs
> > package-management"
> >
> > # rootfs bootstrap install
> > ROOTFS_BOOTSTRAP_INSTALL = "${@base_contains("IMAGE_FEATURES",
> >
> > "package-management", "", "${ROOTFS_PKGMANAGE_BOOTSTR
> >
> > Am I missing something else, or was this just overlooked?
>
> It was overlooked, I'm afraid - images that inherit core-image don't have
> this problem because the package-management PACKAGE_GROUP is defined and
> this gets picked up. Images that don't (which is perfectly acceptable) get
> the failure, and I missed testing this case.
>
> There is a patch pending to fix this however:
>
> http://patchwork.openembedded.org/patch/49795/
FYI, this patch has now been merged.
Cheers,
Paul
--
Paul Eggleton
Intel Open Source Technology Centre
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-05-14 12:55 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-14 10:45 IMAGE_FEATURES check broken Gary Thomas
2013-05-14 10:48 ` Paul Eggleton
2013-05-14 12:55 ` Paul Eggleton
2013-05-14 10:56 ` Martin Jansa
2013-05-14 11:22 ` Gary Thomas
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.