[PATCH] FRV - remove dead config symbol from FRV code

[PATCH] FRV - remove dead config symbol from FRV code

[Jiri Olsa]

remove dead config symbol from FRV code
Signed-off-by: Jiri Olsa <olsajiri@gmail.com>

---
 include/asm-frv/page.h |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/include/asm-frv/page.h b/include/asm-frv/page.h
index 213d92f..bd9bd2d 100644
--- a/include/asm-frv/page.h
+++ b/include/asm-frv/page.h
@@ -76,10 +76,6 @@ extern unsigned long max_pfn;
 
 #endif /* __ASSEMBLY__ */
 
-#ifdef CONFIG_CONTIGUOUS_PAGE_ALLOC
-#define WANT_PAGE_VIRTUAL	1
-#endif
-
 #include <asm-generic/memory_model.h>
 #include <asm-generic/page.h>
 

Re: [PATCH] FRV - remove dead config symbol from FRV code

[David Howells]

Jiri Olsa <olsajiri@gmail.com> wrote:

> remove dead config symbol from FRV code

Are you sure about that?

warthog>grep -r WANT_PAGE_VIRTUAL mm
mm/highmem.c:#endif     /* defined(CONFIG_HIGHMEM) && !defined(WANT_PAGE_VIRTUAL) */
mm/page_alloc.c:#ifdef WANT_PAGE_VIRTUAL

David

Re: [PATCH] FRV - remove dead config symbol from FRV code

[Jiri Olsa]

David Howells wrote:
> Jiri Olsa <olsajiri@gmail.com> wrote:
> 
>> remove dead config symbol from FRV code
> 
> Are you sure about that?
> 
> warthog>grep -r WANT_PAGE_VIRTUAL mm
> mm/highmem.c:#endif     /* defined(CONFIG_HIGHMEM) && !defined(WANT_PAGE_VIRTUAL) */
> mm/page_alloc.c:#ifdef WANT_PAGE_VIRTUAL
> 
> David
> 

the WANT_PAGE_VIRTUAL is defined only when CONFIG_CONTIGUOUS_PAGE_ALLOC is defined,
which wont happend, since it is not defined at all:

-#ifdef CONFIG_CONTIGUOUS_PAGE_ALLOC
-#define WANT_PAGE_VIRTUAL      1
-#endif
-


jirka

Re: [PATCH] FRV - remove dead config symbol from FRV code

[David Howells]

Jiri Olsa <olsajiri@gmail.com> wrote:

> the WANT_PAGE_VIRTUAL is defined only when CONFIG_CONTIGUOUS_PAGE_ALLOC is
> defined, which wont happend, since it is not defined at all:

Okay.  That makes sense.

David

Re: [PATCH] FRV - remove dead config symbol from FRV code

[David Howells]

Jiri Olsa <olsajiri@gmail.com> wrote:

> remove dead config symbol from FRV code
> Signed-off-by: Jiri Olsa <olsajiri@gmail.com>

Acked-by: David Howells <dhowells@redhat.com>