* [PATCH] FRV - remove dead config symbol from FRV code
@ 2007-11-08 15:08 Jiri Olsa
2007-11-08 17:21 ` David Howells
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Jiri Olsa @ 2007-11-08 15:08 UTC (permalink / raw)
To: kernel-janitors
remove dead config symbol from FRV code
Signed-off-by: Jiri Olsa <olsajiri@gmail.com>
---
include/asm-frv/page.h | 4 ----
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/include/asm-frv/page.h b/include/asm-frv/page.h
index 213d92f..bd9bd2d 100644
--- a/include/asm-frv/page.h
+++ b/include/asm-frv/page.h
@@ -76,10 +76,6 @@ extern unsigned long max_pfn;
#endif /* __ASSEMBLY__ */
-#ifdef CONFIG_CONTIGUOUS_PAGE_ALLOC
-#define WANT_PAGE_VIRTUAL 1
-#endif
-
#include <asm-generic/memory_model.h>
#include <asm-generic/page.h>
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] FRV - remove dead config symbol from FRV code
2007-11-08 15:08 [PATCH] FRV - remove dead config symbol from FRV code Jiri Olsa
@ 2007-11-08 17:21 ` David Howells
2007-11-08 17:33 ` Jiri Olsa
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: David Howells @ 2007-11-08 17:21 UTC (permalink / raw)
To: kernel-janitors
Jiri Olsa <olsajiri@gmail.com> wrote:
> remove dead config symbol from FRV code
Are you sure about that?
warthog>grep -r WANT_PAGE_VIRTUAL mm
mm/highmem.c:#endif /* defined(CONFIG_HIGHMEM) && !defined(WANT_PAGE_VIRTUAL) */
mm/page_alloc.c:#ifdef WANT_PAGE_VIRTUAL
David
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] FRV - remove dead config symbol from FRV code
2007-11-08 15:08 [PATCH] FRV - remove dead config symbol from FRV code Jiri Olsa
2007-11-08 17:21 ` David Howells
@ 2007-11-08 17:33 ` Jiri Olsa
2007-11-08 17:49 ` David Howells
2007-11-08 17:50 ` David Howells
3 siblings, 0 replies; 5+ messages in thread
From: Jiri Olsa @ 2007-11-08 17:33 UTC (permalink / raw)
To: kernel-janitors
David Howells wrote:
> Jiri Olsa <olsajiri@gmail.com> wrote:
>
>> remove dead config symbol from FRV code
>
> Are you sure about that?
>
> warthog>grep -r WANT_PAGE_VIRTUAL mm
> mm/highmem.c:#endif /* defined(CONFIG_HIGHMEM) && !defined(WANT_PAGE_VIRTUAL) */
> mm/page_alloc.c:#ifdef WANT_PAGE_VIRTUAL
>
> David
>
the WANT_PAGE_VIRTUAL is defined only when CONFIG_CONTIGUOUS_PAGE_ALLOC is defined,
which wont happend, since it is not defined at all:
-#ifdef CONFIG_CONTIGUOUS_PAGE_ALLOC
-#define WANT_PAGE_VIRTUAL 1
-#endif
-
jirka
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] FRV - remove dead config symbol from FRV code
2007-11-08 15:08 [PATCH] FRV - remove dead config symbol from FRV code Jiri Olsa
2007-11-08 17:21 ` David Howells
2007-11-08 17:33 ` Jiri Olsa
@ 2007-11-08 17:49 ` David Howells
2007-11-08 17:50 ` David Howells
3 siblings, 0 replies; 5+ messages in thread
From: David Howells @ 2007-11-08 17:49 UTC (permalink / raw)
To: kernel-janitors
Jiri Olsa <olsajiri@gmail.com> wrote:
> the WANT_PAGE_VIRTUAL is defined only when CONFIG_CONTIGUOUS_PAGE_ALLOC is
> defined, which wont happend, since it is not defined at all:
Okay. That makes sense.
David
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] FRV - remove dead config symbol from FRV code
2007-11-08 15:08 [PATCH] FRV - remove dead config symbol from FRV code Jiri Olsa
` (2 preceding siblings ...)
2007-11-08 17:49 ` David Howells
@ 2007-11-08 17:50 ` David Howells
3 siblings, 0 replies; 5+ messages in thread
From: David Howells @ 2007-11-08 17:50 UTC (permalink / raw)
To: kernel-janitors
Jiri Olsa <olsajiri@gmail.com> wrote:
> remove dead config symbol from FRV code
> Signed-off-by: Jiri Olsa <olsajiri@gmail.com>
Acked-by: David Howells <dhowells@redhat.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2007-11-08 17:50 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-11-08 15:08 [PATCH] FRV - remove dead config symbol from FRV code Jiri Olsa
2007-11-08 17:21 ` David Howells
2007-11-08 17:33 ` Jiri Olsa
2007-11-08 17:49 ` David Howells
2007-11-08 17:50 ` David Howells
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.