* [PATCH v2] drm/mediatek/dp: fix mtk_dp_aux_transfer return value
@ 2024-04-17 10:38 ` Wojciech Macek
0 siblings, 0 replies; 11+ messages in thread
From: Wojciech Macek @ 2024-04-17 10:38 UTC (permalink / raw)
To: Chun-Kuang Hu, Philipp Zabel, David Airlie, Daniel Vetter,
Matthias Brugger, AngeloGioacchino Del Regno, dri-devel,
linux-mediatek, linux-kernel, linux-arm-kernel, chrome-platform
Cc: Wojciech Macek
In case there is no DP device attached to the port the
transfer function should return IO error, similar to what
other drivers do.
In case EAGAIN is returned then any read from /dev/drm_dp_aux
device ends up in an infinite loop as the upper layers
constantly repeats the transfer request.
Fixes: f70ac097a2cf ("drm/mediatek: Add MT8195 Embedded DisplayPort driver")
Signed-off-by: Wojciech Macek <wmacek@chromium.org>
---
Changelog v2-v1:
- added "Fixes" tag
- corrected e-mail address
V1: https://patchwork.kernel.org/project/linux-mediatek/patch/20240402071113.3135903-1-wmacek@chromium.org/
drivers/gpu/drm/mediatek/mtk_dp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/mediatek/mtk_dp.c b/drivers/gpu/drm/mediatek/mtk_dp.c
index 0ba72102636a..536366956447 100644
--- a/drivers/gpu/drm/mediatek/mtk_dp.c
+++ b/drivers/gpu/drm/mediatek/mtk_dp.c
@@ -2104,7 +2104,7 @@ static ssize_t mtk_dp_aux_transfer(struct drm_dp_aux *mtk_aux,
if (mtk_dp->bridge.type != DRM_MODE_CONNECTOR_eDP &&
!mtk_dp->train_info.cable_plugged_in) {
- ret = -EAGAIN;
+ ret = -EIO;
goto err;
}
--
2.44.0.683.g7961c838ac-goog
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [PATCH v2] drm/mediatek/dp: fix mtk_dp_aux_transfer return value
2024-04-17 10:38 ` Wojciech Macek
@ 2024-04-17 13:52 ` AngeloGioacchino Del Regno
-1 siblings, 0 replies; 11+ messages in thread
From: AngeloGioacchino Del Regno @ 2024-04-17 13:52 UTC (permalink / raw)
To: Wojciech Macek, Chun-Kuang Hu, Philipp Zabel, David Airlie,
Daniel Vetter, Matthias Brugger, dri-devel, linux-mediatek,
linux-kernel, linux-arm-kernel, chrome-platform
Il 17/04/24 12:38, Wojciech Macek ha scritto:
> In case there is no DP device attached to the port the
> transfer function should return IO error, similar to what
> other drivers do.
> In case EAGAIN is returned then any read from /dev/drm_dp_aux
> device ends up in an infinite loop as the upper layers
> constantly repeats the transfer request.
>
> Fixes: f70ac097a2cf ("drm/mediatek: Add MT8195 Embedded DisplayPort driver")
> Signed-off-by: Wojciech Macek <wmacek@chromium.org>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH v2] drm/mediatek/dp: fix mtk_dp_aux_transfer return value
@ 2024-04-17 13:52 ` AngeloGioacchino Del Regno
0 siblings, 0 replies; 11+ messages in thread
From: AngeloGioacchino Del Regno @ 2024-04-17 13:52 UTC (permalink / raw)
To: Wojciech Macek, Chun-Kuang Hu, Philipp Zabel, David Airlie,
Daniel Vetter, Matthias Brugger, dri-devel, linux-mediatek,
linux-kernel, linux-arm-kernel, chrome-platform
Il 17/04/24 12:38, Wojciech Macek ha scritto:
> In case there is no DP device attached to the port the
> transfer function should return IO error, similar to what
> other drivers do.
> In case EAGAIN is returned then any read from /dev/drm_dp_aux
> device ends up in an infinite loop as the upper layers
> constantly repeats the transfer request.
>
> Fixes: f70ac097a2cf ("drm/mediatek: Add MT8195 Embedded DisplayPort driver")
> Signed-off-by: Wojciech Macek <wmacek@chromium.org>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2] drm/mediatek/dp: fix mtk_dp_aux_transfer return value
2024-04-17 10:38 ` Wojciech Macek
(?)
@ 2024-04-18 2:01 ` CK Hu (胡俊光)
-1 siblings, 0 replies; 11+ messages in thread
From: CK Hu (胡俊光) @ 2024-04-18 2:01 UTC (permalink / raw)
To: wmacek@chromium.org, linux-mediatek@lists.infradead.org,
linux-kernel@vger.kernel.org, chrome-platform@lists.linux.dev,
chunkuang.hu@kernel.org, daniel@ffwll.ch, p.zabel@pengutronix.de,
dri-devel@lists.freedesktop.org, airlied@gmail.com,
linux-arm-kernel@lists.infradead.org, matthias.bgg@gmail.com,
angelogioacchino.delregno@collabora.com
Hi, Wojciech:
On Wed, 2024-04-17 at 10:38 +0000, Wojciech Macek wrote:
>
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> In case there is no DP device attached to the port the
> transfer function should return IO error, similar to what
> other drivers do.
> In case EAGAIN is returned then any read from /dev/drm_dp_aux
> device ends up in an infinite loop as the upper layers
> constantly repeats the transfer request.
Reviewed-by: CK Hu <ck.hu@mediatek.com>
>
> Fixes: f70ac097a2cf ("drm/mediatek: Add MT8195 Embedded DisplayPort
> driver")
> Signed-off-by: Wojciech Macek <wmacek@chromium.org>
> ---
> Changelog v2-v1:
> - added "Fixes" tag
> - corrected e-mail address
>
> V1:
> https://urldefense.com/v3/__https://patchwork.kernel.org/project/linux-mediatek/patch/20240402071113.3135903-1-wmacek@chromium.org/__;!!CTRNKA9wMg0ARbw!kBY_x5kGvdau3baCVwGwRuKojhHVIEW8Hvbw385x2pXi_1pCGMCntptpmOnEPoMbwA0dgA4JTxwfy6o$
>
> drivers/gpu/drm/mediatek/mtk_dp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_dp.c
> b/drivers/gpu/drm/mediatek/mtk_dp.c
> index 0ba72102636a..536366956447 100644
> --- a/drivers/gpu/drm/mediatek/mtk_dp.c
> +++ b/drivers/gpu/drm/mediatek/mtk_dp.c
> @@ -2104,7 +2104,7 @@ static ssize_t mtk_dp_aux_transfer(struct
> drm_dp_aux *mtk_aux,
>
> if (mtk_dp->bridge.type != DRM_MODE_CONNECTOR_eDP &&
> !mtk_dp->train_info.cable_plugged_in) {
> - ret = -EAGAIN;
> + ret = -EIO;
> goto err;
> }
>
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH v2] drm/mediatek/dp: fix mtk_dp_aux_transfer return value
@ 2024-04-18 2:01 ` CK Hu (胡俊光)
0 siblings, 0 replies; 11+ messages in thread
From: CK Hu (胡俊光) @ 2024-04-18 2:01 UTC (permalink / raw)
To: wmacek@chromium.org, linux-mediatek@lists.infradead.org,
linux-kernel@vger.kernel.org, chrome-platform@lists.linux.dev,
chunkuang.hu@kernel.org, daniel@ffwll.ch, p.zabel@pengutronix.de,
dri-devel@lists.freedesktop.org, airlied@gmail.com,
linux-arm-kernel@lists.infradead.org, matthias.bgg@gmail.com,
angelogioacchino.delregno@collabora.com
[-- Attachment #1: Type: text/plain, Size: 1619 bytes --]
Hi, Wojciech:
On Wed, 2024-04-17 at 10:38 +0000, Wojciech Macek wrote:
>
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> In case there is no DP device attached to the port the
> transfer function should return IO error, similar to what
> other drivers do.
> In case EAGAIN is returned then any read from /dev/drm_dp_aux
> device ends up in an infinite loop as the upper layers
> constantly repeats the transfer request.
Reviewed-by: CK Hu <ck.hu@mediatek.com>
>
> Fixes: f70ac097a2cf ("drm/mediatek: Add MT8195 Embedded DisplayPort
> driver")
> Signed-off-by: Wojciech Macek <wmacek@chromium.org>
> ---
> Changelog v2-v1:
> - added "Fixes" tag
> - corrected e-mail address
>
> V1:
> https://urldefense.com/v3/__https://patchwork.kernel.org/project/linux-mediatek/patch/20240402071113.3135903-1-wmacek@chromium.org/__;!!CTRNKA9wMg0ARbw!kBY_x5kGvdau3baCVwGwRuKojhHVIEW8Hvbw385x2pXi_1pCGMCntptpmOnEPoMbwA0dgA4JTxwfy6o$
>
> drivers/gpu/drm/mediatek/mtk_dp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_dp.c
> b/drivers/gpu/drm/mediatek/mtk_dp.c
> index 0ba72102636a..536366956447 100644
> --- a/drivers/gpu/drm/mediatek/mtk_dp.c
> +++ b/drivers/gpu/drm/mediatek/mtk_dp.c
> @@ -2104,7 +2104,7 @@ static ssize_t mtk_dp_aux_transfer(struct
> drm_dp_aux *mtk_aux,
>
> if (mtk_dp->bridge.type != DRM_MODE_CONNECTOR_eDP &&
> !mtk_dp->train_info.cable_plugged_in) {
> - ret = -EAGAIN;
> + ret = -EIO;
> goto err;
> }
>
[-- Attachment #2: Type: text/html, Size: 3452 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH v2] drm/mediatek/dp: fix mtk_dp_aux_transfer return value
@ 2024-04-18 2:01 ` CK Hu (胡俊光)
0 siblings, 0 replies; 11+ messages in thread
From: CK Hu (胡俊光) @ 2024-04-18 2:01 UTC (permalink / raw)
To: wmacek@chromium.org, linux-mediatek@lists.infradead.org,
linux-kernel@vger.kernel.org, chrome-platform@lists.linux.dev,
chunkuang.hu@kernel.org, daniel@ffwll.ch, p.zabel@pengutronix.de,
dri-devel@lists.freedesktop.org, airlied@gmail.com,
linux-arm-kernel@lists.infradead.org, matthias.bgg@gmail.com,
angelogioacchino.delregno@collabora.com
Hi, Wojciech:
On Wed, 2024-04-17 at 10:38 +0000, Wojciech Macek wrote:
>
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> In case there is no DP device attached to the port the
> transfer function should return IO error, similar to what
> other drivers do.
> In case EAGAIN is returned then any read from /dev/drm_dp_aux
> device ends up in an infinite loop as the upper layers
> constantly repeats the transfer request.
Reviewed-by: CK Hu <ck.hu@mediatek.com>
>
> Fixes: f70ac097a2cf ("drm/mediatek: Add MT8195 Embedded DisplayPort
> driver")
> Signed-off-by: Wojciech Macek <wmacek@chromium.org>
> ---
> Changelog v2-v1:
> - added "Fixes" tag
> - corrected e-mail address
>
> V1:
> https://urldefense.com/v3/__https://patchwork.kernel.org/project/linux-mediatek/patch/20240402071113.3135903-1-wmacek@chromium.org/__;!!CTRNKA9wMg0ARbw!kBY_x5kGvdau3baCVwGwRuKojhHVIEW8Hvbw385x2pXi_1pCGMCntptpmOnEPoMbwA0dgA4JTxwfy6o$
>
> drivers/gpu/drm/mediatek/mtk_dp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_dp.c
> b/drivers/gpu/drm/mediatek/mtk_dp.c
> index 0ba72102636a..536366956447 100644
> --- a/drivers/gpu/drm/mediatek/mtk_dp.c
> +++ b/drivers/gpu/drm/mediatek/mtk_dp.c
> @@ -2104,7 +2104,7 @@ static ssize_t mtk_dp_aux_transfer(struct
> drm_dp_aux *mtk_aux,
>
> if (mtk_dp->bridge.type != DRM_MODE_CONNECTOR_eDP &&
> !mtk_dp->train_info.cable_plugged_in) {
> - ret = -EAGAIN;
> + ret = -EIO;
> goto err;
> }
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2] drm/mediatek/dp: fix mtk_dp_aux_transfer return value
2024-04-17 10:38 ` Wojciech Macek
@ 2024-05-27 2:55 ` patchwork-bot+chrome-platform
-1 siblings, 0 replies; 11+ messages in thread
From: patchwork-bot+chrome-platform @ 2024-05-27 2:55 UTC (permalink / raw)
To: Wojciech Macek
Cc: chunkuang.hu, p.zabel, airlied, daniel, matthias.bgg,
angelogioacchino.delregno, dri-devel, linux-mediatek,
linux-kernel, linux-arm-kernel, chrome-platform
Hello:
This patch was applied to chrome-platform/linux.git (for-kernelci)
by Chun-Kuang Hu <chunkuang.hu@kernel.org>:
On Wed, 17 Apr 2024 10:38:19 +0000 you wrote:
> In case there is no DP device attached to the port the
> transfer function should return IO error, similar to what
> other drivers do.
> In case EAGAIN is returned then any read from /dev/drm_dp_aux
> device ends up in an infinite loop as the upper layers
> constantly repeats the transfer request.
>
> [...]
Here is the summary with links:
- [v2] drm/mediatek/dp: fix mtk_dp_aux_transfer return value
https://git.kernel.org/chrome-platform/c/8431fff9e0f3
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH v2] drm/mediatek/dp: fix mtk_dp_aux_transfer return value
@ 2024-05-27 2:55 ` patchwork-bot+chrome-platform
0 siblings, 0 replies; 11+ messages in thread
From: patchwork-bot+chrome-platform @ 2024-05-27 2:55 UTC (permalink / raw)
To: Wojciech Macek
Cc: chunkuang.hu, p.zabel, airlied, daniel, matthias.bgg,
angelogioacchino.delregno, dri-devel, linux-mediatek,
linux-kernel, linux-arm-kernel, chrome-platform
Hello:
This patch was applied to chrome-platform/linux.git (for-kernelci)
by Chun-Kuang Hu <chunkuang.hu@kernel.org>:
On Wed, 17 Apr 2024 10:38:19 +0000 you wrote:
> In case there is no DP device attached to the port the
> transfer function should return IO error, similar to what
> other drivers do.
> In case EAGAIN is returned then any read from /dev/drm_dp_aux
> device ends up in an infinite loop as the upper layers
> constantly repeats the transfer request.
>
> [...]
Here is the summary with links:
- [v2] drm/mediatek/dp: fix mtk_dp_aux_transfer return value
https://git.kernel.org/chrome-platform/c/8431fff9e0f3
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2] drm/mediatek/dp: fix mtk_dp_aux_transfer return value
2024-04-17 10:38 ` Wojciech Macek
@ 2024-05-27 3:07 ` patchwork-bot+chrome-platform
-1 siblings, 0 replies; 11+ messages in thread
From: patchwork-bot+chrome-platform @ 2024-05-27 3:07 UTC (permalink / raw)
To: Wojciech Macek
Cc: chunkuang.hu, p.zabel, airlied, daniel, matthias.bgg,
angelogioacchino.delregno, dri-devel, linux-mediatek,
linux-kernel, linux-arm-kernel, chrome-platform
Hello:
This patch was applied to chrome-platform/linux.git (for-next)
by Chun-Kuang Hu <chunkuang.hu@kernel.org>:
On Wed, 17 Apr 2024 10:38:19 +0000 you wrote:
> In case there is no DP device attached to the port the
> transfer function should return IO error, similar to what
> other drivers do.
> In case EAGAIN is returned then any read from /dev/drm_dp_aux
> device ends up in an infinite loop as the upper layers
> constantly repeats the transfer request.
>
> [...]
Here is the summary with links:
- [v2] drm/mediatek/dp: fix mtk_dp_aux_transfer return value
https://git.kernel.org/chrome-platform/c/8431fff9e0f3
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH v2] drm/mediatek/dp: fix mtk_dp_aux_transfer return value
@ 2024-05-27 3:07 ` patchwork-bot+chrome-platform
0 siblings, 0 replies; 11+ messages in thread
From: patchwork-bot+chrome-platform @ 2024-05-27 3:07 UTC (permalink / raw)
To: Wojciech Macek
Cc: chunkuang.hu, p.zabel, airlied, daniel, matthias.bgg,
angelogioacchino.delregno, dri-devel, linux-mediatek,
linux-kernel, linux-arm-kernel, chrome-platform
Hello:
This patch was applied to chrome-platform/linux.git (for-next)
by Chun-Kuang Hu <chunkuang.hu@kernel.org>:
On Wed, 17 Apr 2024 10:38:19 +0000 you wrote:
> In case there is no DP device attached to the port the
> transfer function should return IO error, similar to what
> other drivers do.
> In case EAGAIN is returned then any read from /dev/drm_dp_aux
> device ends up in an infinite loop as the upper layers
> constantly repeats the transfer request.
>
> [...]
Here is the summary with links:
- [v2] drm/mediatek/dp: fix mtk_dp_aux_transfer return value
https://git.kernel.org/chrome-platform/c/8431fff9e0f3
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 11+ messages in thread