From: Chris Wilson <chris@chris-wilson.co.uk>
To: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: Re: [PATCH 1/3] drm/i915: extract gmbus_wait_hw_status
Date: Wed, 05 Sep 2012 23:12:06 +0100 [thread overview]
Message-ID: <275ffc$6g5pou@fmsmga002.fm.intel.com> (raw)
In-Reply-To: <1346873081-1305-1-git-send-email-daniel.vetter@ffwll.ch>
Who wrote wait_for()? It is a deadly booby trap!
On Wed, 5 Sep 2012 21:24:39 +0200, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> - if (wait_for((I915_READ(GMBUS2 + reg_offset) & GMBUS_ACTIVE) == 0,
> - 10)) {
> + if (gmbus_wait_hw_status(dev_priv, GMBUS_ACTIVE)) {
This is reversing the status being waited for. :(
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
prev parent reply other threads:[~2012-09-05 22:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-05 19:24 [PATCH 1/3] drm/i915: extract gmbus_wait_hw_status Daniel Vetter
2012-09-05 19:24 ` [PATCH 2/3] drm/i915: wire up gmbus irq handler Daniel Vetter
2012-09-05 21:29 ` Chris Wilson
2012-09-05 21:36 ` Daniel Vetter
2012-09-05 21:52 ` Chris Wilson
2012-09-05 19:24 ` [PATCH 3/3] drm/i915: use the gmbus irq for waits Daniel Vetter
2012-09-05 21:34 ` Chris Wilson
2012-09-05 21:25 ` [PATCH 1/3] drm/i915: extract gmbus_wait_hw_status Chris Wilson
2012-09-05 21:30 ` Daniel Vetter
2012-09-05 22:12 ` Chris Wilson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='275ffc$6g5pou@fmsmga002.fm.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.