From: Chris Wilson <chris@chris-wilson.co.uk>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 2/3] drm/i915: wire up gmbus irq handler
Date: Wed, 05 Sep 2012 22:52:21 +0100 [thread overview]
Message-ID: <6c3329$5sbht6@orsmga002.jf.intel.com> (raw)
In-Reply-To: <CAKMK7uH7nZ-Fxf1UXVqVmWgwJM0pEZZaG1w8-XoN4e=o555a7g@mail.gmail.com>
On Wed, 5 Sep 2012 23:36:46 +0200, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> On Wed, Sep 5, 2012 at 11:29 PM, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> > On Wed, 5 Sep 2012 21:24:40 +0200, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> >> Only enables the interrupt and puts a irq handler into place, doesn't
> >> do anything yet.
> >>
> >> Unfortunately there's no gmbus interrupt support for gen2/3 (safe for
> >> pnv, but there the irq is marked as "Test mode").
> >
> > The basics look good, but the paranoia says I'd like for the interrupt
> > to only be enabled as required.
>
> I do that ;-) The real interrupt generation is also controlled by
> GMBUS4 - as long as that's 0, no interrupt shows up anywhere. And
> frobbing GMBUS4 is much easier than adding a bunch of of spinlocks
> around frobbing SDE_IIR ...
Indeed, killing it at source is preferrable all round. Are you sure
GMBUS4 is always initialised to zero?
So this patch looks sound,
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2012-09-05 21:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-05 19:24 [PATCH 1/3] drm/i915: extract gmbus_wait_hw_status Daniel Vetter
2012-09-05 19:24 ` [PATCH 2/3] drm/i915: wire up gmbus irq handler Daniel Vetter
2012-09-05 21:29 ` Chris Wilson
2012-09-05 21:36 ` Daniel Vetter
2012-09-05 21:52 ` Chris Wilson [this message]
2012-09-05 19:24 ` [PATCH 3/3] drm/i915: use the gmbus irq for waits Daniel Vetter
2012-09-05 21:34 ` Chris Wilson
2012-09-05 21:25 ` [PATCH 1/3] drm/i915: extract gmbus_wait_hw_status Chris Wilson
2012-09-05 21:30 ` Daniel Vetter
2012-09-05 22:12 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='6c3329$5sbht6@orsmga002.jf.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.