* [PATCH v2 1/1] drm/i915: Remove duplicate and unused register #defines in i915_reg.h
@ 2012-12-05 14:37 Dexuan Cui
2012-12-05 14:50 ` Chris Wilson
0 siblings, 1 reply; 3+ messages in thread
From: Dexuan Cui @ 2012-12-05 14:37 UTC (permalink / raw)
To: intel-gfx
TRANS_DP_VIDEO_AUDIO is not used at all.
The other 3 has duplicated #defines.
Signed-off-by: Dexuan Cui <dexuan.cui@intel.com>
---
drivers/gpu/drm/i915/i915_reg.h | 4 ----
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
index 97fbd9d..e53c58c 100644
--- a/drivers/gpu/drm/i915/i915_reg.h
+++ b/drivers/gpu/drm/i915/i915_reg.h
@@ -1891,8 +1891,6 @@
#define PFIT_SCALING_PILLAR (2 << 26)
#define PFIT_SCALING_LETTER (3 << 26)
#define PFIT_PGM_RATIOS 0x61234
-#define PFIT_VERT_SCALE_MASK 0xfff00000
-#define PFIT_HORIZ_SCALE_MASK 0x0000fff0
/* Pre-965 */
#define PFIT_VERT_SCALE_SHIFT 20
#define PFIT_VERT_SCALE_MASK 0xfff00000
@@ -3815,8 +3813,6 @@
#define TRANS_FSYNC_DELAY_HB2 (1<<27)
#define TRANS_FSYNC_DELAY_HB3 (2<<27)
#define TRANS_FSYNC_DELAY_HB4 (3<<27)
-#define TRANS_DP_AUDIO_ONLY (1<<26)
-#define TRANS_DP_VIDEO_AUDIO (0<<26)
#define TRANS_INTERLACE_MASK (7<<21)
#define TRANS_PROGRESSIVE (0<<21)
#define TRANS_INTERLACED (3<<21)
--
1.7.6
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2 1/1] drm/i915: Remove duplicate and unused register #defines in i915_reg.h
2012-12-05 14:37 [PATCH v2 1/1] drm/i915: Remove duplicate and unused register #defines in i915_reg.h Dexuan Cui
@ 2012-12-05 14:50 ` Chris Wilson
2012-12-05 15:04 ` Daniel Vetter
0 siblings, 1 reply; 3+ messages in thread
From: Chris Wilson @ 2012-12-05 14:50 UTC (permalink / raw)
To: Dexuan Cui, intel-gfx
On Wed, 5 Dec 2012 22:37:17 +0800, Dexuan Cui <dexuan.cui@intel.com> wrote:
> TRANS_DP_VIDEO_AUDIO is not used at all.
Now you are just opening a can of worms, as none of them are actually
used other than as documentation.
> The other 3 has duplicated #defines.
>
> Signed-off-by: Dexuan Cui <dexuan.cui@intel.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2 1/1] drm/i915: Remove duplicate and unused register #defines in i915_reg.h
2012-12-05 14:50 ` Chris Wilson
@ 2012-12-05 15:04 ` Daniel Vetter
0 siblings, 0 replies; 3+ messages in thread
From: Daniel Vetter @ 2012-12-05 15:04 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
On Wed, Dec 05, 2012 at 02:50:04PM +0000, Chris Wilson wrote:
> On Wed, 5 Dec 2012 22:37:17 +0800, Dexuan Cui <dexuan.cui@intel.com> wrote:
> > TRANS_DP_VIDEO_AUDIO is not used at all.
>
> Now you are just opening a can of worms, as none of them are actually
> used other than as documentation.
>
> > The other 3 has duplicated #defines.
> >
> > Signed-off-by: Dexuan Cui <dexuan.cui@intel.com>
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Queued for -next, thanks for the patch.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-12-05 15:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-12-05 14:37 [PATCH v2 1/1] drm/i915: Remove duplicate and unused register #defines in i915_reg.h Dexuan Cui
2012-12-05 14:50 ` Chris Wilson
2012-12-05 15:04 ` Daniel Vetter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.