[PATCH v3 5/7] phy-sun4i-usb: Warn when external vbus is detected

From: icenowy@aosc.xyz (Icenowy Zheng)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 5/7] phy-sun4i-usb: Warn when external vbus is detected
Date: Sun, 21 Aug 2016 22:32:09 +0800	[thread overview]
Message-ID: <27711471789929@web21g.yandex.ru> (raw)
In-Reply-To: <1471781799-10457-5-git-send-email-hdegoede@redhat.com>

21.08.2016, 20:22, "Hans de Goede" <hdegoede@redhat.com>:
> Warn when external vbus is detected when we're trying to enable our
> own vbus.

Will it lead to a dmesg flood if a not-well-connected USB OTG Charging Hub
is present?

>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
> Changes in v2:
> -No changes
> Changes in v3:
> -No changes
> ---
> ?drivers/phy/phy-sun4i-usb.c | 4 +++-
> ?1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/phy/phy-sun4i-usb.c b/drivers/phy/phy-sun4i-usb.c
> index af42f8d..03f030b 100644
> --- a/drivers/phy/phy-sun4i-usb.c
> +++ b/drivers/phy/phy-sun4i-usb.c
> @@ -390,8 +390,10 @@ static int sun4i_usb_phy_power_on(struct phy *_phy)
>
> ?????????/* For phy0 only turn on Vbus if we don't have an ext. Vbus */
> ?????????if (phy->index == 0 && sun4i_usb_phy0_have_vbus_det(data) &&
> - data->vbus_det)
> + data->vbus_det) {
> + dev_warn(&_phy->dev, "External vbus detected, not enabling our own vbus\n");
> ?????????????????return 0;
> + }
>
> ?????????ret = regulator_enable(phy->vbus);
> ?????????if (ret)
> --
> 2.7.4
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel