From: Diederik de Haas <didi.debian@cknow.org>
To: heiko@sntech.de, linux-rockchip@lists.infradead.org
Cc: dsimic@manjaro.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
Andy Yan <andyshrk@163.com>, Andy Yan <andyshrk@163.com>
Subject: Re: [PATCH] arm64: dts: rockchip: Fix the i2c address of es8316 on Cool Pi 4B
Date: Sun, 23 Jun 2024 13:31:02 +0200 [thread overview]
Message-ID: <2771372.9AS07kTVam@bagend> (raw)
In-Reply-To: <20240623083413.2051412-1-andyshrk@163.com>
[-- Attachment #1.1: Type: text/plain, Size: 865 bytes --]
On Sunday, 23 June 2024 10:34:13 CEST Andy Yan wrote:
> According to the hardware design, the i2c address of audio codec es8316
> on Cool Pi 4B is 0x10.
>
> ...
> ---
>
> arch/arm64/boot/dts/rockchip/rk3588s-coolpi-4b.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-coolpi-4b.dts
> b/arch/arm64/boot/dts/rockchip/rk3588s-coolpi-4b.dts index
> 20a0a60acd16..091dee37d068 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3588s-coolpi-4b.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3588s-coolpi-4b.dts
> @@ -302,7 +302,7 @@ &i2c7 {
>
> es8316: audio-codec@11 {
Shouldn't this be `@10` then too?
> compatible = "everest,es8316";
> - reg = <0x11>;
> + reg = <0x10>;
> assigned-clocks = <&cru I2S0_8CH_MCLKOUT>;
> assigned-clock-rates = <12288000>;
> clocks = <&cru I2S0_8CH_MCLKOUT>;
[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 170 bytes --]
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: Diederik de Haas <didi.debian@cknow.org>
To: heiko@sntech.de, linux-rockchip@lists.infradead.org
Cc: dsimic@manjaro.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
Andy Yan <andyshrk@163.com>, Andy Yan <andyshrk@163.com>
Subject: Re: [PATCH] arm64: dts: rockchip: Fix the i2c address of es8316 on Cool Pi 4B
Date: Sun, 23 Jun 2024 13:31:02 +0200 [thread overview]
Message-ID: <2771372.9AS07kTVam@bagend> (raw)
In-Reply-To: <20240623083413.2051412-1-andyshrk@163.com>
[-- Attachment #1: Type: text/plain, Size: 865 bytes --]
On Sunday, 23 June 2024 10:34:13 CEST Andy Yan wrote:
> According to the hardware design, the i2c address of audio codec es8316
> on Cool Pi 4B is 0x10.
>
> ...
> ---
>
> arch/arm64/boot/dts/rockchip/rk3588s-coolpi-4b.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-coolpi-4b.dts
> b/arch/arm64/boot/dts/rockchip/rk3588s-coolpi-4b.dts index
> 20a0a60acd16..091dee37d068 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3588s-coolpi-4b.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3588s-coolpi-4b.dts
> @@ -302,7 +302,7 @@ &i2c7 {
>
> es8316: audio-codec@11 {
Shouldn't this be `@10` then too?
> compatible = "everest,es8316";
> - reg = <0x11>;
> + reg = <0x10>;
> assigned-clocks = <&cru I2S0_8CH_MCLKOUT>;
> assigned-clock-rates = <12288000>;
> clocks = <&cru I2S0_8CH_MCLKOUT>;
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2024-06-23 11:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-23 8:34 [PATCH] arm64: dts: rockchip: Fix the i2c address of es8316 on Cool Pi 4B Andy Yan
2024-06-23 8:34 ` Andy Yan
2024-06-23 11:31 ` Diederik de Haas [this message]
2024-06-23 11:31 ` Diederik de Haas
2024-06-26 2:01 ` kernel test robot
2024-06-26 13:25 ` Rob Herring (Arm)
2024-06-26 13:25 ` Rob Herring (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2771372.9AS07kTVam@bagend \
--to=didi.debian@cknow.org \
--cc=andyshrk@163.com \
--cc=devicetree@vger.kernel.org \
--cc=dsimic@manjaro.org \
--cc=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.