* [PATCH] arm64: dts: rockchip: Fix the i2c address of es8316 on Cool Pi 4B
@ 2024-06-23 8:34 ` Andy Yan
0 siblings, 0 replies; 7+ messages in thread
From: Andy Yan @ 2024-06-23 8:34 UTC (permalink / raw)
To: heiko
Cc: dsimic, devicetree, linux-arm-kernel, linux-kernel,
linux-rockchip, Andy Yan
According to the hardware design, the i2c address of audio codec es8316
on Cool Pi 4B is 0x10.
This fix the read/write error like bellow:
es8316 7-0011: ASoC: error at soc_component_write_no_lock on es8316.7-0011 for register: [0x0000000c] -6
es8316 7-0011: ASoC: error at soc_component_write_no_lock on es8316.7-0011 for register: [0x00000003] -6
es8316 7-0011: ASoC: error at soc_component_read_no_lock on es8316.7-0011 for register: [0x00000016] -6
es8316 7-0011: ASoC: error at soc_component_read_no_lock on es8316.7-0011 for register: [0x00000016] -6
Fixes: 3f5d336d64d6 ("arm64: dts: rockchip: Add support for rk3588s based board Cool Pi 4B")
Signed-off-by: Andy Yan <andyshrk@163.com>
---
arch/arm64/boot/dts/rockchip/rk3588s-coolpi-4b.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-coolpi-4b.dts b/arch/arm64/boot/dts/rockchip/rk3588s-coolpi-4b.dts
index 20a0a60acd16..091dee37d068 100644
--- a/arch/arm64/boot/dts/rockchip/rk3588s-coolpi-4b.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3588s-coolpi-4b.dts
@@ -302,7 +302,7 @@ &i2c7 {
es8316: audio-codec@11 {
compatible = "everest,es8316";
- reg = <0x11>;
+ reg = <0x10>;
assigned-clocks = <&cru I2S0_8CH_MCLKOUT>;
assigned-clock-rates = <12288000>;
clocks = <&cru I2S0_8CH_MCLKOUT>;
--
2.34.1
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH] arm64: dts: rockchip: Fix the i2c address of es8316 on Cool Pi 4B
@ 2024-06-23 8:34 ` Andy Yan
0 siblings, 0 replies; 7+ messages in thread
From: Andy Yan @ 2024-06-23 8:34 UTC (permalink / raw)
To: heiko
Cc: dsimic, devicetree, linux-arm-kernel, linux-kernel,
linux-rockchip, Andy Yan
According to the hardware design, the i2c address of audio codec es8316
on Cool Pi 4B is 0x10.
This fix the read/write error like bellow:
es8316 7-0011: ASoC: error at soc_component_write_no_lock on es8316.7-0011 for register: [0x0000000c] -6
es8316 7-0011: ASoC: error at soc_component_write_no_lock on es8316.7-0011 for register: [0x00000003] -6
es8316 7-0011: ASoC: error at soc_component_read_no_lock on es8316.7-0011 for register: [0x00000016] -6
es8316 7-0011: ASoC: error at soc_component_read_no_lock on es8316.7-0011 for register: [0x00000016] -6
Fixes: 3f5d336d64d6 ("arm64: dts: rockchip: Add support for rk3588s based board Cool Pi 4B")
Signed-off-by: Andy Yan <andyshrk@163.com>
---
arch/arm64/boot/dts/rockchip/rk3588s-coolpi-4b.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-coolpi-4b.dts b/arch/arm64/boot/dts/rockchip/rk3588s-coolpi-4b.dts
index 20a0a60acd16..091dee37d068 100644
--- a/arch/arm64/boot/dts/rockchip/rk3588s-coolpi-4b.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3588s-coolpi-4b.dts
@@ -302,7 +302,7 @@ &i2c7 {
es8316: audio-codec@11 {
compatible = "everest,es8316";
- reg = <0x11>;
+ reg = <0x10>;
assigned-clocks = <&cru I2S0_8CH_MCLKOUT>;
assigned-clock-rates = <12288000>;
clocks = <&cru I2S0_8CH_MCLKOUT>;
--
2.34.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] arm64: dts: rockchip: Fix the i2c address of es8316 on Cool Pi 4B
2024-06-23 8:34 ` Andy Yan
@ 2024-06-23 11:31 ` Diederik de Haas
-1 siblings, 0 replies; 7+ messages in thread
From: Diederik de Haas @ 2024-06-23 11:31 UTC (permalink / raw)
To: heiko, linux-rockchip
Cc: dsimic, devicetree, linux-arm-kernel, linux-kernel,
linux-rockchip, Andy Yan, Andy Yan
[-- Attachment #1.1: Type: text/plain, Size: 865 bytes --]
On Sunday, 23 June 2024 10:34:13 CEST Andy Yan wrote:
> According to the hardware design, the i2c address of audio codec es8316
> on Cool Pi 4B is 0x10.
>
> ...
> ---
>
> arch/arm64/boot/dts/rockchip/rk3588s-coolpi-4b.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-coolpi-4b.dts
> b/arch/arm64/boot/dts/rockchip/rk3588s-coolpi-4b.dts index
> 20a0a60acd16..091dee37d068 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3588s-coolpi-4b.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3588s-coolpi-4b.dts
> @@ -302,7 +302,7 @@ &i2c7 {
>
> es8316: audio-codec@11 {
Shouldn't this be `@10` then too?
> compatible = "everest,es8316";
> - reg = <0x11>;
> + reg = <0x10>;
> assigned-clocks = <&cru I2S0_8CH_MCLKOUT>;
> assigned-clock-rates = <12288000>;
> clocks = <&cru I2S0_8CH_MCLKOUT>;
[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 170 bytes --]
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] arm64: dts: rockchip: Fix the i2c address of es8316 on Cool Pi 4B
@ 2024-06-23 11:31 ` Diederik de Haas
0 siblings, 0 replies; 7+ messages in thread
From: Diederik de Haas @ 2024-06-23 11:31 UTC (permalink / raw)
To: heiko, linux-rockchip
Cc: dsimic, devicetree, linux-arm-kernel, linux-kernel,
linux-rockchip, Andy Yan, Andy Yan
[-- Attachment #1: Type: text/plain, Size: 865 bytes --]
On Sunday, 23 June 2024 10:34:13 CEST Andy Yan wrote:
> According to the hardware design, the i2c address of audio codec es8316
> on Cool Pi 4B is 0x10.
>
> ...
> ---
>
> arch/arm64/boot/dts/rockchip/rk3588s-coolpi-4b.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-coolpi-4b.dts
> b/arch/arm64/boot/dts/rockchip/rk3588s-coolpi-4b.dts index
> 20a0a60acd16..091dee37d068 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3588s-coolpi-4b.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3588s-coolpi-4b.dts
> @@ -302,7 +302,7 @@ &i2c7 {
>
> es8316: audio-codec@11 {
Shouldn't this be `@10` then too?
> compatible = "everest,es8316";
> - reg = <0x11>;
> + reg = <0x10>;
> assigned-clocks = <&cru I2S0_8CH_MCLKOUT>;
> assigned-clock-rates = <12288000>;
> clocks = <&cru I2S0_8CH_MCLKOUT>;
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] arm64: dts: rockchip: Fix the i2c address of es8316 on Cool Pi 4B
2024-06-23 8:34 ` Andy Yan
(?)
(?)
@ 2024-06-26 2:01 ` kernel test robot
-1 siblings, 0 replies; 7+ messages in thread
From: kernel test robot @ 2024-06-26 2:01 UTC (permalink / raw)
To: Andy Yan; +Cc: oe-kbuild-all
Hi Andy,
kernel test robot noticed the following build warnings:
[auto build test WARNING on linus/master]
[also build test WARNING on v6.10-rc5]
[cannot apply to rockchip/for-next next-20240625]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Andy-Yan/arm64-dts-rockchip-Fix-the-i2c-address-of-es8316-on-Cool-Pi-4B/20240625-183831
base: linus/master
patch link: https://lore.kernel.org/r/20240623083413.2051412-1-andyshrk%40163.com
patch subject: [PATCH] arm64: dts: rockchip: Fix the i2c address of es8316 on Cool Pi 4B
config: arm64-defconfig (https://download.01.org/0day-ci/archive/20240626/202406260921.srQ7V5GB-lkp@intel.com/config)
compiler: aarch64-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240626/202406260921.srQ7V5GB-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202406260921.srQ7V5GB-lkp@intel.com/
dtcheck warnings: (new ones prefixed by >>)
>> arch/arm64/boot/dts/rockchip/rk3588s-coolpi-4b.dts:291.25-305.4: Warning (i2c_bus_reg): /i2c@fec90000/audio-codec@11: I2C bus unit address format error, expected "10"
vim +/10 +291 arch/arm64/boot/dts/rockchip/rk3588s-coolpi-4b.dts
3f5d336d64d6344 Andy Yan 2023-12-12 286
3f5d336d64d6344 Andy Yan 2023-12-12 287 &i2c7 {
3f5d336d64d6344 Andy Yan 2023-12-12 288 pinctrl-0 = <&i2c7m0_xfer>;
3f5d336d64d6344 Andy Yan 2023-12-12 289 status = "okay";
3f5d336d64d6344 Andy Yan 2023-12-12 290
3f5d336d64d6344 Andy Yan 2023-12-12 @291 es8316: audio-codec@11 {
3f5d336d64d6344 Andy Yan 2023-12-12 292 compatible = "everest,es8316";
64f107f19c7217b Andy Yan 2024-06-23 293 reg = <0x10>;
3f5d336d64d6344 Andy Yan 2023-12-12 294 assigned-clocks = <&cru I2S0_8CH_MCLKOUT>;
3f5d336d64d6344 Andy Yan 2023-12-12 295 assigned-clock-rates = <12288000>;
3f5d336d64d6344 Andy Yan 2023-12-12 296 clocks = <&cru I2S0_8CH_MCLKOUT>;
3f5d336d64d6344 Andy Yan 2023-12-12 297 clock-names = "mclk";
3f5d336d64d6344 Andy Yan 2023-12-12 298 #sound-dai-cells = <0>;
3f5d336d64d6344 Andy Yan 2023-12-12 299
3f5d336d64d6344 Andy Yan 2023-12-12 300 port {
3f5d336d64d6344 Andy Yan 2023-12-12 301 es8316_p0_0: endpoint {
3f5d336d64d6344 Andy Yan 2023-12-12 302 remote-endpoint = <&i2s0_8ch_p0_0>;
3f5d336d64d6344 Andy Yan 2023-12-12 303 };
3f5d336d64d6344 Andy Yan 2023-12-12 304 };
3f5d336d64d6344 Andy Yan 2023-12-12 305 };
3f5d336d64d6344 Andy Yan 2023-12-12 306 };
3f5d336d64d6344 Andy Yan 2023-12-12 307
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] arm64: dts: rockchip: Fix the i2c address of es8316 on Cool Pi 4B
2024-06-23 8:34 ` Andy Yan
@ 2024-06-26 13:25 ` Rob Herring (Arm)
-1 siblings, 0 replies; 7+ messages in thread
From: Rob Herring (Arm) @ 2024-06-26 13:25 UTC (permalink / raw)
To: Andy Yan
Cc: dsimic, linux-kernel, linux-rockchip, heiko, devicetree,
linux-arm-kernel
On Sun, 23 Jun 2024 16:34:13 +0800, Andy Yan wrote:
> According to the hardware design, the i2c address of audio codec es8316
> on Cool Pi 4B is 0x10.
>
> This fix the read/write error like bellow:
> es8316 7-0011: ASoC: error at soc_component_write_no_lock on es8316.7-0011 for register: [0x0000000c] -6
> es8316 7-0011: ASoC: error at soc_component_write_no_lock on es8316.7-0011 for register: [0x00000003] -6
> es8316 7-0011: ASoC: error at soc_component_read_no_lock on es8316.7-0011 for register: [0x00000016] -6
> es8316 7-0011: ASoC: error at soc_component_read_no_lock on es8316.7-0011 for register: [0x00000016] -6
>
> Fixes: 3f5d336d64d6 ("arm64: dts: rockchip: Add support for rk3588s based board Cool Pi 4B")
> Signed-off-by: Andy Yan <andyshrk@163.com>
> ---
>
> arch/arm64/boot/dts/rockchip/rk3588s-coolpi-4b.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
My bot found new DTB warnings on the .dts files added or changed in this
series.
Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.
If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:
pip3 install dtschema --upgrade
New warnings running 'make CHECK_DTBS=y rockchip/rk3588s-coolpi-4b.dtb' for 20240623083413.2051412-1-andyshrk@163.com:
arch/arm64/boot/dts/rockchip/rk3588s-coolpi-4b.dts:286.25-300.4: Warning (i2c_bus_reg): /i2c@fec90000/audio-codec@11: I2C bus unit address format error, expected "10"
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] arm64: dts: rockchip: Fix the i2c address of es8316 on Cool Pi 4B
@ 2024-06-26 13:25 ` Rob Herring (Arm)
0 siblings, 0 replies; 7+ messages in thread
From: Rob Herring (Arm) @ 2024-06-26 13:25 UTC (permalink / raw)
To: Andy Yan
Cc: dsimic, linux-kernel, linux-rockchip, heiko, devicetree,
linux-arm-kernel
On Sun, 23 Jun 2024 16:34:13 +0800, Andy Yan wrote:
> According to the hardware design, the i2c address of audio codec es8316
> on Cool Pi 4B is 0x10.
>
> This fix the read/write error like bellow:
> es8316 7-0011: ASoC: error at soc_component_write_no_lock on es8316.7-0011 for register: [0x0000000c] -6
> es8316 7-0011: ASoC: error at soc_component_write_no_lock on es8316.7-0011 for register: [0x00000003] -6
> es8316 7-0011: ASoC: error at soc_component_read_no_lock on es8316.7-0011 for register: [0x00000016] -6
> es8316 7-0011: ASoC: error at soc_component_read_no_lock on es8316.7-0011 for register: [0x00000016] -6
>
> Fixes: 3f5d336d64d6 ("arm64: dts: rockchip: Add support for rk3588s based board Cool Pi 4B")
> Signed-off-by: Andy Yan <andyshrk@163.com>
> ---
>
> arch/arm64/boot/dts/rockchip/rk3588s-coolpi-4b.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
My bot found new DTB warnings on the .dts files added or changed in this
series.
Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.
If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:
pip3 install dtschema --upgrade
New warnings running 'make CHECK_DTBS=y rockchip/rk3588s-coolpi-4b.dtb' for 20240623083413.2051412-1-andyshrk@163.com:
arch/arm64/boot/dts/rockchip/rk3588s-coolpi-4b.dts:286.25-300.4: Warning (i2c_bus_reg): /i2c@fec90000/audio-codec@11: I2C bus unit address format error, expected "10"
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2024-06-26 13:25 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-06-23 8:34 [PATCH] arm64: dts: rockchip: Fix the i2c address of es8316 on Cool Pi 4B Andy Yan
2024-06-23 8:34 ` Andy Yan
2024-06-23 11:31 ` Diederik de Haas
2024-06-23 11:31 ` Diederik de Haas
2024-06-26 2:01 ` kernel test robot
2024-06-26 13:25 ` Rob Herring (Arm)
2024-06-26 13:25 ` Rob Herring (Arm)
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.