* [meta-handheld][PATCH] meta-handheld: append to BBPATH instead of prepend so order of bblayers.conf is respected @ 2012-05-23 15:50 Martin Jansa 2012-06-16 7:01 ` Martin Jansa 0 siblings, 1 reply; 6+ messages in thread From: Martin Jansa @ 2012-05-23 15:50 UTC (permalink / raw) To: openembedded-devel Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com> --- conf/layer.conf | 11 ++++++++--- 1 files changed, 8 insertions(+), 3 deletions(-) diff --git a/conf/layer.conf b/conf/layer.conf index 7a2441b..31dcb16 100644 --- a/conf/layer.conf +++ b/conf/layer.conf @@ -1,13 +1,18 @@ # Layer configuration for meta-handheld layer # Copyright 2011 Intel Corporation -# We have a conf and classes directory, prepend to BBPATH to prefer our versions -BBPATH := "${LAYERDIR}:${BBPATH}" +# We have a conf and classes directory, append to BBPATH +BBPATH .= ":${LAYERDIR}" # We have a recipes directory, add to BBFILES -BBFILES := "${BBFILES} ${LAYERDIR}/recipes-*/*/*.bb ${LAYERDIR}/recipes-*/*/*.bbappend" +BBFILES += "${LAYERDIR}/recipes-*/*/*.bb ${LAYERDIR}/recipes-*/*/*.bbappend" BBFILE_COLLECTIONS += "meta-handheld" BBFILE_PATTERN_meta-handheld := "^${LAYERDIR}/" + +# Define the priority for recipes (.bb files) from this layer, +# choosing carefully how this layer interacts with all of the +# other layers. + BBFILE_PRIORITY_meta-handheld = "7" -- 1.7.8.6 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [meta-handheld][PATCH] meta-handheld: append to BBPATH instead of prepend so order of bblayers.conf is respected 2012-05-23 15:50 [meta-handheld][PATCH] meta-handheld: append to BBPATH instead of prepend so order of bblayers.conf is respected Martin Jansa @ 2012-06-16 7:01 ` Martin Jansa 2012-06-16 19:28 ` Paul Eggleton 0 siblings, 1 reply; 6+ messages in thread From: Martin Jansa @ 2012-06-16 7:01 UTC (permalink / raw) To: openembedded-devel [-- Attachment #1: Type: text/plain, Size: 1313 bytes --] On Wed, May 23, 2012 at 05:50:37PM +0200, Martin Jansa wrote: > Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com> ping > --- > conf/layer.conf | 11 ++++++++--- > 1 files changed, 8 insertions(+), 3 deletions(-) > > diff --git a/conf/layer.conf b/conf/layer.conf > index 7a2441b..31dcb16 100644 > --- a/conf/layer.conf > +++ b/conf/layer.conf > @@ -1,13 +1,18 @@ > # Layer configuration for meta-handheld layer > # Copyright 2011 Intel Corporation > > -# We have a conf and classes directory, prepend to BBPATH to prefer our versions > -BBPATH := "${LAYERDIR}:${BBPATH}" > +# We have a conf and classes directory, append to BBPATH > +BBPATH .= ":${LAYERDIR}" > > # We have a recipes directory, add to BBFILES > -BBFILES := "${BBFILES} ${LAYERDIR}/recipes-*/*/*.bb ${LAYERDIR}/recipes-*/*/*.bbappend" > +BBFILES += "${LAYERDIR}/recipes-*/*/*.bb ${LAYERDIR}/recipes-*/*/*.bbappend" > > BBFILE_COLLECTIONS += "meta-handheld" > BBFILE_PATTERN_meta-handheld := "^${LAYERDIR}/" > + > +# Define the priority for recipes (.bb files) from this layer, > +# choosing carefully how this layer interacts with all of the > +# other layers. > + > BBFILE_PRIORITY_meta-handheld = "7" > > -- > 1.7.8.6 > -- Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 205 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [meta-handheld][PATCH] meta-handheld: append to BBPATH instead of prepend so order of bblayers.conf is respected 2012-06-16 7:01 ` Martin Jansa @ 2012-06-16 19:28 ` Paul Eggleton 2012-06-16 19:37 ` Martin Jansa 0 siblings, 1 reply; 6+ messages in thread From: Paul Eggleton @ 2012-06-16 19:28 UTC (permalink / raw) To: Martin Jansa; +Cc: openembedded-devel On Saturday 16 June 2012 09:01:17 Martin Jansa wrote: > On Wed, May 23, 2012 at 05:50:37PM +0200, Martin Jansa wrote: > > Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com> > > ping > > > --- > > > > conf/layer.conf | 11 ++++++++--- > > 1 files changed, 8 insertions(+), 3 deletions(-) > > > > diff --git a/conf/layer.conf b/conf/layer.conf > > index 7a2441b..31dcb16 100644 > > --- a/conf/layer.conf > > +++ b/conf/layer.conf > > @@ -1,13 +1,18 @@ > > > > # Layer configuration for meta-handheld layer > > # Copyright 2011 Intel Corporation > > > > -# We have a conf and classes directory, prepend to BBPATH to prefer our > > versions -BBPATH := "${LAYERDIR}:${BBPATH}" > > +# We have a conf and classes directory, append to BBPATH > > +BBPATH .= ":${LAYERDIR}" > > > > # We have a recipes directory, add to BBFILES > > > > -BBFILES := "${BBFILES} ${LAYERDIR}/recipes-*/*/*.bb > > ${LAYERDIR}/recipes-*/*/*.bbappend" > > +BBFILES += > > "${LAYERDIR}/recipes-*/*/*.bb ${LAYERDIR}/recipes-*/*/*.bbappend"> > > BBFILE_COLLECTIONS += "meta-handheld" > > BBFILE_PATTERN_meta-handheld := "^${LAYERDIR}/" I was all set to apply this now (sorry for the delay) and then I noticed you changed the above without comment - why was that? Cheers, Paul -- Paul Eggleton Intel Open Source Technology Centre ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [meta-handheld][PATCH] meta-handheld: append to BBPATH instead of prepend so order of bblayers.conf is respected 2012-06-16 19:28 ` Paul Eggleton @ 2012-06-16 19:37 ` Martin Jansa 2012-06-16 19:40 ` Martin Jansa 0 siblings, 1 reply; 6+ messages in thread From: Martin Jansa @ 2012-06-16 19:37 UTC (permalink / raw) To: Paul Eggleton; +Cc: openembedded-devel [-- Attachment #1: Type: text/plain, Size: 1600 bytes --] On Sat, Jun 16, 2012 at 08:28:28PM +0100, Paul Eggleton wrote: > On Saturday 16 June 2012 09:01:17 Martin Jansa wrote: > > On Wed, May 23, 2012 at 05:50:37PM +0200, Martin Jansa wrote: > > > Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com> > > > > ping > > > > > --- > > > > > > conf/layer.conf | 11 ++++++++--- > > > 1 files changed, 8 insertions(+), 3 deletions(-) > > > > > > diff --git a/conf/layer.conf b/conf/layer.conf > > > index 7a2441b..31dcb16 100644 > > > --- a/conf/layer.conf > > > +++ b/conf/layer.conf > > > @@ -1,13 +1,18 @@ > > > > > > # Layer configuration for meta-handheld layer > > > # Copyright 2011 Intel Corporation > > > > > > -# We have a conf and classes directory, prepend to BBPATH to prefer our > > > versions -BBPATH := "${LAYERDIR}:${BBPATH}" > > > +# We have a conf and classes directory, append to BBPATH > > > +BBPATH .= ":${LAYERDIR}" > > > > > > # We have a recipes directory, add to BBFILES > > > > > > -BBFILES := "${BBFILES} ${LAYERDIR}/recipes-*/*/*.bb > > > ${LAYERDIR}/recipes-*/*/*.bbappend" > > > +BBFILES += > > > "${LAYERDIR}/recipes-*/*/*.bb ${LAYERDIR}/recipes-*/*/*.bbappend"> > > > BBFILE_COLLECTIONS += "meta-handheld" > > > BBFILE_PATTERN_meta-handheld := "^${LAYERDIR}/" > > I was all set to apply this now (sorry for the delay) and then I noticed you > changed the above without comment - why was that? Just to match what other layers do, or is there some advantage of using := instead of += in BBFILES? Cheers, -- Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 205 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [meta-handheld][PATCH] meta-handheld: append to BBPATH instead of prepend so order of bblayers.conf is respected 2012-06-16 19:37 ` Martin Jansa @ 2012-06-16 19:40 ` Martin Jansa 2012-06-17 20:54 ` Paul Eggleton 0 siblings, 1 reply; 6+ messages in thread From: Martin Jansa @ 2012-06-16 19:40 UTC (permalink / raw) To: Paul Eggleton; +Cc: openembedded-devel [-- Attachment #1: Type: text/plain, Size: 1884 bytes --] On Sat, Jun 16, 2012 at 09:37:56PM +0200, Martin Jansa wrote: > On Sat, Jun 16, 2012 at 08:28:28PM +0100, Paul Eggleton wrote: > > On Saturday 16 June 2012 09:01:17 Martin Jansa wrote: > > > On Wed, May 23, 2012 at 05:50:37PM +0200, Martin Jansa wrote: > > > > Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com> > > > > > > ping > > > > > > > --- > > > > > > > > conf/layer.conf | 11 ++++++++--- > > > > 1 files changed, 8 insertions(+), 3 deletions(-) > > > > > > > > diff --git a/conf/layer.conf b/conf/layer.conf > > > > index 7a2441b..31dcb16 100644 > > > > --- a/conf/layer.conf > > > > +++ b/conf/layer.conf > > > > @@ -1,13 +1,18 @@ > > > > > > > > # Layer configuration for meta-handheld layer > > > > # Copyright 2011 Intel Corporation > > > > > > > > -# We have a conf and classes directory, prepend to BBPATH to prefer our > > > > versions -BBPATH := "${LAYERDIR}:${BBPATH}" > > > > +# We have a conf and classes directory, append to BBPATH > > > > +BBPATH .= ":${LAYERDIR}" > > > > > > > > # We have a recipes directory, add to BBFILES > > > > > > > > -BBFILES := "${BBFILES} ${LAYERDIR}/recipes-*/*/*.bb > > > > ${LAYERDIR}/recipes-*/*/*.bbappend" > > > > +BBFILES += > > > > "${LAYERDIR}/recipes-*/*/*.bb ${LAYERDIR}/recipes-*/*/*.bbappend"> > > > > BBFILE_COLLECTIONS += "meta-handheld" > > > > BBFILE_PATTERN_meta-handheld := "^${LAYERDIR}/" > > > > I was all set to apply this now (sorry for the delay) and then I noticed you > > changed the above without comment - why was that? > > Just to match what other layers do, or is there some advantage of using > := instead of += in BBFILES? And IIRC there was some discussion about BBFILES :=/+= on ML before ba31e4eabd31af63eb0244096c8bcdcac185fac6 changed it in other layers. Cheers, -- Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 205 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [meta-handheld][PATCH] meta-handheld: append to BBPATH instead of prepend so order of bblayers.conf is respected 2012-06-16 19:40 ` Martin Jansa @ 2012-06-17 20:54 ` Paul Eggleton 0 siblings, 0 replies; 6+ messages in thread From: Paul Eggleton @ 2012-06-17 20:54 UTC (permalink / raw) To: Martin Jansa; +Cc: openembedded-devel On Saturday 16 June 2012 21:40:18 Martin Jansa wrote: > On Sat, Jun 16, 2012 at 09:37:56PM +0200, Martin Jansa wrote: > > On Sat, Jun 16, 2012 at 08:28:28PM +0100, Paul Eggleton wrote: > > > On Saturday 16 June 2012 09:01:17 Martin Jansa wrote: > > > > On Wed, May 23, 2012 at 05:50:37PM +0200, Martin Jansa wrote: > > > > > Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com> > > > > > > > > ping > > > > > > > > > --- > > > > > > > > > > conf/layer.conf | 11 ++++++++--- > > > > > 1 files changed, 8 insertions(+), 3 deletions(-) > > > > > > > > > > diff --git a/conf/layer.conf b/conf/layer.conf > > > > > index 7a2441b..31dcb16 100644 > > > > > --- a/conf/layer.conf > > > > > +++ b/conf/layer.conf > > > > > @@ -1,13 +1,18 @@ > > > > > > > > > > # Layer configuration for meta-handheld layer > > > > > # Copyright 2011 Intel Corporation > > > > > > > > > > -# We have a conf and classes directory, prepend to BBPATH to prefer > > > > > our > > > > > versions -BBPATH := "${LAYERDIR}:${BBPATH}" > > > > > +# We have a conf and classes directory, append to BBPATH > > > > > +BBPATH .= ":${LAYERDIR}" > > > > > > > > > > # We have a recipes directory, add to BBFILES > > > > > > > > > > -BBFILES := "${BBFILES} ${LAYERDIR}/recipes-*/*/*.bb > > > > > ${LAYERDIR}/recipes-*/*/*.bbappend" > > > > > +BBFILES += > > > > > "${LAYERDIR}/recipes-*/*/*.bb ${LAYERDIR}/recipes-*/*/*.bbappend"> > > > > > > > > > > BBFILE_COLLECTIONS += "meta-handheld" > > > > > BBFILE_PATTERN_meta-handheld := "^${LAYERDIR}/" > > > > > > I was all set to apply this now (sorry for the delay) and then I noticed > > > you changed the above without comment - why was that? > > > > Just to match what other layers do, or is there some advantage of using > > > > := instead of += in BBFILES? > > And IIRC there was some discussion about BBFILES :=/+= on ML before > ba31e4eabd31af63eb0244096c8bcdcac185fac6 changed it in other layers. Hmm, I couldn't find that discussion, but it doesn't seem to behave any differently; but looking at BitBake's layer.conf handling code we explicitly expand the LAYERDIR reference immediately anyway, so immediate expansion (:=) doesn't do anything. I guess this means the += form is perhaps preferred since it makes what we are trying to do more obvious. Now I've understood the above I've merged this patch, thanks. Cheers, Paul -- Paul Eggleton Intel Open Source Technology Centre ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-06-17 21:05 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2012-05-23 15:50 [meta-handheld][PATCH] meta-handheld: append to BBPATH instead of prepend so order of bblayers.conf is respected Martin Jansa 2012-06-16 7:01 ` Martin Jansa 2012-06-16 19:28 ` Paul Eggleton 2012-06-16 19:37 ` Martin Jansa 2012-06-16 19:40 ` Martin Jansa 2012-06-17 20:54 ` Paul Eggleton
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.