All of lore.kernel.org
 help / color / mirror / Atom feed
From: aisheng.dong@codeaurora.org (aisheng.dong at codeaurora.org)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/4] arm64: add support for i.MX8M EVK board
Date: Thu, 25 Jan 2018 18:10:35 +0800	[thread overview]
Message-ID: <278bb44610b8a27826550732095aba03@codeaurora.org> (raw)
In-Reply-To: <20180123103931.GE27764@dragon>

On 2018-01-23 18:39, Shawn Guo wrote:
> On Wed, Jan 17, 2018 at 07:32:43PM +0100, Lucas Stach wrote:
> 
>> +	pinctrl_usdhc2_100mhz: usdhc2grp100mhz {
>> +		fsl,pins = <
>> +			MX8MQ_IOMUXC_SD2_CLK_USDHC2_CLK			0x85
>> +			MX8MQ_IOMUXC_SD2_CMD_USDHC2_CMD			0xc5
>> +			MX8MQ_IOMUXC_SD2_DATA0_USDHC2_DATA0		0xc5
>> +			MX8MQ_IOMUXC_SD2_DATA1_USDHC2_DATA1		0xc5
>> +			MX8MQ_IOMUXC_SD2_DATA2_USDHC2_DATA2		0xc5
>> +			MX8MQ_IOMUXC_SD2_DATA3_USDHC2_DATA3		0xc5
>> +			MX8MQ_IOMUXC_GPIO1_IO04_USDHC2_VSELECT		0xc1
>> +		>;
>> +		};
> 
> Bad indentation.
> 
> Shawn
> 
>> +
>> +	pinctrl_usdhc2_200mhz: usdhc2grp200mhz {
>> +		fsl,pins = <
>> +			MX8MQ_IOMUXC_SD2_CLK_USDHC2_CLK			0x87
>> +			MX8MQ_IOMUXC_SD2_CMD_USDHC2_CMD			0xc7
>> +			MX8MQ_IOMUXC_SD2_DATA0_USDHC2_DATA0		0xc7
>> +			MX8MQ_IOMUXC_SD2_DATA1_USDHC2_DATA1		0xc7
>> +			MX8MQ_IOMUXC_SD2_DATA2_USDHC2_DATA2		0xc7
>> +			MX8MQ_IOMUXC_SD2_DATA3_USDHC2_DATA3		0xc7
>> +			MX8MQ_IOMUXC_GPIO1_IO04_USDHC2_VSELECT		0xc1
>> +		>;
>> +	};

AFAIK we switched to generic pinconfig since MX7ULP as maintainer won't
access old binding pinctrl drivers.

So i wonder if you may have some special reasons to insist on old 
binding which
i may overlooked?

(I did not receive your pinctrl patch by accidently. So i can't reply on
it before.)

Regards
Dong Aisheng

>> +};
>> --
>> 2.11.0
>> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: aisheng.dong-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org
To: Shawn Guo <shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Lucas Stach <l.stach-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
	Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Catalin Marinas <catalin.marinas-5wv7dgnIgG8@public.gmane.org>,
	Will Deacon <will.deacon-5wv7dgnIgG8@public.gmane.org>,
	patchwork-lst-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org,
	Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org,
	Fabio Estevam <fabio.estevam-3arQi8VN3Tc@public.gmane.org>,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	aisheng.dong-3arQi8VN3Tc@public.gmane.org,
	linux-imx-3arQi8VN3Tc@public.gmane.org
Subject: Re: [PATCH 3/4] arm64: add support for i.MX8M EVK board
Date: Thu, 25 Jan 2018 18:10:35 +0800	[thread overview]
Message-ID: <278bb44610b8a27826550732095aba03@codeaurora.org> (raw)
In-Reply-To: <20180123103931.GE27764@dragon>

On 2018-01-23 18:39, Shawn Guo wrote:
> On Wed, Jan 17, 2018 at 07:32:43PM +0100, Lucas Stach wrote:
> 
>> +	pinctrl_usdhc2_100mhz: usdhc2grp100mhz {
>> +		fsl,pins = <
>> +			MX8MQ_IOMUXC_SD2_CLK_USDHC2_CLK			0x85
>> +			MX8MQ_IOMUXC_SD2_CMD_USDHC2_CMD			0xc5
>> +			MX8MQ_IOMUXC_SD2_DATA0_USDHC2_DATA0		0xc5
>> +			MX8MQ_IOMUXC_SD2_DATA1_USDHC2_DATA1		0xc5
>> +			MX8MQ_IOMUXC_SD2_DATA2_USDHC2_DATA2		0xc5
>> +			MX8MQ_IOMUXC_SD2_DATA3_USDHC2_DATA3		0xc5
>> +			MX8MQ_IOMUXC_GPIO1_IO04_USDHC2_VSELECT		0xc1
>> +		>;
>> +		};
> 
> Bad indentation.
> 
> Shawn
> 
>> +
>> +	pinctrl_usdhc2_200mhz: usdhc2grp200mhz {
>> +		fsl,pins = <
>> +			MX8MQ_IOMUXC_SD2_CLK_USDHC2_CLK			0x87
>> +			MX8MQ_IOMUXC_SD2_CMD_USDHC2_CMD			0xc7
>> +			MX8MQ_IOMUXC_SD2_DATA0_USDHC2_DATA0		0xc7
>> +			MX8MQ_IOMUXC_SD2_DATA1_USDHC2_DATA1		0xc7
>> +			MX8MQ_IOMUXC_SD2_DATA2_USDHC2_DATA2		0xc7
>> +			MX8MQ_IOMUXC_SD2_DATA3_USDHC2_DATA3		0xc7
>> +			MX8MQ_IOMUXC_GPIO1_IO04_USDHC2_VSELECT		0xc1
>> +		>;
>> +	};

AFAIK we switched to generic pinconfig since MX7ULP as maintainer won't
access old binding pinctrl drivers.

So i wonder if you may have some special reasons to insist on old 
binding which
i may overlooked?

(I did not receive your pinctrl patch by accidently. So i can't reply on
it before.)

Regards
Dong Aisheng

>> +};
>> --
>> 2.11.0
>> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2018-01-25 10:10 UTC|newest]

Thread overview: 69+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-17 18:32 [PATCH 1/4] ARM64: add basic Kconfig symbols for i.MX8 Lucas Stach
2018-01-17 18:32 ` Lucas Stach
2018-01-17 18:32 ` [PATCH 2/4] arm64: add basic DTS for i.MX8MQ Lucas Stach
2018-01-17 18:32   ` Lucas Stach
2018-01-22 11:51   ` Arnd Bergmann
2018-01-22 11:51     ` Arnd Bergmann
2018-01-22 11:51     ` Arnd Bergmann
2018-01-22 11:57   ` Fabio Estevam
2018-01-22 11:57     ` Fabio Estevam
2018-01-22 14:47   ` Shawn Guo
2018-01-22 14:47     ` Shawn Guo
2018-01-22 15:11     ` Arnd Bergmann
2018-01-22 15:11       ` Arnd Bergmann
2018-01-22 17:50       ` Lucas Stach
2018-01-22 17:50         ` Lucas Stach
2018-01-23  1:40         ` Shawn Guo
2018-01-23  1:40           ` Shawn Guo
2018-01-23 10:36   ` Shawn Guo
2018-01-23 10:36     ` Shawn Guo
2018-01-23 13:23     ` Lucas Stach
2018-01-23 13:23       ` Lucas Stach
2018-01-25  9:48       ` aisheng.dong at codeaurora.org
2018-01-25  9:48         ` aisheng.dong-sgV2jX0FEOL9JmXXK+q4OQ
2018-01-25 10:27         ` Lucas Stach
2018-01-25 10:27           ` Lucas Stach
2018-01-25 12:34           ` Dong Aisheng
2018-01-25 12:34             ` Dong Aisheng
2018-02-02  7:27         ` Shawn Guo
2018-02-02  7:27           ` Shawn Guo
2018-01-29 17:45   ` Rob Herring
2018-01-29 17:45     ` Rob Herring
2018-01-29 17:55   ` Rob Herring
2018-01-29 17:55     ` Rob Herring
2018-01-29 18:00     ` Lucas Stach
2018-01-29 18:00       ` Lucas Stach
2018-01-30 14:55       ` Rob Herring
2018-01-30 14:55         ` Rob Herring
2018-01-17 18:32 ` [PATCH 3/4] arm64: add support for i.MX8M EVK board Lucas Stach
2018-01-17 18:32   ` Lucas Stach
2018-01-22 11:58   ` Fabio Estevam
2018-01-22 11:58     ` Fabio Estevam
2018-01-23 10:39   ` Shawn Guo
2018-01-23 10:39     ` Shawn Guo
2018-01-25 10:10     ` aisheng.dong at codeaurora.org [this message]
2018-01-25 10:10       ` aisheng.dong-sgV2jX0FEOL9JmXXK+q4OQ
2018-01-25 10:31       ` Lucas Stach
2018-01-25 10:31         ` Lucas Stach
2018-01-25 10:49         ` Dong Aisheng
2018-01-25 10:49           ` Dong Aisheng
2018-01-25 11:09           ` Lucas Stach
2018-01-25 11:09             ` Lucas Stach
2018-01-25 13:03             ` Dong Aisheng
2018-01-25 13:03               ` Dong Aisheng
2018-01-25 18:03               ` Lucas Stach
2018-01-25 18:03                 ` Lucas Stach
2018-01-26  3:06                 ` A.s. Dong
2018-01-26  3:06                   ` A.s. Dong
2018-01-24 14:47   ` Baruch Siach
2018-01-24 14:47     ` Baruch Siach
2018-01-25  9:52     ` Baruch Siach
2018-01-25  9:52       ` Baruch Siach
2018-01-29 17:52   ` Rob Herring
2018-01-29 17:52     ` Rob Herring
2018-01-17 18:32 ` [PATCH 4/4] MAINTAINERS: add i.MX8 DT path to i.MX architecture Lucas Stach
2018-01-17 18:32   ` Lucas Stach
2018-01-22 11:58   ` Fabio Estevam
2018-01-22 11:58     ` Fabio Estevam
2018-01-22 11:53 ` [PATCH 1/4] ARM64: add basic Kconfig symbols for i.MX8 Fabio Estevam
2018-01-22 11:53   ` Fabio Estevam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=278bb44610b8a27826550732095aba03@codeaurora.org \
    --to=aisheng.dong@codeaurora.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.