All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: linus.walleij@linaro.org, linux-sh@vger.kernel.org,
	linux-gpio@vger.kernel.org, robh+dt@kernel.org,
	pawel.moll@arm.com, mark.rutland@arm.com,
	ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
	devicetree@vger.kernel.org
Subject: Re: [PATCH v3] sh-pfc: add R8A7794 PFC support
Date: Mon, 23 Feb 2015 00:39:05 +0200	[thread overview]
Message-ID: <2862970.IP6dNCPzfj@avalon> (raw)
In-Reply-To: <2084538.pWCX8EzoLe@wasted.cogentembedded.com>

Hi Sergei,

Thank you for the patch.

On Monday 23 February 2015 00:33:38 Sergei Shtylyov wrote:
> From: Hisashi Nakamura <hisashi.nakamura.ak@renesas.com>
> 
> Add PFC support for  the  R8A7794 SoC  including pin groups for some on-chip
> devices such as ETH, I2C, INTC, MSIOF, QSPI, [H]SCIF...
> 
> Signed-off-by: Hisashi Nakamura <hisashi.nakamura.ak@renesas.com>
> [Sergei: squashed together several patches, fixed the MLB_CLK typo, added
> IRQ4.. IRQ9 pin groups,  fixed IRQn comments, added ETH B pin group names,
> removed stray new line and fixed typos in the  comments in the
> pinmux_config_regs[] initializer, removed the platform device ID, took into
> account limited number of signals in the GPIO1/5/6 controllers, added
> reasonable and removed unreasonable copyrights, modified the bindings
> document, renamed, added changelog.] Signed-off-by: Sergei Shtylyov
> <sergei.shtylyov@cogentembedded.com>

Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
> Changes in version 3:
> - removed the platform device ID;
> - added PORT_GP_26() and PORT_GP_28() macros, used them for GPIO1/5/6 in the
> CPU_ALL_PORT() macto.
> 
> Changes in version 2:
> - rebased the patch.
> 
>  Documentation/devicetree/bindings/pinctrl/renesas,pfc-pinctrl.txt |    1 
>  drivers/pinctrl/sh-pfc/Kconfig                                    |    5 
>  drivers/pinctrl/sh-pfc/Makefile                                   |    1 
>  drivers/pinctrl/sh-pfc/core.c                                     |    6 
>  drivers/pinctrl/sh-pfc/core.h                                     |    1 
>  drivers/pinctrl/sh-pfc/pfc-r8a7794.c                              | 4020 ++
>  6 files changed, 4034 insertions(+)

-- 
Regards,

Laurent Pinchart


WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: linus.walleij@linaro.org, linux-sh@vger.kernel.org,
	linux-gpio@vger.kernel.org, robh+dt@kernel.org,
	pawel.moll@arm.com, mark.rutland@arm.com,
	ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
	devicetree@vger.kernel.org
Subject: Re: [PATCH v3] sh-pfc: add R8A7794 PFC support
Date: Sun, 22 Feb 2015 22:39:05 +0000	[thread overview]
Message-ID: <2862970.IP6dNCPzfj@avalon> (raw)
In-Reply-To: <2084538.pWCX8EzoLe@wasted.cogentembedded.com>

Hi Sergei,

Thank you for the patch.

On Monday 23 February 2015 00:33:38 Sergei Shtylyov wrote:
> From: Hisashi Nakamura <hisashi.nakamura.ak@renesas.com>
> 
> Add PFC support for  the  R8A7794 SoC  including pin groups for some on-chip
> devices such as ETH, I2C, INTC, MSIOF, QSPI, [H]SCIF...
> 
> Signed-off-by: Hisashi Nakamura <hisashi.nakamura.ak@renesas.com>
> [Sergei: squashed together several patches, fixed the MLB_CLK typo, added
> IRQ4.. IRQ9 pin groups,  fixed IRQn comments, added ETH B pin group names,
> removed stray new line and fixed typos in the  comments in the
> pinmux_config_regs[] initializer, removed the platform device ID, took into
> account limited number of signals in the GPIO1/5/6 controllers, added
> reasonable and removed unreasonable copyrights, modified the bindings
> document, renamed, added changelog.] Signed-off-by: Sergei Shtylyov
> <sergei.shtylyov@cogentembedded.com>

Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
> Changes in version 3:
> - removed the platform device ID;
> - added PORT_GP_26() and PORT_GP_28() macros, used them for GPIO1/5/6 in the
> CPU_ALL_PORT() macto.
> 
> Changes in version 2:
> - rebased the patch.
> 
>  Documentation/devicetree/bindings/pinctrl/renesas,pfc-pinctrl.txt |    1 
>  drivers/pinctrl/sh-pfc/Kconfig                                    |    5 
>  drivers/pinctrl/sh-pfc/Makefile                                   |    1 
>  drivers/pinctrl/sh-pfc/core.c                                     |    6 
>  drivers/pinctrl/sh-pfc/core.h                                     |    1 
>  drivers/pinctrl/sh-pfc/pfc-r8a7794.c                              | 4020 ++
>  6 files changed, 4034 insertions(+)

-- 
Regards,

Laurent Pinchart


  reply	other threads:[~2015-02-22 22:38 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-22 21:33 [PATCH v3] sh-pfc: add R8A7794 PFC support Sergei Shtylyov
2015-02-22 22:39 ` Laurent Pinchart [this message]
2015-02-22 22:39   ` Laurent Pinchart
2015-02-25 20:03 ` Sergei Shtylyov
2015-02-25 20:03   ` Sergei Shtylyov
2015-02-25 23:06   ` Sergei Shtylyov
2015-02-25 23:06     ` Sergei Shtylyov
2015-03-06 10:34 ` Linus Walleij
2015-03-06 10:34   ` Linus Walleij
2015-03-06 12:44   ` Sergei Shtylyov
2015-03-06 12:44     ` Sergei Shtylyov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2862970.IP6dNCPzfj@avalon \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=sergei.shtylyov@cogentembedded.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.