From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: linus.walleij@linaro.org, linux-sh@vger.kernel.org,
laurent.pinchart@ideasonboard.com, linux-gpio@vger.kernel.org
Cc: robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v3] sh-pfc: add R8A7794 PFC support
Date: Thu, 26 Feb 2015 02:06:54 +0300 [thread overview]
Message-ID: <54EE558E.2020507@cogentembedded.com> (raw)
In-Reply-To: <54EE2AA8.9000604@cogentembedded.com>
On 02/25/2015 11:03 PM, Sergei Shtylyov wrote:
>> From: Hisashi Nakamura <hisashi.nakamura.ak@renesas.com>
>> Add PFC support for the R8A7794 SoC including pin groups for some on-chip
>> devices such as ETH, I2C, INTC, MSIOF, QSPI, [H]SCIF...
>> Signed-off-by: Hisashi Nakamura <hisashi.nakamura.ak@renesas.com>
>> [Sergei: squashed together several patches, fixed the MLB_CLK typo, added
>> IRQ4..
>> IRQ9 pin groups, fixed IRQn comments, added ETH B pin group names, removed
>> stray new line and fixed typos in the comments in the pinmux_config_regs[]
>> initializer, removed the platform device ID, took into account limited
>> number of
>> signals in the GPIO1/5/6 controllers, added reasonable and removed unreasonable
>> copyrights, modified the bindings document, renamed, added changelog.]
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>
>> ---
>> Changes in version 3:
>> - removed the platform device ID;
>> - added PORT_GP_26() and PORT_GP_28() macros, used them for GPIO1/5/6 in the
>> CPU_ALL_PORT() macto.
> Don't apply this patch! The change above causes the driver to fail probing
> and the eventual kernel hang somehow... :-(
OK, I think I fixed it now. But I'm going to submit the new version of
this patch after that, in order to reuse PORT_GP_26() when defining
PORT_GP_28()...
>> Changes in version 2:
>> - rebased the patch.
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: linus.walleij@linaro.org, linux-sh@vger.kernel.org,
laurent.pinchart@ideasonboard.com, linux-gpio@vger.kernel.org
Cc: robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v3] sh-pfc: add R8A7794 PFC support
Date: Wed, 25 Feb 2015 23:06:54 +0000 [thread overview]
Message-ID: <54EE558E.2020507@cogentembedded.com> (raw)
In-Reply-To: <54EE2AA8.9000604@cogentembedded.com>
On 02/25/2015 11:03 PM, Sergei Shtylyov wrote:
>> From: Hisashi Nakamura <hisashi.nakamura.ak@renesas.com>
>> Add PFC support for the R8A7794 SoC including pin groups for some on-chip
>> devices such as ETH, I2C, INTC, MSIOF, QSPI, [H]SCIF...
>> Signed-off-by: Hisashi Nakamura <hisashi.nakamura.ak@renesas.com>
>> [Sergei: squashed together several patches, fixed the MLB_CLK typo, added
>> IRQ4..
>> IRQ9 pin groups, fixed IRQn comments, added ETH B pin group names, removed
>> stray new line and fixed typos in the comments in the pinmux_config_regs[]
>> initializer, removed the platform device ID, took into account limited
>> number of
>> signals in the GPIO1/5/6 controllers, added reasonable and removed unreasonable
>> copyrights, modified the bindings document, renamed, added changelog.]
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>
>> ---
>> Changes in version 3:
>> - removed the platform device ID;
>> - added PORT_GP_26() and PORT_GP_28() macros, used them for GPIO1/5/6 in the
>> CPU_ALL_PORT() macto.
> Don't apply this patch! The change above causes the driver to fail probing
> and the eventual kernel hang somehow... :-(
OK, I think I fixed it now. But I'm going to submit the new version of
this patch after that, in order to reuse PORT_GP_26() when defining
PORT_GP_28()...
>> Changes in version 2:
>> - rebased the patch.
WBR, Sergei
next prev parent reply other threads:[~2015-02-25 23:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-22 21:33 [PATCH v3] sh-pfc: add R8A7794 PFC support Sergei Shtylyov
2015-02-22 22:39 ` Laurent Pinchart
2015-02-22 22:39 ` Laurent Pinchart
2015-02-25 20:03 ` Sergei Shtylyov
2015-02-25 20:03 ` Sergei Shtylyov
2015-02-25 23:06 ` Sergei Shtylyov [this message]
2015-02-25 23:06 ` Sergei Shtylyov
2015-03-06 10:34 ` Linus Walleij
2015-03-06 10:34 ` Linus Walleij
2015-03-06 12:44 ` Sergei Shtylyov
2015-03-06 12:44 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54EE558E.2020507@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.