All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nish Aravamudan <nish.aravamudan@gmail.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ] [PATCH] arch/i386/kernel/acpi/boot.c
Date: Sat, 26 Feb 2005 05:43:35 +0000	[thread overview]
Message-ID: <29495f1d05022521431b33dcea@mail.gmail.com> (raw)
In-Reply-To: <7a4211f805022518082a5c12a4@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1424 bytes --]

On Fri, 25 Feb 2005 21:08:47 -0500, Jonathan Stafford
<thecabinet@gmail.com> wrote:
> I've never done any kernel work before, but the gcc 4 warning fixes
> seems like a fairly easy place to start.  As there will ultimately be
> several hundred patches, is there are particular order to fix these?
> I've been tinkering with them simply in compiled order.
> 
> Should I be sending/cc'ing these patches to somewhere besides KJML as
> I write them?  I know that many of the various parts have their own
> mailings lists, but I don't begin to know what all of them are.  What
> about trivial patch monkey?

For these, it may be useful to directly paste the warning you are
fixing rather than referencing a URL. Or at least be a little more
detailed as why gcc 4 complains, so that more experienced devs may be
able to comment directly on the gcc 4 changes.

As far as knowing subsystem lists, just go by MAINTAINERS (it's in the
root dir of kernel source).

> Here's my first would-be patch; anything I should change?

At least in reply, it looks like spaces became tabs, but maybe that is
just GMail's reply. I am just surprised you were able to get GMail to
protect tabs. You were able to apply the inlined patch on your system
(the one from the E-mail, not necessarily the only you inlined).

I haven't messed with gcc 4, but I can trust your ability to read
warnings and correct them intelligently :) Seems ok to me.

-Nish

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

  reply	other threads:[~2005-02-26  5:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-02-26  2:08 [KJ] [PATCH] arch/i386/kernel/acpi/boot.c Jonathan Stafford
2005-02-26  5:43 ` Nish Aravamudan [this message]
2005-02-27 16:04 ` walter harms

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=29495f1d05022521431b33dcea@mail.gmail.com \
    --to=nish.aravamudan@gmail.com \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.