All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Stafford <thecabinet@gmail.com>
To: kernel-janitors@vger.kernel.org
Subject: [KJ] [PATCH] arch/i386/kernel/acpi/boot.c
Date: Sat, 26 Feb 2005 02:08:47 +0000	[thread overview]
Message-ID: <7a4211f805022518082a5c12a4@mail.gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 1164 bytes --]

I've never done any kernel work before, but the gcc 4 warning fixes
seems like a fairly easy place to start.  As there will ultimately be
several hundred patches, is there are particular order to fix these?
I've been tinkering with them simply in compiled order.

Should I be sending/cc'ing these patches to somewhere besides KJML as
I write them?  I know that many of the various parts have their own
mailings lists, but I don't begin to know what all of them are.  What
about trivial patch monkey?

Thanks,
jonathan

Here's my first would-be patch; anything I should change?
==============================================

Description: Fixes gcc 4 warnings.  See
http://marc.theaimsgroup.com/?t=110348353800003 for details

Signed-off-by: Jonathan Stafford <thecabinet@gmail.com>

diff -Nru a/arch/i386/kernel/acpi/boot.c b/arch/i386/kernel/acpi/boot.c
--- a/arch/i386/kernel/acpi/boot.c      2005-02-24 04:36:13 -05:00
+++ b/arch/i386/kernel/acpi/boot.c      2005-02-24 04:36:13 -05:00
@@ -153,7 +153,7 @@
                mapped_size += PAGE_SIZE;
        }

-       return ((unsigned char *) base + offset);
+       return ((char *) base + offset);
 }
 #endif

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

             reply	other threads:[~2005-02-26  2:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-02-26  2:08 Jonathan Stafford [this message]
2005-02-26  5:43 ` [KJ] [PATCH] arch/i386/kernel/acpi/boot.c Nish Aravamudan
2005-02-27 16:04 ` walter harms

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7a4211f805022518082a5c12a4@mail.gmail.com \
    --to=thecabinet@gmail.com \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.