Re: [KJ] [PATCH] arch/i386/kernel/acpi/boot.c

[walter harms <wharms@bfs.de>]

[-- Attachment #1: Type: text/plain, Size: 1891 bytes --]


hi Jonathan,
the complain of ggc4 is correct. defining char and returning unsigned 
char is wrong. but i would exspect a void * here as a quick look at 
boot.c says that the result is always casted to some other struct foo *.

I am not an expert on that can someone please comment it ?


I found also no references outside boot.c perhaps 'static' is usefull here ?


re,
	walter



Jonathan Stafford wrote:
> I've never done any kernel work before, but the gcc 4 warning fixes
> seems like a fairly easy place to start.  As there will ultimately be
> several hundred patches, is there are particular order to fix these?
> I've been tinkering with them simply in compiled order.
> 
> Should I be sending/cc'ing these patches to somewhere besides KJML as
> I write them?  I know that many of the various parts have their own
> mailings lists, but I don't begin to know what all of them are.  What
> about trivial patch monkey?
> 
> Thanks,
> jonathan
> 
> Here's my first would-be patch; anything I should change?
> ==============================================
> 
> Description: Fixes gcc 4 warnings.  See
> http://marc.theaimsgroup.com/?t=110348353800003 for details
> 
> Signed-off-by: Jonathan Stafford <thecabinet@gmail.com>
> 
> diff -Nru a/arch/i386/kernel/acpi/boot.c b/arch/i386/kernel/acpi/boot.c
> --- a/arch/i386/kernel/acpi/boot.c      2005-02-24 04:36:13 -05:00
> +++ b/arch/i386/kernel/acpi/boot.c      2005-02-24 04:36:13 -05:00
> @@ -153,7 +153,7 @@
>                 mapped_size += PAGE_SIZE;
>         }
> 
> -       return ((unsigned char *) base + offset);
> +       return ((char *) base + offset);
>  }
>  #endif
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> Kernel-janitors mailing list
> Kernel-janitors@lists.osdl.org
> http://lists.osdl.org/mailman/listinfo/kernel-janitors

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors