All of lore.kernel.org
 help / color / mirror / Atom feed
From: Florian Fainelli <f.fainelli@gmail.com>
To: justinpopo6@gmail.com, alcooperx@gmail.com, kishon@ti.com,
	vkoul@kernel.org, f.fainelli@gmail.com,
	linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org
Cc: bcm-kernel-feedback-list@broadcom.com
Subject: Re: [PATCH 1/6] phy: usb: Improve port mode selection
Date: Thu, 6 Oct 2022 15:05:30 -0700	[thread overview]
Message-ID: <29803905-d0e2-3efb-e249-fd745f9abcf0@gmail.com> (raw)
In-Reply-To: <1665005418-15807-2-git-send-email-justinpopo6@gmail.com>



On 10/5/2022 2:30 PM, justinpopo6@gmail.com wrote:
> From: Justin Chen <justinpopo6@gmail.com>
> 
> Split port modes into two different variables. Supported port modes
> is what the hardware supports. While port mode is how the hardware
> is currently configured and can be dynamically changed through the
> sysfs. We initialize all supported port modes on init even though
> the port mode may not be selected because we cannot guarantee the
> downstream interface from the phy will be active or not.
> 
> This also fixes an issue where port modes selected via sysfs were
> not being saved through suspend/resume.
> 
> Signed-off-by: Justin Chen <justinpopo6@gmail.com>

Acked-by: Florian Fainelli <f.fainelli@gmail.com>
-- 
Florian

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

WARNING: multiple messages have this Message-ID (diff)
From: Florian Fainelli <f.fainelli@gmail.com>
To: justinpopo6@gmail.com, alcooperx@gmail.com, kishon@ti.com,
	vkoul@kernel.org, f.fainelli@gmail.com,
	linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org
Cc: bcm-kernel-feedback-list@broadcom.com
Subject: Re: [PATCH 1/6] phy: usb: Improve port mode selection
Date: Thu, 6 Oct 2022 15:05:30 -0700	[thread overview]
Message-ID: <29803905-d0e2-3efb-e249-fd745f9abcf0@gmail.com> (raw)
In-Reply-To: <1665005418-15807-2-git-send-email-justinpopo6@gmail.com>



On 10/5/2022 2:30 PM, justinpopo6@gmail.com wrote:
> From: Justin Chen <justinpopo6@gmail.com>
> 
> Split port modes into two different variables. Supported port modes
> is what the hardware supports. While port mode is how the hardware
> is currently configured and can be dynamically changed through the
> sysfs. We initialize all supported port modes on init even though
> the port mode may not be selected because we cannot guarantee the
> downstream interface from the phy will be active or not.
> 
> This also fixes an issue where port modes selected via sysfs were
> not being saved through suspend/resume.
> 
> Signed-off-by: Justin Chen <justinpopo6@gmail.com>

Acked-by: Florian Fainelli <f.fainelli@gmail.com>
-- 
Florian

  reply	other threads:[~2022-10-06 22:05 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-05 21:30 [PATCH 0/6] Various bug fixes/improvements for phy-brcm-usb driver justinpopo6
2022-10-05 21:30 ` justinpopo6
2022-10-05 21:30 ` [PATCH 1/6] phy: usb: Improve port mode selection justinpopo6
2022-10-05 21:30   ` justinpopo6
2022-10-06 22:05   ` Florian Fainelli [this message]
2022-10-06 22:05     ` Florian Fainelli
2022-10-05 21:30 ` [PATCH 2/6] phy: usb: s2 WoL wakeup_count not incremented for USB->Eth devices justinpopo6
2022-10-05 21:30   ` justinpopo6
2022-10-06 22:05   ` Florian Fainelli
2022-10-06 22:05     ` Florian Fainelli
2022-10-05 21:30 ` [PATCH 3/6] phy: usb: Migrate to BIT and BITMASK macros justinpopo6
2022-10-05 21:30   ` justinpopo6
2022-10-06 22:07   ` Florian Fainelli
2022-10-06 22:07     ` Florian Fainelli
2022-10-05 21:30 ` [PATCH 4/6] phy: usb: Disable phy auto-suspend justinpopo6
2022-10-05 21:30   ` justinpopo6
2022-10-06 22:07   ` Florian Fainelli
2022-10-06 22:07     ` Florian Fainelli
2022-10-05 21:30 ` [PATCH 5/6] phy: usb: Use slow clock for wake enabled suspend justinpopo6
2022-10-05 21:30   ` justinpopo6
2022-10-06 22:07   ` Florian Fainelli
2022-10-06 22:07     ` Florian Fainelli
2022-10-05 21:30 ` [PATCH 6/6] phy: usb: Fix clock imbalance for suspend/resume justinpopo6
2022-10-05 21:30   ` justinpopo6
2022-10-06 22:08   ` Florian Fainelli
2022-10-06 22:08     ` Florian Fainelli
2022-11-01 17:40 ` [PATCH 0/6] Various bug fixes/improvements for phy-brcm-usb driver Justin Chen
2022-11-01 17:40   ` Justin Chen
2022-11-05  7:43 ` Vinod Koul
2022-11-05  7:43   ` Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=29803905-d0e2-3efb-e249-fd745f9abcf0@gmail.com \
    --to=f.fainelli@gmail.com \
    --cc=alcooperx@gmail.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=justinpopo6@gmail.com \
    --cc=kishon@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.