All of lore.kernel.org
 help / color / mirror / Atom feed
From: Florian Fainelli <florian.fainelli@broadcom.com>
To: justinpopo6@gmail.com, alcooperx@gmail.com, kishon@ti.com,
	vkoul@kernel.org, f.fainelli@gmail.com,
	linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org
Cc: bcm-kernel-feedback-list@broadcom.com
Subject: Re: [PATCH 4/6] phy: usb: Disable phy auto-suspend
Date: Thu, 6 Oct 2022 15:07:44 -0700	[thread overview]
Message-ID: <58cd45fe-e5e8-da2a-9b55-cd98797f870c@broadcom.com> (raw)
In-Reply-To: <1665005418-15807-5-git-send-email-justinpopo6@gmail.com>


[-- Attachment #1.1: Type: text/plain, Size: 524 bytes --]



On 10/5/2022 2:30 PM, justinpopo6@gmail.com wrote:
> From: Justin Chen <justinpopo6@gmail.com>
> 
> The BDC block requires the PLL lock in order to grab the PLL clock.
> The phy auto-suspend feature turns off the phy when nothing is attached
> leading to the PLL to not lock. This leads the BDC block to grab the AUX
> clock instead of the PLL clock. This is not ideal, so lets turn this
> feature off.
> 
> Signed-off-by: Justin Chen <justinpopo6@gmail.com>

Acked-by: Florian Fainelli <f.fainelli@gmail.com>
-- 
Florian

[-- Attachment #1.2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4221 bytes --]

[-- Attachment #2: Type: text/plain, Size: 112 bytes --]

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

WARNING: multiple messages have this Message-ID (diff)
From: Florian Fainelli <florian.fainelli@broadcom.com>
To: justinpopo6@gmail.com, alcooperx@gmail.com, kishon@ti.com,
	vkoul@kernel.org, f.fainelli@gmail.com,
	linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org
Cc: bcm-kernel-feedback-list@broadcom.com
Subject: Re: [PATCH 4/6] phy: usb: Disable phy auto-suspend
Date: Thu, 6 Oct 2022 15:07:44 -0700	[thread overview]
Message-ID: <58cd45fe-e5e8-da2a-9b55-cd98797f870c@broadcom.com> (raw)
In-Reply-To: <1665005418-15807-5-git-send-email-justinpopo6@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 524 bytes --]



On 10/5/2022 2:30 PM, justinpopo6@gmail.com wrote:
> From: Justin Chen <justinpopo6@gmail.com>
> 
> The BDC block requires the PLL lock in order to grab the PLL clock.
> The phy auto-suspend feature turns off the phy when nothing is attached
> leading to the PLL to not lock. This leads the BDC block to grab the AUX
> clock instead of the PLL clock. This is not ideal, so lets turn this
> feature off.
> 
> Signed-off-by: Justin Chen <justinpopo6@gmail.com>

Acked-by: Florian Fainelli <f.fainelli@gmail.com>
-- 
Florian

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4221 bytes --]

  reply	other threads:[~2022-10-06 22:07 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-05 21:30 [PATCH 0/6] Various bug fixes/improvements for phy-brcm-usb driver justinpopo6
2022-10-05 21:30 ` justinpopo6
2022-10-05 21:30 ` [PATCH 1/6] phy: usb: Improve port mode selection justinpopo6
2022-10-05 21:30   ` justinpopo6
2022-10-06 22:05   ` Florian Fainelli
2022-10-06 22:05     ` Florian Fainelli
2022-10-05 21:30 ` [PATCH 2/6] phy: usb: s2 WoL wakeup_count not incremented for USB->Eth devices justinpopo6
2022-10-05 21:30   ` justinpopo6
2022-10-06 22:05   ` Florian Fainelli
2022-10-06 22:05     ` Florian Fainelli
2022-10-05 21:30 ` [PATCH 3/6] phy: usb: Migrate to BIT and BITMASK macros justinpopo6
2022-10-05 21:30   ` justinpopo6
2022-10-06 22:07   ` Florian Fainelli
2022-10-06 22:07     ` Florian Fainelli
2022-10-05 21:30 ` [PATCH 4/6] phy: usb: Disable phy auto-suspend justinpopo6
2022-10-05 21:30   ` justinpopo6
2022-10-06 22:07   ` Florian Fainelli [this message]
2022-10-06 22:07     ` Florian Fainelli
2022-10-05 21:30 ` [PATCH 5/6] phy: usb: Use slow clock for wake enabled suspend justinpopo6
2022-10-05 21:30   ` justinpopo6
2022-10-06 22:07   ` Florian Fainelli
2022-10-06 22:07     ` Florian Fainelli
2022-10-05 21:30 ` [PATCH 6/6] phy: usb: Fix clock imbalance for suspend/resume justinpopo6
2022-10-05 21:30   ` justinpopo6
2022-10-06 22:08   ` Florian Fainelli
2022-10-06 22:08     ` Florian Fainelli
2022-11-01 17:40 ` [PATCH 0/6] Various bug fixes/improvements for phy-brcm-usb driver Justin Chen
2022-11-01 17:40   ` Justin Chen
2022-11-05  7:43 ` Vinod Koul
2022-11-05  7:43   ` Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=58cd45fe-e5e8-da2a-9b55-cd98797f870c@broadcom.com \
    --to=florian.fainelli@broadcom.com \
    --cc=alcooperx@gmail.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=f.fainelli@gmail.com \
    --cc=justinpopo6@gmail.com \
    --cc=kishon@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.