From: Dave Hansen <dave.hansen@linux.intel.com>
To: Khalid Aziz <khalid.aziz@oracle.com>,
akpm@linux-foundation.org, davem@davemloft.net
Cc: kstewart@linuxfoundation.org, pombredanne@nexb.com,
tglx@linutronix.de, anthony.yznaga@oracle.com,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, sparclinux@vger.kernel.org,
Khalid Aziz <khalid@gonehiking.org>
Subject: Re: [PATCH v12 09/11] mm: Allow arch code to override copy_highpage()
Date: Mon, 05 Mar 2018 20:56:52 +0000 [thread overview]
Message-ID: <2a558ec8-c46c-299e-2f14-bb33058cbd90@linux.intel.com> (raw)
In-Reply-To: <8b441f99-ee41-e113-f52d-dbe0573bf267@oracle.com>
On 03/05/2018 12:42 PM, Khalid Aziz wrote:
> On 03/05/2018 12:24 PM, Dave Hansen wrote:
>> On 02/21/2018 09:15 AM, Khalid Aziz wrote:
>>> +#ifndef __HAVE_ARCH_COPY_HIGHPAGE
>>> +
>>> static inline void copy_highpage(struct page *to, struct page *from)
>>> {
>>> char *vfrom, *vto;
>>> @@ -248,4 +250,6 @@ static inline void copy_highpage(struct page *to,
>>> struct page *from)
>>> kunmap_atomic(vfrom);
>>> }
>>> +#endif
>>
>> I think we prefer that these are CONFIG_* options.
>
> I added this mechanism to be same as what we have for copy_user_highpage():
>
> ---------------
> #ifndef __HAVE_ARCH_COPY_USER_HIGHPAGE
I think that's the old way that we generally don't want to add new
instances of.
WARNING: multiple messages have this Message-ID (diff)
From: Dave Hansen <dave.hansen@linux.intel.com>
To: Khalid Aziz <khalid.aziz@oracle.com>,
akpm@linux-foundation.org, davem@davemloft.net
Cc: kstewart@linuxfoundation.org, pombredanne@nexb.com,
tglx@linutronix.de, anthony.yznaga@oracle.com,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, sparclinux@vger.kernel.org,
Khalid Aziz <khalid@gonehiking.org>
Subject: Re: [PATCH v12 09/11] mm: Allow arch code to override copy_highpage()
Date: Mon, 5 Mar 2018 12:56:52 -0800 [thread overview]
Message-ID: <2a558ec8-c46c-299e-2f14-bb33058cbd90@linux.intel.com> (raw)
In-Reply-To: <8b441f99-ee41-e113-f52d-dbe0573bf267@oracle.com>
On 03/05/2018 12:42 PM, Khalid Aziz wrote:
> On 03/05/2018 12:24 PM, Dave Hansen wrote:
>> On 02/21/2018 09:15 AM, Khalid Aziz wrote:
>>> +#ifndef __HAVE_ARCH_COPY_HIGHPAGE
>>> +
>>> A static inline void copy_highpage(struct page *to, struct page *from)
>>> A {
>>> A A A A A char *vfrom, *vto;
>>> @@ -248,4 +250,6 @@ static inline void copy_highpage(struct page *to,
>>> struct page *from)
>>> A A A A A kunmap_atomic(vfrom);
>>> A }
>>> A +#endif
>>
>> I think we prefer that these are CONFIG_* options.
>
> I added this mechanism to be same as what we have for copy_user_highpage():
>
> ---------------
> #ifndef __HAVE_ARCH_COPY_USER_HIGHPAGE
I think that's the old way that we generally don't want to add new
instances of.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Dave Hansen <dave.hansen@linux.intel.com>
To: Khalid Aziz <khalid.aziz@oracle.com>,
akpm@linux-foundation.org, davem@davemloft.net
Cc: kstewart@linuxfoundation.org, pombredanne@nexb.com,
tglx@linutronix.de, anthony.yznaga@oracle.com,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, sparclinux@vger.kernel.org,
Khalid Aziz <khalid@gonehiking.org>
Subject: Re: [PATCH v12 09/11] mm: Allow arch code to override copy_highpage()
Date: Mon, 5 Mar 2018 12:56:52 -0800 [thread overview]
Message-ID: <2a558ec8-c46c-299e-2f14-bb33058cbd90@linux.intel.com> (raw)
In-Reply-To: <8b441f99-ee41-e113-f52d-dbe0573bf267@oracle.com>
On 03/05/2018 12:42 PM, Khalid Aziz wrote:
> On 03/05/2018 12:24 PM, Dave Hansen wrote:
>> On 02/21/2018 09:15 AM, Khalid Aziz wrote:
>>> +#ifndef __HAVE_ARCH_COPY_HIGHPAGE
>>> +
>>> static inline void copy_highpage(struct page *to, struct page *from)
>>> {
>>> char *vfrom, *vto;
>>> @@ -248,4 +250,6 @@ static inline void copy_highpage(struct page *to,
>>> struct page *from)
>>> kunmap_atomic(vfrom);
>>> }
>>> +#endif
>>
>> I think we prefer that these are CONFIG_* options.
>
> I added this mechanism to be same as what we have for copy_user_highpage():
>
> ---------------
> #ifndef __HAVE_ARCH_COPY_USER_HIGHPAGE
I think that's the old way that we generally don't want to add new
instances of.
next prev parent reply other threads:[~2018-03-05 20:56 UTC|newest]
Thread overview: 133+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-21 17:15 [PATCH v12 00/11] Application Data Integrity feature introduced by SPARC M7 Khalid Aziz
2018-02-21 17:15 ` Khalid Aziz
2018-02-21 17:15 ` Khalid Aziz
2018-02-21 17:15 ` Khalid Aziz
2018-02-21 17:15 ` [PATCH v12 01/11] signals, sparc: Add signal codes for ADI violations Khalid Aziz
2018-02-21 17:15 ` Khalid Aziz
2018-02-21 20:58 ` Eric W. Biederman
2018-02-21 20:58 ` Eric W. Biederman
2018-02-21 17:15 ` [PATCH v12 02/11] mm, swap: Add infrastructure for saving page metadata on swap Khalid Aziz
2018-02-21 17:15 ` Khalid Aziz
2018-02-21 17:15 ` Khalid Aziz
2018-03-05 19:20 ` Dave Hansen
2018-03-05 19:20 ` Dave Hansen
2018-03-05 19:20 ` Dave Hansen
2018-03-05 19:29 ` Khalid Aziz
2018-03-05 19:29 ` Khalid Aziz
2018-03-05 19:29 ` Khalid Aziz
2018-03-05 19:35 ` Dave Hansen
2018-03-05 19:35 ` Dave Hansen
2018-03-05 19:35 ` Dave Hansen
2018-03-05 20:28 ` Khalid Aziz
2018-03-05 20:28 ` Khalid Aziz
2018-03-05 20:28 ` Khalid Aziz
2018-03-05 21:04 ` Dave Hansen
2018-03-05 21:04 ` Dave Hansen
2018-03-05 21:04 ` Dave Hansen
2018-03-05 21:14 ` Khalid Aziz
2018-03-05 21:14 ` Khalid Aziz
2018-03-05 21:14 ` Khalid Aziz
2018-03-06 22:47 ` Andrew Morton
2018-03-06 22:47 ` Andrew Morton
2018-03-06 22:47 ` Andrew Morton
2018-02-21 17:15 ` [PATCH v12 03/11] sparc64: Add support for ADI register fields, ASIs and traps Khalid Aziz
2018-02-21 17:15 ` Khalid Aziz
2018-02-21 17:15 ` [PATCH v12 04/11] sparc64: Add HV fault type handlers for ADI related faults Khalid Aziz
2018-02-21 17:15 ` Khalid Aziz
2018-02-21 17:15 ` [PATCH v12 05/11] sparc64: Add handler for "Memory Corruption Detected" trap Khalid Aziz
2018-02-21 17:15 ` Khalid Aziz
2018-02-21 17:15 ` [PATCH v12 06/11] sparc64: Add auxiliary vectors to report platform ADI properties Khalid Aziz
2018-02-21 17:15 ` Khalid Aziz
2018-02-21 17:15 ` [PATCH v12 07/11] mm: Add address parameter to arch_validate_prot() Khalid Aziz
2018-02-21 17:15 ` Khalid Aziz
2018-02-21 17:15 ` Khalid Aziz
2018-02-26 5:54 ` Michael Ellerman
2018-02-26 5:54 ` Michael Ellerman
2018-02-26 5:54 ` Michael Ellerman
2018-03-06 22:48 ` Andrew Morton
2018-03-06 22:48 ` Andrew Morton
2018-03-06 22:48 ` Andrew Morton
2018-02-21 17:15 ` [PATCH v12 08/11] mm: Clear arch specific VM flags on protection change Khalid Aziz
2018-02-21 17:15 ` Khalid Aziz
2018-02-21 17:15 ` Khalid Aziz
2018-03-05 19:23 ` Dave Hansen
2018-03-05 19:23 ` Dave Hansen
2018-03-05 19:23 ` Dave Hansen
2018-03-05 20:38 ` Khalid Aziz
2018-03-05 20:38 ` Khalid Aziz
2018-03-05 20:38 ` Khalid Aziz
2018-03-06 22:48 ` Andrew Morton
2018-03-06 22:48 ` Andrew Morton
2018-03-06 22:48 ` Andrew Morton
2018-02-21 17:15 ` [PATCH v12 09/11] mm: Allow arch code to override copy_highpage() Khalid Aziz
2018-02-21 17:15 ` Khalid Aziz
2018-02-21 17:15 ` Khalid Aziz
2018-03-05 19:24 ` Dave Hansen
2018-03-05 19:24 ` Dave Hansen
2018-03-05 19:24 ` Dave Hansen
2018-03-05 20:42 ` Khalid Aziz
2018-03-05 20:42 ` Khalid Aziz
2018-03-05 20:42 ` Khalid Aziz
2018-03-05 20:56 ` Dave Hansen [this message]
2018-03-05 20:56 ` Dave Hansen
2018-03-05 20:56 ` Dave Hansen
2018-03-06 22:48 ` Andrew Morton
2018-03-06 22:48 ` Andrew Morton
2018-03-06 22:48 ` Andrew Morton
2018-02-21 17:15 ` [PATCH v12 10/11] sparc64: Add support for ADI (Application Data Integrity) Khalid Aziz
2018-02-21 17:15 ` Khalid Aziz
2018-02-21 17:15 ` Khalid Aziz
2018-02-23 2:50 ` kbuild test robot
2018-02-23 2:50 ` kbuild test robot
2018-02-23 2:50 ` kbuild test robot
2018-02-23 18:51 ` Khalid Aziz
2018-02-23 18:51 ` Khalid Aziz
2018-02-23 18:51 ` Khalid Aziz
2018-02-23 18:57 ` David Miller
2018-02-23 18:57 ` David Miller
2018-02-23 18:57 ` David Miller
2018-02-23 22:11 ` Khalid Aziz
2018-02-23 22:11 ` Khalid Aziz
2018-02-23 22:11 ` Khalid Aziz
2018-03-05 19:22 ` Dave Hansen
2018-03-05 19:22 ` Dave Hansen
2018-03-05 19:22 ` Dave Hansen
2018-03-05 19:22 ` Dave Hansen
2018-03-05 21:14 ` Khalid Aziz
2018-03-05 21:14 ` Khalid Aziz
2018-03-05 21:14 ` Khalid Aziz
2018-03-05 21:14 ` Khalid Aziz
2018-03-05 21:26 ` Dave Hansen
2018-03-05 21:26 ` Dave Hansen
2018-03-05 21:26 ` Dave Hansen
2018-03-05 21:26 ` Dave Hansen
2018-03-05 21:31 ` Dave Hansen
2018-03-05 21:31 ` Dave Hansen
2018-03-05 21:31 ` Dave Hansen
2018-03-05 21:31 ` Dave Hansen
2018-03-05 22:55 ` Khalid Aziz
2018-03-05 22:55 ` Khalid Aziz
2018-03-05 22:55 ` Khalid Aziz
2018-03-05 22:55 ` Khalid Aziz
2018-03-05 21:26 ` Dave Hansen
2018-03-05 21:26 ` Dave Hansen
2018-03-05 21:26 ` Dave Hansen
2018-03-05 21:26 ` Dave Hansen
2018-03-05 21:37 ` Khalid Aziz
2018-03-05 21:37 ` Khalid Aziz
2018-03-05 21:37 ` Khalid Aziz
2018-03-05 21:37 ` Khalid Aziz
2018-03-05 21:50 ` Dave Hansen
2018-03-05 21:50 ` Dave Hansen
2018-03-05 21:50 ` Dave Hansen
2018-03-05 21:50 ` Dave Hansen
2018-02-21 17:15 ` [PATCH v12 11/11] sparc64: Update signal delivery to use new helper functions Khalid Aziz
2018-02-21 17:15 ` Khalid Aziz
2018-02-21 20:59 ` Eric W. Biederman
2018-02-21 20:59 ` Eric W. Biederman
2018-03-18 15:08 ` [PATCH v12 00/11] Application Data Integrity feature introduced by SPARC M7 David Miller
2018-03-18 15:08 ` David Miller
2018-03-18 15:08 ` David Miller
2018-03-19 15:19 ` Khalid Aziz
2018-03-19 15:19 ` Khalid Aziz
2018-03-19 15:19 ` Khalid Aziz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2a558ec8-c46c-299e-2f14-bb33058cbd90@linux.intel.com \
--to=dave.hansen@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=anthony.yznaga@oracle.com \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=khalid.aziz@oracle.com \
--cc=khalid@gonehiking.org \
--cc=kstewart@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=pombredanne@nexb.com \
--cc=sparclinux@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.