From: Dave Hansen <dave.hansen@linux.intel.com>
To: Khalid Aziz <khalid.aziz@oracle.com>,
akpm@linux-foundation.org, davem@davemloft.net, arnd@arndb.de
Cc: kirill.shutemov@linux.intel.com, mhocko@suse.com,
ross.zwisler@linux.intel.com, dave.jiang@intel.com,
mgorman@techsingularity.net, willy@infradead.org,
hughd@google.com, minchan@kernel.org, hannes@cmpxchg.org,
shli@fb.com, mingo@kernel.org, jglisse@redhat.com, me@tobin.cc,
anthony.yznaga@oracle.com, linux-arch@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
sparclinux@vger.kernel.org, Khalid Aziz <khalid@gonehiking.org>
Subject: Re: [PATCH v12 02/11] mm, swap: Add infrastructure for saving page metadata on swap
Date: Mon, 5 Mar 2018 11:35:42 -0800 [thread overview]
Message-ID: <d807ba68-decd-e195-f607-ef6962e40c96@linux.intel.com> (raw)
In-Reply-To: <4a766f6d-ba96-7963-b367-7214eab7e307@oracle.com>
On 03/05/2018 11:29 AM, Khalid Aziz wrote:
> ADI data is per page data and is held in the spare bits in the RAM. It
> is loaded into the cache when data is loaded from RAM and flushed out to
> spare bits in the RAM when data is flushed from cache. Sparc allows one
> tag for each ADI block size of data and ADI block size is same as
> cacheline size.
Which does not square with your earlier assertion "ADI data is per page
data". It's per-cacheline data. Right?
> When a page is loaded into RAM from swap space, all of
> the associated ADI data for the page must also be loaded into the RAM,
> so it looks like page level data and storing it in page level software
> data structure makes sense. I am open to other suggestions though.
Do you have a way to tell that data is not being thrown away? Like if
the ADI metadata is different for two different cachelines within a
single page?
WARNING: multiple messages have this Message-ID (diff)
From: Dave Hansen <dave.hansen@linux.intel.com>
To: Khalid Aziz <khalid.aziz@oracle.com>,
akpm@linux-foundation.org, davem@davemloft.net, arnd@arndb.de
Cc: kirill.shutemov@linux.intel.com, mhocko@suse.com,
ross.zwisler@linux.intel.com, dave.jiang@intel.com,
mgorman@techsingularity.net, willy@infradead.org,
hughd@google.com, minchan@kernel.org, hannes@cmpxchg.org,
shli@fb.com, mingo@kernel.org, jglisse@redhat.com, me@tobin.cc,
anthony.yznaga@oracle.com, linux-arch@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
sparclinux@vger.kernel.org, Khalid Aziz <khalid@gonehiking.org>
Subject: Re: [PATCH v12 02/11] mm, swap: Add infrastructure for saving page metadata on swap
Date: Mon, 05 Mar 2018 19:35:42 +0000 [thread overview]
Message-ID: <d807ba68-decd-e195-f607-ef6962e40c96@linux.intel.com> (raw)
In-Reply-To: <4a766f6d-ba96-7963-b367-7214eab7e307@oracle.com>
On 03/05/2018 11:29 AM, Khalid Aziz wrote:
> ADI data is per page data and is held in the spare bits in the RAM. It
> is loaded into the cache when data is loaded from RAM and flushed out to
> spare bits in the RAM when data is flushed from cache. Sparc allows one
> tag for each ADI block size of data and ADI block size is same as
> cacheline size.
Which does not square with your earlier assertion "ADI data is per page
data". It's per-cacheline data. Right?
> When a page is loaded into RAM from swap space, all of
> the associated ADI data for the page must also be loaded into the RAM,
> so it looks like page level data and storing it in page level software
> data structure makes sense. I am open to other suggestions though.
Do you have a way to tell that data is not being thrown away? Like if
the ADI metadata is different for two different cachelines within a
single page?
WARNING: multiple messages have this Message-ID (diff)
From: Dave Hansen <dave.hansen@linux.intel.com>
To: Khalid Aziz <khalid.aziz@oracle.com>,
akpm@linux-foundation.org, davem@davemloft.net, arnd@arndb.de
Cc: kirill.shutemov@linux.intel.com, mhocko@suse.com,
ross.zwisler@linux.intel.com, dave.jiang@intel.com,
mgorman@techsingularity.net, willy@infradead.org,
hughd@google.com, minchan@kernel.org, hannes@cmpxchg.org,
shli@fb.com, mingo@kernel.org, jglisse@redhat.com, me@tobin.cc,
anthony.yznaga@oracle.com, linux-arch@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
sparclinux@vger.kernel.org, Khalid Aziz <khalid@gonehiking.org>
Subject: Re: [PATCH v12 02/11] mm, swap: Add infrastructure for saving page metadata on swap
Date: Mon, 5 Mar 2018 11:35:42 -0800 [thread overview]
Message-ID: <d807ba68-decd-e195-f607-ef6962e40c96@linux.intel.com> (raw)
In-Reply-To: <4a766f6d-ba96-7963-b367-7214eab7e307@oracle.com>
On 03/05/2018 11:29 AM, Khalid Aziz wrote:
> ADI data is per page data and is held in the spare bits in the RAM. It
> is loaded into the cache when data is loaded from RAM and flushed out to
> spare bits in the RAM when data is flushed from cache. Sparc allows one
> tag for each ADI block size of data and ADI block size is same as
> cacheline size.
Which does not square with your earlier assertion "ADI data is per page
data". It's per-cacheline data. Right?
> When a page is loaded into RAM from swap space, all of
> the associated ADI data for the page must also be loaded into the RAM,
> so it looks like page level data and storing it in page level software
> data structure makes sense. I am open to other suggestions though.
Do you have a way to tell that data is not being thrown away? Like if
the ADI metadata is different for two different cachelines within a
single page?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2018-03-05 19:35 UTC|newest]
Thread overview: 133+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-21 17:15 [PATCH v12 00/11] Application Data Integrity feature introduced by SPARC M7 Khalid Aziz
2018-02-21 17:15 ` Khalid Aziz
2018-02-21 17:15 ` Khalid Aziz
2018-02-21 17:15 ` Khalid Aziz
2018-02-21 17:15 ` [PATCH v12 01/11] signals, sparc: Add signal codes for ADI violations Khalid Aziz
2018-02-21 17:15 ` Khalid Aziz
2018-02-21 20:58 ` Eric W. Biederman
2018-02-21 20:58 ` Eric W. Biederman
2018-02-21 17:15 ` [PATCH v12 02/11] mm, swap: Add infrastructure for saving page metadata on swap Khalid Aziz
2018-02-21 17:15 ` Khalid Aziz
2018-02-21 17:15 ` Khalid Aziz
2018-03-05 19:20 ` Dave Hansen
2018-03-05 19:20 ` Dave Hansen
2018-03-05 19:20 ` Dave Hansen
2018-03-05 19:29 ` Khalid Aziz
2018-03-05 19:29 ` Khalid Aziz
2018-03-05 19:29 ` Khalid Aziz
2018-03-05 19:35 ` Dave Hansen [this message]
2018-03-05 19:35 ` Dave Hansen
2018-03-05 19:35 ` Dave Hansen
2018-03-05 20:28 ` Khalid Aziz
2018-03-05 20:28 ` Khalid Aziz
2018-03-05 20:28 ` Khalid Aziz
2018-03-05 21:04 ` Dave Hansen
2018-03-05 21:04 ` Dave Hansen
2018-03-05 21:04 ` Dave Hansen
2018-03-05 21:14 ` Khalid Aziz
2018-03-05 21:14 ` Khalid Aziz
2018-03-05 21:14 ` Khalid Aziz
2018-03-06 22:47 ` Andrew Morton
2018-03-06 22:47 ` Andrew Morton
2018-03-06 22:47 ` Andrew Morton
2018-02-21 17:15 ` [PATCH v12 03/11] sparc64: Add support for ADI register fields, ASIs and traps Khalid Aziz
2018-02-21 17:15 ` Khalid Aziz
2018-02-21 17:15 ` [PATCH v12 04/11] sparc64: Add HV fault type handlers for ADI related faults Khalid Aziz
2018-02-21 17:15 ` Khalid Aziz
2018-02-21 17:15 ` [PATCH v12 05/11] sparc64: Add handler for "Memory Corruption Detected" trap Khalid Aziz
2018-02-21 17:15 ` Khalid Aziz
2018-02-21 17:15 ` [PATCH v12 06/11] sparc64: Add auxiliary vectors to report platform ADI properties Khalid Aziz
2018-02-21 17:15 ` Khalid Aziz
2018-02-21 17:15 ` [PATCH v12 07/11] mm: Add address parameter to arch_validate_prot() Khalid Aziz
2018-02-21 17:15 ` Khalid Aziz
2018-02-21 17:15 ` Khalid Aziz
2018-02-26 5:54 ` Michael Ellerman
2018-02-26 5:54 ` Michael Ellerman
2018-02-26 5:54 ` Michael Ellerman
2018-03-06 22:48 ` Andrew Morton
2018-03-06 22:48 ` Andrew Morton
2018-03-06 22:48 ` Andrew Morton
2018-02-21 17:15 ` [PATCH v12 08/11] mm: Clear arch specific VM flags on protection change Khalid Aziz
2018-02-21 17:15 ` Khalid Aziz
2018-02-21 17:15 ` Khalid Aziz
2018-03-05 19:23 ` Dave Hansen
2018-03-05 19:23 ` Dave Hansen
2018-03-05 19:23 ` Dave Hansen
2018-03-05 20:38 ` Khalid Aziz
2018-03-05 20:38 ` Khalid Aziz
2018-03-05 20:38 ` Khalid Aziz
2018-03-06 22:48 ` Andrew Morton
2018-03-06 22:48 ` Andrew Morton
2018-03-06 22:48 ` Andrew Morton
2018-02-21 17:15 ` [PATCH v12 09/11] mm: Allow arch code to override copy_highpage() Khalid Aziz
2018-02-21 17:15 ` Khalid Aziz
2018-02-21 17:15 ` Khalid Aziz
2018-03-05 19:24 ` Dave Hansen
2018-03-05 19:24 ` Dave Hansen
2018-03-05 19:24 ` Dave Hansen
2018-03-05 20:42 ` Khalid Aziz
2018-03-05 20:42 ` Khalid Aziz
2018-03-05 20:42 ` Khalid Aziz
2018-03-05 20:56 ` Dave Hansen
2018-03-05 20:56 ` Dave Hansen
2018-03-05 20:56 ` Dave Hansen
2018-03-06 22:48 ` Andrew Morton
2018-03-06 22:48 ` Andrew Morton
2018-03-06 22:48 ` Andrew Morton
2018-02-21 17:15 ` [PATCH v12 10/11] sparc64: Add support for ADI (Application Data Integrity) Khalid Aziz
2018-02-21 17:15 ` Khalid Aziz
2018-02-21 17:15 ` Khalid Aziz
2018-02-23 2:50 ` kbuild test robot
2018-02-23 2:50 ` kbuild test robot
2018-02-23 2:50 ` kbuild test robot
2018-02-23 18:51 ` Khalid Aziz
2018-02-23 18:51 ` Khalid Aziz
2018-02-23 18:51 ` Khalid Aziz
2018-02-23 18:57 ` David Miller
2018-02-23 18:57 ` David Miller
2018-02-23 18:57 ` David Miller
2018-02-23 22:11 ` Khalid Aziz
2018-02-23 22:11 ` Khalid Aziz
2018-02-23 22:11 ` Khalid Aziz
2018-03-05 19:22 ` Dave Hansen
2018-03-05 19:22 ` Dave Hansen
2018-03-05 19:22 ` Dave Hansen
2018-03-05 19:22 ` Dave Hansen
2018-03-05 21:14 ` Khalid Aziz
2018-03-05 21:14 ` Khalid Aziz
2018-03-05 21:14 ` Khalid Aziz
2018-03-05 21:14 ` Khalid Aziz
2018-03-05 21:26 ` Dave Hansen
2018-03-05 21:26 ` Dave Hansen
2018-03-05 21:26 ` Dave Hansen
2018-03-05 21:26 ` Dave Hansen
2018-03-05 21:31 ` Dave Hansen
2018-03-05 21:31 ` Dave Hansen
2018-03-05 21:31 ` Dave Hansen
2018-03-05 21:31 ` Dave Hansen
2018-03-05 22:55 ` Khalid Aziz
2018-03-05 22:55 ` Khalid Aziz
2018-03-05 22:55 ` Khalid Aziz
2018-03-05 22:55 ` Khalid Aziz
2018-03-05 21:26 ` Dave Hansen
2018-03-05 21:26 ` Dave Hansen
2018-03-05 21:26 ` Dave Hansen
2018-03-05 21:26 ` Dave Hansen
2018-03-05 21:37 ` Khalid Aziz
2018-03-05 21:37 ` Khalid Aziz
2018-03-05 21:37 ` Khalid Aziz
2018-03-05 21:37 ` Khalid Aziz
2018-03-05 21:50 ` Dave Hansen
2018-03-05 21:50 ` Dave Hansen
2018-03-05 21:50 ` Dave Hansen
2018-03-05 21:50 ` Dave Hansen
2018-02-21 17:15 ` [PATCH v12 11/11] sparc64: Update signal delivery to use new helper functions Khalid Aziz
2018-02-21 17:15 ` Khalid Aziz
2018-02-21 20:59 ` Eric W. Biederman
2018-02-21 20:59 ` Eric W. Biederman
2018-03-18 15:08 ` [PATCH v12 00/11] Application Data Integrity feature introduced by SPARC M7 David Miller
2018-03-18 15:08 ` David Miller
2018-03-18 15:08 ` David Miller
2018-03-19 15:19 ` Khalid Aziz
2018-03-19 15:19 ` Khalid Aziz
2018-03-19 15:19 ` Khalid Aziz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d807ba68-decd-e195-f607-ef6962e40c96@linux.intel.com \
--to=dave.hansen@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=anthony.yznaga@oracle.com \
--cc=arnd@arndb.de \
--cc=dave.jiang@intel.com \
--cc=davem@davemloft.net \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=jglisse@redhat.com \
--cc=khalid.aziz@oracle.com \
--cc=khalid@gonehiking.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=me@tobin.cc \
--cc=mgorman@techsingularity.net \
--cc=mhocko@suse.com \
--cc=minchan@kernel.org \
--cc=mingo@kernel.org \
--cc=ross.zwisler@linux.intel.com \
--cc=shli@fb.com \
--cc=sparclinux@vger.kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.