Re: [PATCH v2 2/4] docs: replace @xxx@ markers at build time

["Jürgen Groß" <jgross@suse.com>]

[-- Attachment #1.1.1: Type: text/plain, Size: 1514 bytes --]

On 14.11.25 12:40, Andrew Cooper wrote:
> On 14/11/2025 11:32 am, Juergen Gross wrote:
>> diff --git a/docs/Makefile b/docs/Makefile
>> index 37776d303c..e5f4a8ca86 100644
>> --- a/docs/Makefile
>> +++ b/docs/Makefile
>> @@ -8,8 +8,11 @@ DATE		:= $(call date,"+%Y-%m-%d")
>>   DOC_ARCHES      := arm ppc riscv x86_32 x86_64
>>   MAN_SECTIONS    := 1 5 7 8
>>   
>> +IN_FILES := man/xl-disk-configuration.5.pod man/xl-network-configuration.5.pod
>> +IN_FILES += man/xl.1.pod man/xl.cfg.5.pod man/xl.conf.5.pod
> 
> Sorry, I meant to say this on the previous revision.  Can we please list
> these one per line, for the future ease of inserting/removing.

Okay.

> Is IN_FILES really correct?  These are the generated (non-.in) files,
> rather than the .in files themselves.  GEN_FILES from v1 would seem to
> be a better fit.

I wanted to make clear this is related to *.in files. And IMHO GEN_FILES
was too generic on a second thought.

GENERATED_FROM_IN_SUFFIXED_FILES seems a little bit clumsy. ;-)
Seriously, if you have any better name, I'd be happy to use it.

> But, overall I think this is a nicer change.
> 
>> +
>>   # Documentation sources to build
>> -MAN-SRC-y := $(sort $(basename $(wildcard man/*.pod man/*.pandoc)))
>> +MAN-SRC-y := $(sort $(basename $(wildcard man/*.pod man/*.pandoc) $(IN_FILES)))
> 
> Doesn't the man/*.pod wildcard do this already ?

Not if only the man/*.pod.in file is there, so the man/*.pod file needs to be
made first.


Juergen

[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 3743 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]