All of lore.kernel.org
 help / color / mirror / Atom feed
From: Danilo Krummrich <dakr@kernel.org>
To: Dave Airlie <airlied@gmail.com>, Junrui Luo <moonafterrain@outlook.com>
Cc: David Airlie <airlied@redhat.com>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Simona Vetter <simona@ffwll.ch>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	"nouveau@lists.freedesktop.org" <nouveau@lists.freedesktop.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Yuhao Jiang <danisjiang@gmail.com>,
	"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH 1/2] drm/nouveau: bound sync and op counts in EXEC and VM_BIND
Date: Tue, 1 Sep 2026 11:07:01 +0200	[thread overview]
Message-ID: <2e433e8d-a71e-49e4-8dea-659a94c8143f@kernel.org> (raw)
In-Reply-To: <CAPM=9txG6wEwx_L5RsB+3gEuT6dYJQvrPpQnHHF4V1gFZpWNFQ@mail.gmail.com>

On 8/11/26 6:05 AM, Dave Airlie wrote:
> On Tue, 11 Aug 2026 at 14:00, Junrui Luo <moonafterrain@outlook.com> wrote:
>>
>> On Mon, Aug 10, 2026 at 08:43:50AM +1000, David Airlie wrote:
>>> Have you run a complete Vulkan CTS with NVK across this with no regressions?
>>>
>>> I'm weary of those limits being too low, but I think the only app that
>>> might push them beyond CTS would be Forza Horizon 5 or 6.
>>
>> No, I have not. I don't currently have the hardware to run NVK, so I can't
>> offer a CTS run or any other regression test for this.
>>
>> Is there a better guard that avoids a hard limit here, or does this need
>> a test before it can go in?
> 
> Looking at xe it also has 1024 limit on number of syncs, but it
> doesn't have any limit on number of binds,
> 
>                 *bind_ops = kvmalloc_objs(struct drm_xe_vm_bind_op,
>                                           args->num_binds,
>                                           GFP_KERNEL | __GFP_ACCOUNT |
> __GFP_RETRY_MAYFAIL | __GFP_NOWARN);
> 
> Maybe nouveau could do the same.
SGTM, I'd also be hesitant to put a hard limit on VM_BIND.

@Junrui: Can you please resend?

WARNING: multiple messages have this Message-ID (diff)
From: Danilo Krummrich <dakr@kernel.org>
To: Dave Airlie <airlied@gmail.com>, Junrui Luo <moonafterrain@outlook.com>
Cc: David Airlie <airlied@redhat.com>, Lyude Paul <lyude@redhat.com>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	Simona Vetter <simona@ffwll.ch>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	"nouveau@lists.freedesktop.org" <nouveau@lists.freedesktop.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Yuhao Jiang <danisjiang@gmail.com>,
	"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH 1/2] drm/nouveau: bound sync and op counts in EXEC and VM_BIND
Date: Tue, 1 Sep 2026 11:07:01 +0200	[thread overview]
Message-ID: <2e433e8d-a71e-49e4-8dea-659a94c8143f@kernel.org> (raw)
In-Reply-To: <CAPM=9txG6wEwx_L5RsB+3gEuT6dYJQvrPpQnHHF4V1gFZpWNFQ@mail.gmail.com>

On 8/11/26 6:05 AM, Dave Airlie wrote:
> On Tue, 11 Aug 2026 at 14:00, Junrui Luo <moonafterrain@outlook.com> wrote:
>>
>> On Mon, Aug 10, 2026 at 08:43:50AM +1000, David Airlie wrote:
>>> Have you run a complete Vulkan CTS with NVK across this with no regressions?
>>>
>>> I'm weary of those limits being too low, but I think the only app that
>>> might push them beyond CTS would be Forza Horizon 5 or 6.
>>
>> No, I have not. I don't currently have the hardware to run NVK, so I can't
>> offer a CTS run or any other regression test for this.
>>
>> Is there a better guard that avoids a hard limit here, or does this need
>> a test before it can go in?
> 
> Looking at xe it also has 1024 limit on number of syncs, but it
> doesn't have any limit on number of binds,
> 
>                 *bind_ops = kvmalloc_objs(struct drm_xe_vm_bind_op,
>                                           args->num_binds,
>                                           GFP_KERNEL | __GFP_ACCOUNT |
> __GFP_RETRY_MAYFAIL | __GFP_NOWARN);
> 
> Maybe nouveau could do the same.
SGTM, I'd also be hesitant to put a hard limit on VM_BIND.

@Junrui: Can you please resend?

  reply	other threads:[~2026-09-01  9:07 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-08 11:14 [PATCH 0/2] drm/nouveau: fix unbounded kernel allocations in the VM_BIND uAPI Junrui Luo via B4 Relay
2026-08-08 11:14 ` Junrui Luo
2026-08-08 11:14 ` [PATCH 1/2] drm/nouveau: bound sync and op counts in EXEC and VM_BIND Junrui Luo via B4 Relay
2026-08-08 11:14   ` Junrui Luo
2026-08-08 11:27   ` sashiko-bot
2026-08-09 22:43   ` David Airlie
2026-08-09 22:43     ` David Airlie
2026-08-11  4:00     ` Junrui Luo
2026-08-11  4:00       ` Junrui Luo
2026-08-11  4:05       ` Dave Airlie
2026-08-11  4:05         ` Dave Airlie
2026-09-01  9:07         ` Danilo Krummrich [this message]
2026-09-01  9:07           ` Danilo Krummrich
2026-08-08 11:14 ` [PATCH 2/2] drm/nouveau/uvmm: reject a second VM_INIT Junrui Luo via B4 Relay
2026-08-08 11:14   ` Junrui Luo
2026-08-08 11:35   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2e433e8d-a71e-49e4-8dea-659a94c8143f@kernel.org \
    --to=dakr@kernel.org \
    --cc=airlied@gmail.com \
    --cc=airlied@redhat.com \
    --cc=danisjiang@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=moonafterrain@outlook.com \
    --cc=mripard@kernel.org \
    --cc=nouveau@lists.freedesktop.org \
    --cc=simona@ffwll.ch \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.