From: Pratyush Yadav <pratyush@kernel.org>
To: David Matlack <dmatlack@google.com>
Cc: kexec@lists.infradead.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-mm@kvack.org, Alexander Graf <graf@amazon.com>,
Andrew Morton <akpm@linux-foundation.org>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
Christian Brauner <brauner@kernel.org>,
David Hildenbrand <david@kernel.org>,
Hugh Dickins <hughd@google.com>,
Jonathan Corbet <corbet@lwn.net>,
"Liam R. Howlett" <liam@infradead.org>,
Lorenzo Stoakes <ljs@kernel.org>,
Michal Hocko <mhocko@suse.com>, Mike Rapoport <rppt@kernel.org>,
Pasha Tatashin <pasha.tatashin@soleen.com>,
Pratyush Yadav <pratyush@kernel.org>,
Randy Dunlap <rdunlap@infradead.org>,
Samiullah Khawaja <skhawaja@google.com>,
Shuah Khan <skhan@linuxfoundation.org>,
Suren Baghdasaryan <surenb@google.com>,
Vlastimil Babka <vbabka@kernel.org>
Subject: Re: [PATCH v4 09/19] mm/shmem_luo: Leave freeing the preserved state to finish()
Date: Fri, 20 Nov 2026 11:55:44 +0000 [thread overview]
Message-ID: <2vxz33sv3ef3.fsf@kernel.org> (raw)
In-Reply-To: <20261111002358.1842967-10-dmatlack@google.com> (David Matlack's message of "Wed, 11 Nov 2026 00:23:47 +0000")
On Wed, Nov 11 2026, David Matlack wrote:
> Don't free the serialized state in shmem_luo_retrieve(), whether the
> retrieve succeeds or fails, and let finish() free whatever is left of
> the preserved state of every file. Once retrieve() has restored the
> folios, it sets nr_folios in the serialized state to 0, so that
> finish() only frees the rest.
>
> This fixes leaking the preserved folios when the retrieve fails before
> it restores them, e.g. because the file has seals that this kernel
> doesn't support, or because memfd_alloc_file() fails. The retrieve freed
> the serialized state but not the folios, and finish() then skipped the
> file because its retrieve had failed, so the folios were never freed.
>
> Preserved folios may also be in use until the session is finished, e.g.
> by a device that was preserved with DMA mappings of them, so they must
> not be freed before finish().
>
> Fixes: f85b1c6af5bc ("liveupdate: luo_file: remember retrieve() status")
> Signed-off-by: David Matlack <dmatlack@google.com>
I think some of this is already fixed by [0]. It holds the folios until
finish, but only in the success case. On failure to parse seals for
example, it leaks them. Except, as Sashiko also points out, in
memfd_luo_retrieve_folios() the folios are freed.
I don't think this is strictly related to your series so can you please
send something on top of [0] to fix these bugs, and perhaps drop this
patch?
[0] https://lore.kernel.org/kexec/20261110175855.2437084-3-pratyush@kernel.org/
[...]
--
Regards,
Pratyush Yadav
next prev parent reply other threads:[~2026-11-20 11:55 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-11 0:23 [PATCH v4 00/19] liveupdate: Preserve tmpfs files across Live Update David Matlack
2026-11-11 0:23 ` [PATCH v4 01/19] liveupdate: Remove the list of steps from luo_preserve_file()'s comment David Matlack
2026-11-12 0:31 ` sashiko-bot
2026-11-19 18:26 ` Pratyush Yadav
2026-11-11 0:23 ` [PATCH v4 02/19] liveupdate: Pass user argument to file preserve and retrieve David Matlack
2026-11-12 0:31 ` sashiko-bot
2026-11-19 18:32 ` Pratyush Yadav
2026-11-11 0:23 ` [PATCH v4 03/19] selftests/liveupdate: Add tests for preserve and retrieve user argument David Matlack
2026-11-12 0:31 ` sashiko-bot
2026-11-11 0:23 ` [PATCH v4 04/19] liveupdate: Allow file handlers to mark retrieve failures as retryable David Matlack
2026-11-12 0:31 ` sashiko-bot
2026-11-19 18:38 ` Pratyush Yadav
2026-11-11 0:23 ` [PATCH v4 05/19] mm: Rename memfd_luo to shmem_luo David Matlack
2026-11-12 0:31 ` sashiko-bot
2026-11-11 0:23 ` [PATCH v4 06/19] liveupdate: Don't WARN if tracking a retrieved file fails David Matlack
2026-11-12 0:31 ` sashiko-bot
2026-11-20 9:58 ` Pratyush Yadav
2026-11-11 0:23 ` [PATCH v4 07/19] liveupdate: Add helpers to track the files that LUO manages David Matlack
2026-11-12 0:31 ` sashiko-bot
2026-11-20 11:15 ` Pratyush Yadav
2026-11-11 0:23 ` [PATCH v4 08/19] liveupdate: Let file handlers retrieve into an existing file David Matlack
2026-11-12 0:31 ` sashiko-bot
2026-11-20 9:23 ` Christian Brauner
2026-11-20 11:36 ` Pratyush Yadav
2026-11-11 0:23 ` [PATCH v4 09/19] mm/shmem_luo: Leave freeing the preserved state to finish() David Matlack
2026-11-12 0:31 ` sashiko-bot
2026-11-20 11:55 ` Pratyush Yadav [this message]
2026-11-11 0:23 ` [PATCH v4 10/19] mm/shmem_luo: Don't make early retrieve failures permanent David Matlack
2026-11-12 0:31 ` sashiko-bot
2026-11-20 12:02 ` Pratyush Yadav
2026-11-11 0:23 ` [PATCH v4 11/19] mm/shmem_luo: Require permission to preserve a file David Matlack
2026-11-12 0:31 ` sashiko-bot
2026-11-20 12:18 ` Pratyush Yadav
2026-11-11 0:23 ` [PATCH v4 12/19] mm/shmem_luo: Retrieve tmpfs files into a file created by userspace David Matlack
2026-11-12 0:31 ` sashiko-bot
2026-11-20 13:51 ` Pratyush Yadav
2026-11-11 0:23 ` [PATCH v4 13/19] mm/shmem_luo: Allow preserving tmpfs files David Matlack
2026-11-12 0:31 ` sashiko-bot
2026-11-20 13:55 ` Pratyush Yadav
2026-11-11 0:23 ` [PATCH v4 14/19] selftests/liveupdate: Test which tmpfs files can be preserved David Matlack
2026-11-12 0:31 ` sashiko-bot
2026-11-20 14:29 ` Pratyush Yadav
2026-11-11 0:23 ` [PATCH v4 15/19] selftests/liveupdate: Add a test for retrieving tmpfs files David Matlack
2026-11-12 0:31 ` sashiko-bot
2026-11-11 0:23 ` [PATCH v4 16/19] selftests/liveupdate: Test memfds and LUO interactions in luo_tmpfs David Matlack
2026-11-12 0:31 ` sashiko-bot
2026-11-11 0:23 ` [PATCH v4 17/19] selftests/liveupdate: Test the targets of retrieved tmpfs files David Matlack
2026-11-12 0:31 ` sashiko-bot
2026-11-11 0:23 ` [PATCH v4 18/19] selftests/liveupdate: Test retrieving tmpfs files preserved read-only David Matlack
2026-11-12 0:31 ` sashiko-bot
2026-11-11 0:23 ` [PATCH v4 19/19] selftests/liveupdate: Test block accounting of retrieved tmpfs files David Matlack
2026-11-12 0:31 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2vxz33sv3ef3.fsf@kernel.org \
--to=pratyush@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=brauner@kernel.org \
--cc=corbet@lwn.net \
--cc=david@kernel.org \
--cc=dmatlack@google.com \
--cc=graf@amazon.com \
--cc=hughd@google.com \
--cc=kexec@lists.infradead.org \
--cc=liam@infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=mhocko@suse.com \
--cc=pasha.tatashin@soleen.com \
--cc=rdunlap@infradead.org \
--cc=rppt@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=skhawaja@google.com \
--cc=surenb@google.com \
--cc=vbabka@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.