All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/1] drm: gem_cma: Use ERR_CAST helper
@ 2014-05-29  4:33 Sachin Kamat
  2014-05-29 14:00 ` Laurent Pinchart
  0 siblings, 1 reply; 2+ messages in thread
From: Sachin Kamat @ 2014-05-29  4:33 UTC (permalink / raw)
  To: dri-devel; +Cc: sachin.kamat, Laurent Pinchart

Makes the code a bit more readable.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
---
 drivers/gpu/drm/drm_gem_cma_helper.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/drm_gem_cma_helper.c b/drivers/gpu/drm/drm_gem_cma_helper.c
index 05c97c5350a1..e467e67af6e7 100644
--- a/drivers/gpu/drm/drm_gem_cma_helper.c
+++ b/drivers/gpu/drm/drm_gem_cma_helper.c
@@ -327,7 +327,7 @@ drm_gem_cma_prime_import_sg_table(struct drm_device *dev, size_t size,
 	/* Create a CMA GEM buffer. */
 	cma_obj = __drm_gem_cma_create(dev, size);
 	if (IS_ERR(cma_obj))
-		return ERR_PTR(PTR_ERR(cma_obj));
+		return ERR_CAST(cma_obj);
 
 	cma_obj->paddr = sg_dma_address(sgt->sgl);
 	cma_obj->sgt = sgt;
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH 1/1] drm: gem_cma: Use ERR_CAST helper
  2014-05-29  4:33 [PATCH 1/1] drm: gem_cma: Use ERR_CAST helper Sachin Kamat
@ 2014-05-29 14:00 ` Laurent Pinchart
  0 siblings, 0 replies; 2+ messages in thread
From: Laurent Pinchart @ 2014-05-29 14:00 UTC (permalink / raw)
  To: Sachin Kamat; +Cc: dri-devel

Hi Sachin,

Thank you for the patch.

On Thursday 29 May 2014 10:03:18 Sachin Kamat wrote:
> Makes the code a bit more readable.
> 
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>

Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  drivers/gpu/drm/drm_gem_cma_helper.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/drm_gem_cma_helper.c
> b/drivers/gpu/drm/drm_gem_cma_helper.c index 05c97c5350a1..e467e67af6e7
> 100644
> --- a/drivers/gpu/drm/drm_gem_cma_helper.c
> +++ b/drivers/gpu/drm/drm_gem_cma_helper.c
> @@ -327,7 +327,7 @@ drm_gem_cma_prime_import_sg_table(struct drm_device
> *dev, size_t size, /* Create a CMA GEM buffer. */
>  	cma_obj = __drm_gem_cma_create(dev, size);
>  	if (IS_ERR(cma_obj))
> -		return ERR_PTR(PTR_ERR(cma_obj));
> +		return ERR_CAST(cma_obj);
> 
>  	cma_obj->paddr = sg_dma_address(sgt->sgl);
>  	cma_obj->sgt = sgt;

-- 
Regards,

Laurent Pinchart

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-05-29 14:00 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-29  4:33 [PATCH 1/1] drm: gem_cma: Use ERR_CAST helper Sachin Kamat
2014-05-29 14:00 ` Laurent Pinchart

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.