All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Moore <pmoore@redhat.com>
To: Mimi Zohar <zohar@linux.vnet.ibm.com>
Cc: John Johansen <john.johansen@canonical.com>,
	Kees Cook <keescook@chromium.org>,
	fsdevel@vger.kernel.org,
	Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>,
	Dmitry Kasatkin <dmitry.kasatkin@gmail.com>,
	"Luis R. Rodriguez" <mcgrof@suse.com>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	kexec@lists.infradead.org, David Howells <dhowells@redhat.com>,
	linux-security-module@vger.kernel.org,
	Casey Schaufler <casey@schaufler-ca.com>,
	David Woodhouse <dwmw2@infradead.org>,
	linux-modules@vger.kernel.org
Subject: Re: [RFC PATCH v2 08/11] module: replace copy_module_from_fd with kernel version
Date: Thu, 21 Jan 2016 16:26:56 -0500	[thread overview]
Message-ID: <3085861.bPaQXnMeXx@sifl> (raw)
In-Reply-To: <1453410902.9549.184.camel@linux.vnet.ibm.com>

On Thursday, January 21, 2016 04:15:02 PM Mimi Zohar wrote:
> On Thu, 2016-01-21 at 10:45 -0500, Paul Moore wrote:
> > On Thursday, January 21, 2016 08:12:12 AM Mimi Zohar wrote:
> > > Paul, Casey, Kees, Jon, Tetsuo does it make sense to consolidate the
> > > module, firmware, and kexec pre and post security hooks and have just
> > > one set of pre and post security kernel_read_file hook instead?   Does
> > > it make sense for this patch set to define the new hooks to allow the
> > > LSMs to migrate to it independently of each other?
> > 
> > Well, as usual, the easiest way to both get solid feedback and actually
> > get a change accepted is to post patches to the affected LSMs.  Probably
> > not what you wanted to hear, but at least I'm honest :)
> 
> Unless I'm misreading the code, it might be a lot simpler than I
> thought.  Of the three LSM hooks kernel_module_request,
> kernel_module_from_file, and kernel_fw_from_file, the only upstreamed
> LSM on any of these hooks is SELinux, which is only on the
> kernel_module_request hook.
> 
> After converting the SELinux kernel_module_request hook to use the new
> kernel_read_file(),  do I then remove the three hooks?   Are we
> concerned about "minor" LSMs that have not been upstreamed that might be
> using these hooks?

You can't worry about code that isn't upstream; if this change breaks 
something that hasn't been merged, then the burden lies on the out-of-tree 
developers to change their code.

-- 
paul moore
security @ redhat


_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

WARNING: multiple messages have this Message-ID (diff)
From: Paul Moore <pmoore@redhat.com>
To: Mimi Zohar <zohar@linux.vnet.ibm.com>
Cc: "Luis R. Rodriguez" <mcgrof@suse.com>,
	Casey Schaufler <casey@schaufler-ca.com>,
	John Johansen <john.johansen@canonical.com>,
	Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>,
	linux-security-module@vger.kernel.org, kexec@lists.infradead.org,
	linux-modules@vger.kernel.org, fsdevel@vger.kernel.org,
	David Howells <dhowells@redhat.com>,
	David Woodhouse <dwmw2@infradead.org>,
	Kees Cook <keescook@chromium.org>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Dmitry Kasatkin <dmitry.kasatkin@gmail.com>
Subject: Re: [RFC PATCH v2 08/11] module: replace copy_module_from_fd with kernel version
Date: Thu, 21 Jan 2016 16:26:56 -0500	[thread overview]
Message-ID: <3085861.bPaQXnMeXx@sifl> (raw)
In-Reply-To: <1453410902.9549.184.camel@linux.vnet.ibm.com>

On Thursday, January 21, 2016 04:15:02 PM Mimi Zohar wrote:
> On Thu, 2016-01-21 at 10:45 -0500, Paul Moore wrote:
> > On Thursday, January 21, 2016 08:12:12 AM Mimi Zohar wrote:
> > > Paul, Casey, Kees, Jon, Tetsuo does it make sense to consolidate the
> > > module, firmware, and kexec pre and post security hooks and have just
> > > one set of pre and post security kernel_read_file hook instead?   Does
> > > it make sense for this patch set to define the new hooks to allow the
> > > LSMs to migrate to it independently of each other?
> > 
> > Well, as usual, the easiest way to both get solid feedback and actually
> > get a change accepted is to post patches to the affected LSMs.  Probably
> > not what you wanted to hear, but at least I'm honest :)
> 
> Unless I'm misreading the code, it might be a lot simpler than I
> thought.  Of the three LSM hooks kernel_module_request,
> kernel_module_from_file, and kernel_fw_from_file, the only upstreamed
> LSM on any of these hooks is SELinux, which is only on the
> kernel_module_request hook.
> 
> After converting the SELinux kernel_module_request hook to use the new
> kernel_read_file(),  do I then remove the three hooks?   Are we
> concerned about "minor" LSMs that have not been upstreamed that might be
> using these hooks?

You can't worry about code that isn't upstream; if this change breaks 
something that hasn't been merged, then the burden lies on the out-of-tree 
developers to change their code.

-- 
paul moore
security @ redhat


  reply	other threads:[~2016-01-21 21:27 UTC|newest]

Thread overview: 100+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-18 15:11 [RFC PATCH v2 00/11] vfss: support for a common kernel file loader Mimi Zohar
2016-01-18 15:11 ` Mimi Zohar
2016-01-18 15:11 ` [RFC PATCH v2 01/11] ima: separate 'security.ima' reading functionality from collect Mimi Zohar
2016-01-18 15:11   ` Mimi Zohar
2016-01-19 20:00   ` Dmitry Kasatkin
2016-01-19 20:00     ` Dmitry Kasatkin
2016-01-21 13:19     ` Mimi Zohar
2016-01-21 13:19       ` Mimi Zohar
2016-01-21 18:18       ` Dmitry Kasatkin
2016-01-21 18:18         ` Dmitry Kasatkin
2016-01-18 15:11 ` [RFC PATCH v2 02/11] vfs: define a generic function to read a file from the kernel Mimi Zohar
2016-01-18 15:11   ` Mimi Zohar
2016-01-20  1:09   ` Luis R. Rodriguez
2016-01-20  1:09     ` Luis R. Rodriguez
2016-01-21 13:24     ` Mimi Zohar
2016-01-21 13:24       ` Mimi Zohar
2016-01-18 15:11 ` [RFC PATCH v2 03/11] ima: provide buffer hash calculation function Mimi Zohar
2016-01-18 15:11   ` Mimi Zohar
2016-01-19 19:26   ` Dmitry Kasatkin
2016-01-19 19:26     ` Dmitry Kasatkin
2016-01-21 13:18     ` Mimi Zohar
2016-01-21 13:18       ` Mimi Zohar
2016-01-18 15:11 ` [RFC PATCH v2 04/11] ima: calculate the hash of a buffer using aynchronous hash(ahash) Mimi Zohar
2016-01-18 15:11   ` Mimi Zohar
2016-01-18 15:11 ` [RFC PATCH v2 05/11] ima: define a new hook to measure and appraise a file already in memory Mimi Zohar
2016-01-18 15:11   ` Mimi Zohar
2016-01-18 15:11 ` [RFC PATCH v2 06/11] kexec: replace call to copy_file_from_fd() with kernel version Mimi Zohar
2016-01-18 15:11   ` Mimi Zohar
2016-01-20  3:22   ` Minfei Huang
2016-01-20  3:22     ` Minfei Huang
2016-01-20 23:12   ` Luis R. Rodriguez
2016-01-20 23:12     ` Luis R. Rodriguez
2016-01-21  0:27     ` Dmitry Torokhov
2016-01-21  0:27       ` Dmitry Torokhov
2016-01-25  6:37   ` Dave Young
2016-01-25  6:37     ` Dave Young
2016-01-25  7:02     ` Dave Young
2016-01-25  7:02       ` Dave Young
2016-01-25 15:04     ` Mimi Zohar
2016-01-25 15:04       ` Mimi Zohar
2016-01-25 20:34       ` Luis R. Rodriguez
2016-01-25 20:34         ` Luis R. Rodriguez
2016-01-25 23:48         ` Mimi Zohar
2016-01-25 23:48           ` Mimi Zohar
2016-01-26 20:48           ` Luis R. Rodriguez
2016-01-26 20:48             ` Luis R. Rodriguez
2016-01-26  1:20       ` Dave Young
2016-01-26  1:20         ` Dave Young
2016-01-26 16:40         ` Mimi Zohar
2016-01-26 16:40           ` Mimi Zohar
2016-01-27  1:50           ` Dave Young
2016-01-27  1:50             ` Dave Young
2016-01-18 15:11 ` [RFC PATCH v2 07/11] firmware: replace call to fw_read_file_contents() " Mimi Zohar
2016-01-18 15:11   ` Mimi Zohar
2016-01-20  0:10   ` Kees Cook
2016-01-20  0:10     ` Kees Cook
2016-01-21 12:04     ` Mimi Zohar
2016-01-21 12:04       ` Mimi Zohar
2016-01-20 23:39   ` Luis R. Rodriguez
2016-01-20 23:39     ` Luis R. Rodriguez
2016-01-20 23:56     ` Luis R. Rodriguez
2016-01-20 23:56       ` Luis R. Rodriguez
2016-01-21 12:05       ` Mimi Zohar
2016-01-21 12:05         ` Mimi Zohar
2016-01-21 16:49         ` Luis R. Rodriguez
2016-01-21 16:49           ` Luis R. Rodriguez
2016-01-18 15:11 ` [RFC PATCH v2 08/11] module: replace copy_module_from_fd " Mimi Zohar
2016-01-18 15:11   ` Mimi Zohar
2016-01-21  0:03   ` Luis R. Rodriguez
2016-01-21  0:03     ` Luis R. Rodriguez
2016-01-21 13:12     ` Mimi Zohar
2016-01-21 13:12       ` Mimi Zohar
2016-01-21 15:45       ` Paul Moore
2016-01-21 15:45         ` Paul Moore
2016-01-21 21:15         ` Mimi Zohar
2016-01-21 21:15           ` Mimi Zohar
2016-01-21 21:26           ` Paul Moore [this message]
2016-01-21 21:26             ` Paul Moore
2016-01-21 21:58           ` Kees Cook
2016-01-21 21:58             ` Kees Cook
2016-01-21 16:56       ` Luis R. Rodriguez
2016-01-21 16:56         ` Luis R. Rodriguez
2016-01-21 20:37         ` Mimi Zohar
2016-01-21 20:37           ` Mimi Zohar
2016-01-18 15:11 ` [RFC PATCH v2 09/11] ima: load policy using path Mimi Zohar
2016-01-18 15:11   ` Mimi Zohar
2016-01-21  0:05   ` Luis R. Rodriguez
2016-01-21  0:05     ` Luis R. Rodriguez
2016-01-21 13:15     ` Mimi Zohar
2016-01-21 13:15       ` Mimi Zohar
2016-01-23  2:59   ` Luis R. Rodriguez
2016-01-23  2:59     ` Luis R. Rodriguez
2016-01-18 15:11 ` [RFC PATCH v2 10/11] ima: measure and appraise the IMA policy itself Mimi Zohar
2016-01-18 15:11   ` Mimi Zohar
2016-01-18 15:11 ` [RFC PATCH v2 11/11] ima: require signed IMA policy Mimi Zohar
2016-01-18 15:11   ` Mimi Zohar
2016-01-21 20:16 ` [RFC PATCH v2 00/11] vfss: support for a common kernel file loader Luis R. Rodriguez
2016-01-21 20:16   ` Luis R. Rodriguez
2016-01-21 20:18   ` Mimi Zohar
2016-01-21 20:18     ` Mimi Zohar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3085861.bPaQXnMeXx@sifl \
    --to=pmoore@redhat.com \
    --cc=casey@schaufler-ca.com \
    --cc=dhowells@redhat.com \
    --cc=dmitry.kasatkin@gmail.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=dwmw2@infradead.org \
    --cc=fsdevel@vger.kernel.org \
    --cc=john.johansen@canonical.com \
    --cc=keescook@chromium.org \
    --cc=kexec@lists.infradead.org \
    --cc=linux-modules@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=mcgrof@suse.com \
    --cc=penguin-kernel@i-love.sakura.ne.jp \
    --cc=zohar@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.