Re: [PATCH v2 4/8] configs: socfpga: n5x: enable required configs for DDR retention

["Chee, Tien Fong" <tien.fong.chee@altera.com>]

Hi Lok,


On 28/4/2026 3:00 pm, Chen Huei Lok wrote:
> Enable required configs to support DDR retention. Including generic
> firmware loader for loading backup calibration data, and SHA384/512
> checking.
>
> Signed-off-by: Tien Fong Chee <tien.fong.chee@altera.com>
> Signed-off-by: Chen Huei Lok <chen.huei.lok@altera.com>
> ---
>   configs/socfpga_n5x_defconfig | 4 ++++
>   1 file changed, 4 insertions(+)
>
> diff --git a/configs/socfpga_n5x_defconfig b/configs/socfpga_n5x_defconfig
> index b6df9946ef3..273e74c6499 100644
> --- a/configs/socfpga_n5x_defconfig
> +++ b/configs/socfpga_n5x_defconfig
> @@ -90,4 +90,8 @@ CONFIG_WDT=y
>   # CONFIG_SPL_USE_TINY_PRINTF is not set
>   CONFIG_PANIC_HANG=y
>   CONFIG_SPL_CRC32=y
> +CONFIG_SHA512_ALGO=y
> +CONFIG_SHA384=y
> +CONFIG_FS_LOADER=y
> +CONFIG_SPL_ENV_SUPPORT=y
>   # CONFIG_TOOLS_MKEFICAPSULE is not set


Please document the rationale for introducing DDR retention and describe

how HA384/SHA512, FS_LOADER, and CONFIG_SPL_ENV_SUPPORT are adapted to 
support DDR retention (e.g., required init/order changes, state handoff, 
buffer placement, and

failure modes).

It appears FS_LOADER may be missing pieces needed for DDR retention 
(such as handling retained memory regions or re-init sequencing).

Consider restructuring this as a series that first enables DDR retention 
for N5X, then adds the required support in FS_LOADER and SPL env 
handling in follow-up patches.


Best regards,

Tien Fong