Re: [PATCH v2 6/8] arm: socfpga: n5x: switch firewall setup to driver model

["Chee, Tien Fong" <tien.fong.chee@altera.com>]

Hi Lok,


On 28/4/2026 3:00 pm, Chen Huei Lok wrote:
> Move the system manager and L3 interconnect firewall configuration
> from a dedicated firewall_setup() function to using the driver model
> (uclass_get_device_by_name()). This removes the hardcoded firewall
> setup in SPL and relies on the driver model, making the code more
> maintainable and aligned with upstream practices.
>
> Signed-off-by: Tien Fong Chee <tien.fong.chee@altera.com>
> Signed-off-by: Chen Huei Lok <chen.huei.lok@altera.com>
> ---
>   arch/arm/mach-socfpga/spl_n5x.c | 12 +++++++++++-
>   1 file changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-socfpga/spl_n5x.c b/arch/arm/mach-socfpga/spl_n5x.c
> index a49be837921..f776d0c0327 100644
> --- a/arch/arm/mach-socfpga/spl_n5x.c
> +++ b/arch/arm/mach-socfpga/spl_n5x.c
> @@ -69,7 +69,17 @@ void board_init_f(ulong dummy)
>   	print_reset_info();
>   	cm_print_clock_quick_summary();
>   
> -	firewall_setup();


If firewall_setup() is defined in a separate source file (which is 
implied by the function call existing before this patch),

removing its only call site should prompt deletion of the function 
definition too

Without that, the linker may still include the dead code.

The diff should include the removal of the firewall_setup() implementation


Best regards,

Tien Fong