* [PATCH v1 0/2] XStats fixes
@ 2016-11-14 6:14 Remy Horton
2016-11-14 6:14 ` [PATCH v1 1/2] net/i40e: fix incorrect xstats value mapping Remy Horton
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Remy Horton @ 2016-11-14 6:14 UTC (permalink / raw)
To: dev; +Cc: Helin Zhang, Jingjing Wu
The offsets used in rte_i40evf_stats_strings for transmission
statistics were wrong, returning the total byte count rather than
the respective (unicast, multicast, broadcast, drop, & error)
packet counts.
This patchset also fixes some spelling errors.
Fixes: da61cd084976 ("i40evf: add extended stats")
Fixes: 0eedec25ea36 ("i40e: clean log messages")
Remy Horton (2):
net/i40e: fix incorrect xstats value mapping
net/i40e: fix spelling errors
drivers/net/i40e/i40e_ethdev.c | 2 +-
drivers/net/i40e/i40e_ethdev_vf.c | 16 ++++++++--------
2 files changed, 9 insertions(+), 9 deletions(-)
--
2.5.5
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH v1 1/2] net/i40e: fix incorrect xstats value mapping 2016-11-14 6:14 [PATCH v1 0/2] XStats fixes Remy Horton @ 2016-11-14 6:14 ` Remy Horton 2016-11-14 17:59 ` Kevin Traynor 2016-11-14 6:14 ` [PATCH v1 2/2] net/i40e: fix spelling errors Remy Horton 2016-11-15 10:59 ` [PATCH v1 0/2] XStats fixes Ferruh Yigit 2 siblings, 1 reply; 6+ messages in thread From: Remy Horton @ 2016-11-14 6:14 UTC (permalink / raw) To: dev; +Cc: Helin Zhang, Jingjing Wu The offsets used in rte_i40evf_stats_strings for transmission statistics were wrong, returning the total byte count rather than the respective (unicast, multicast, broadcast, drop, & error) packet counts. Fixes: da61cd084976 ("i40evf: add extended stats") Signed-off-by: Remy Horton <remy.horton@intel.com> --- drivers/net/i40e/i40e_ethdev_vf.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c index aa306d6..afae2ec 100644 --- a/drivers/net/i40e/i40e_ethdev_vf.c +++ b/drivers/net/i40e/i40e_ethdev_vf.c @@ -176,11 +176,11 @@ static const struct rte_i40evf_xstats_name_off rte_i40evf_stats_strings[] = { {"rx_unknown_protocol_packets", offsetof(struct i40e_eth_stats, rx_unknown_protocol)}, {"tx_bytes", offsetof(struct i40e_eth_stats, tx_bytes)}, - {"tx_unicast_packets", offsetof(struct i40e_eth_stats, tx_bytes)}, - {"tx_multicast_packets", offsetof(struct i40e_eth_stats, tx_bytes)}, - {"tx_broadcast_packets", offsetof(struct i40e_eth_stats, tx_bytes)}, - {"tx_dropped_packets", offsetof(struct i40e_eth_stats, tx_bytes)}, - {"tx_error_packets", offsetof(struct i40e_eth_stats, tx_bytes)}, + {"tx_unicast_packets", offsetof(struct i40e_eth_stats, tx_unicast)}, + {"tx_multicast_packets", offsetof(struct i40e_eth_stats, tx_multicast)}, + {"tx_broadcast_packets", offsetof(struct i40e_eth_stats, tx_broadcast)}, + {"tx_dropped_packets", offsetof(struct i40e_eth_stats, tx_discards)}, + {"tx_error_packets", offsetof(struct i40e_eth_stats, tx_errors)}, }; #define I40EVF_NB_XSTATS (sizeof(rte_i40evf_stats_strings) / \ -- 2.5.5 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v1 1/2] net/i40e: fix incorrect xstats value mapping 2016-11-14 6:14 ` [PATCH v1 1/2] net/i40e: fix incorrect xstats value mapping Remy Horton @ 2016-11-14 17:59 ` Kevin Traynor 0 siblings, 0 replies; 6+ messages in thread From: Kevin Traynor @ 2016-11-14 17:59 UTC (permalink / raw) To: Remy Horton, dev; +Cc: Helin Zhang, Jingjing Wu, stable, Yuanhan Liu On 11/14/2016 06:14 AM, Remy Horton wrote: > The offsets used in rte_i40evf_stats_strings for transmission > statistics were wrong, returning the total byte count rather than > the respective (unicast, multicast, broadcast, drop, & error) > packet counts. > > Fixes: da61cd084976 ("i40evf: add extended stats") This should go to the LTS branch also. Acked-by: Kevin Traynor <ktraynor@redhat.com> > > Signed-off-by: Remy Horton <remy.horton@intel.com> > --- > drivers/net/i40e/i40e_ethdev_vf.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c > index aa306d6..afae2ec 100644 > --- a/drivers/net/i40e/i40e_ethdev_vf.c > +++ b/drivers/net/i40e/i40e_ethdev_vf.c > @@ -176,11 +176,11 @@ static const struct rte_i40evf_xstats_name_off rte_i40evf_stats_strings[] = { > {"rx_unknown_protocol_packets", offsetof(struct i40e_eth_stats, > rx_unknown_protocol)}, > {"tx_bytes", offsetof(struct i40e_eth_stats, tx_bytes)}, > - {"tx_unicast_packets", offsetof(struct i40e_eth_stats, tx_bytes)}, > - {"tx_multicast_packets", offsetof(struct i40e_eth_stats, tx_bytes)}, > - {"tx_broadcast_packets", offsetof(struct i40e_eth_stats, tx_bytes)}, > - {"tx_dropped_packets", offsetof(struct i40e_eth_stats, tx_bytes)}, > - {"tx_error_packets", offsetof(struct i40e_eth_stats, tx_bytes)}, > + {"tx_unicast_packets", offsetof(struct i40e_eth_stats, tx_unicast)}, > + {"tx_multicast_packets", offsetof(struct i40e_eth_stats, tx_multicast)}, > + {"tx_broadcast_packets", offsetof(struct i40e_eth_stats, tx_broadcast)}, > + {"tx_dropped_packets", offsetof(struct i40e_eth_stats, tx_discards)}, > + {"tx_error_packets", offsetof(struct i40e_eth_stats, tx_errors)}, > }; > > #define I40EVF_NB_XSTATS (sizeof(rte_i40evf_stats_strings) / \ > ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v1 2/2] net/i40e: fix spelling errors 2016-11-14 6:14 [PATCH v1 0/2] XStats fixes Remy Horton 2016-11-14 6:14 ` [PATCH v1 1/2] net/i40e: fix incorrect xstats value mapping Remy Horton @ 2016-11-14 6:14 ` Remy Horton 2016-11-14 18:05 ` Kevin Traynor 2016-11-15 10:59 ` [PATCH v1 0/2] XStats fixes Ferruh Yigit 2 siblings, 1 reply; 6+ messages in thread From: Remy Horton @ 2016-11-14 6:14 UTC (permalink / raw) To: dev; +Cc: Helin Zhang, Jingjing Wu Fixes: da61cd084976 ("i40evf: add extended stats") Fixes: 0eedec25ea36 ("i40e: clean log messages") Signed-off-by: Remy Horton <remy.horton@intel.com> --- drivers/net/i40e/i40e_ethdev.c | 2 +- drivers/net/i40e/i40e_ethdev_vf.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c index 67778ba..f102328 100644 --- a/drivers/net/i40e/i40e_ethdev.c +++ b/drivers/net/i40e/i40e_ethdev.c @@ -4107,7 +4107,7 @@ i40e_veb_setup(struct i40e_pf *pf, struct i40e_vsi *vsi) ret = i40e_aq_get_veb_parameters(hw, veb->seid, NULL, NULL, &veb->stats_idx, NULL, NULL, NULL); if (ret != I40E_SUCCESS) { - PMD_DRV_LOG(ERR, "Get veb statics index failed, aq_err: %d", + PMD_DRV_LOG(ERR, "Get veb statistics index failed, aq_err: %d", hw->aq.asq_last_status); goto fail; } diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c index afae2ec..1431b6e 100644 --- a/drivers/net/i40e/i40e_ethdev_vf.c +++ b/drivers/net/i40e/i40e_ethdev_vf.c @@ -952,7 +952,7 @@ i40evf_update_stats(struct rte_eth_dev *dev, struct i40e_eth_stats **pstats) } static int -i40evf_get_statics(struct rte_eth_dev *dev, struct rte_eth_stats *stats) +i40evf_get_statistics(struct rte_eth_dev *dev, struct rte_eth_stats *stats) { int ret; struct i40e_eth_stats *pstats = NULL; @@ -2277,8 +2277,8 @@ i40evf_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info) static void i40evf_dev_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats) { - if (i40evf_get_statics(dev, stats)) - PMD_DRV_LOG(ERR, "Get statics failed"); + if (i40evf_get_statistics(dev, stats)) + PMD_DRV_LOG(ERR, "Get statistics failed"); } static void -- 2.5.5 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v1 2/2] net/i40e: fix spelling errors 2016-11-14 6:14 ` [PATCH v1 2/2] net/i40e: fix spelling errors Remy Horton @ 2016-11-14 18:05 ` Kevin Traynor 0 siblings, 0 replies; 6+ messages in thread From: Kevin Traynor @ 2016-11-14 18:05 UTC (permalink / raw) To: Remy Horton, dev; +Cc: Helin Zhang, Jingjing Wu On 11/14/2016 06:14 AM, Remy Horton wrote: > Fixes: da61cd084976 ("i40evf: add extended stats") > Fixes: 0eedec25ea36 ("i40e: clean log messages") > Acked-by: Kevin Traynor <ktraynor@redhat.com> > Signed-off-by: Remy Horton <remy.horton@intel.com> > --- > drivers/net/i40e/i40e_ethdev.c | 2 +- > drivers/net/i40e/i40e_ethdev_vf.c | 6 +++--- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c > index 67778ba..f102328 100644 > --- a/drivers/net/i40e/i40e_ethdev.c > +++ b/drivers/net/i40e/i40e_ethdev.c > @@ -4107,7 +4107,7 @@ i40e_veb_setup(struct i40e_pf *pf, struct i40e_vsi *vsi) > ret = i40e_aq_get_veb_parameters(hw, veb->seid, NULL, NULL, > &veb->stats_idx, NULL, NULL, NULL); > if (ret != I40E_SUCCESS) { > - PMD_DRV_LOG(ERR, "Get veb statics index failed, aq_err: %d", > + PMD_DRV_LOG(ERR, "Get veb statistics index failed, aq_err: %d", > hw->aq.asq_last_status); > goto fail; > } > diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c > index afae2ec..1431b6e 100644 > --- a/drivers/net/i40e/i40e_ethdev_vf.c > +++ b/drivers/net/i40e/i40e_ethdev_vf.c > @@ -952,7 +952,7 @@ i40evf_update_stats(struct rte_eth_dev *dev, struct i40e_eth_stats **pstats) > } > > static int > -i40evf_get_statics(struct rte_eth_dev *dev, struct rte_eth_stats *stats) > +i40evf_get_statistics(struct rte_eth_dev *dev, struct rte_eth_stats *stats) > { > int ret; > struct i40e_eth_stats *pstats = NULL; > @@ -2277,8 +2277,8 @@ i40evf_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info) > static void > i40evf_dev_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats) > { > - if (i40evf_get_statics(dev, stats)) > - PMD_DRV_LOG(ERR, "Get statics failed"); > + if (i40evf_get_statistics(dev, stats)) > + PMD_DRV_LOG(ERR, "Get statistics failed"); > } > > static void > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v1 0/2] XStats fixes 2016-11-14 6:14 [PATCH v1 0/2] XStats fixes Remy Horton 2016-11-14 6:14 ` [PATCH v1 1/2] net/i40e: fix incorrect xstats value mapping Remy Horton 2016-11-14 6:14 ` [PATCH v1 2/2] net/i40e: fix spelling errors Remy Horton @ 2016-11-15 10:59 ` Ferruh Yigit 2 siblings, 0 replies; 6+ messages in thread From: Ferruh Yigit @ 2016-11-15 10:59 UTC (permalink / raw) To: Remy Horton, dev; +Cc: Helin Zhang, Jingjing Wu On 11/14/2016 6:14 AM, Remy Horton wrote: > The offsets used in rte_i40evf_stats_strings for transmission > statistics were wrong, returning the total byte count rather than > the respective (unicast, multicast, broadcast, drop, & error) > packet counts. > > This patchset also fixes some spelling errors. > > Fixes: da61cd084976 ("i40evf: add extended stats") > Fixes: 0eedec25ea36 ("i40e: clean log messages") > > Remy Horton (2): > net/i40e: fix incorrect xstats value mapping > net/i40e: fix spelling errors > > drivers/net/i40e/i40e_ethdev.c | 2 +- > drivers/net/i40e/i40e_ethdev_vf.c | 16 ++++++++-------- > 2 files changed, 9 insertions(+), 9 deletions(-) > Series applied to dpdk-next-net/master, thanks. ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-11-15 10:59 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2016-11-14 6:14 [PATCH v1 0/2] XStats fixes Remy Horton 2016-11-14 6:14 ` [PATCH v1 1/2] net/i40e: fix incorrect xstats value mapping Remy Horton 2016-11-14 17:59 ` Kevin Traynor 2016-11-14 6:14 ` [PATCH v1 2/2] net/i40e: fix spelling errors Remy Horton 2016-11-14 18:05 ` Kevin Traynor 2016-11-15 10:59 ` [PATCH v1 0/2] XStats fixes Ferruh Yigit
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.