Re: [PATCH v3 21/23] mfd: Unify style of of_device_id arrays

[Krzysztof Kozlowski <krzk@kernel.org>]

On 10/07/2026 15:00, Mathieu Dubois-Briand wrote:
> On Thu Jul 9, 2026 at 6:58 PM CEST, Uwe Kleine-König (The Capable Hub) wrote:
>> These arrays already mostly match the most used and generally
>> recommended coding style. That is:
>>
>>  - no comma after the list terminator;
>>  - a comma after an initializer if (and only if) the closing } is not
>>    directly following;
>>  - no explicit zeros in the list terminator;
>>  - a space after an opening { and before a closing }, a single space in
>>    the list terminator;
>>
>> Adapt the offenders accordingly.
>>
>> Reviewed-by: André Draszik <andre.draszik@linaro.org> # for Maxim MAX77759
>> Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com>

Here...

>> Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>
>> ---
> 
> ...
> 
>>  
>> diff --git a/drivers/mfd/max7360.c b/drivers/mfd/max7360.c
>> index 52fffed0c0dd..dc744b40bb38 100644
>> --- a/drivers/mfd/max7360.c
>> +++ b/drivers/mfd/max7360.c
>> @@ -152,7 +152,7 @@ static int max7360_probe(struct i2c_client *client)
>>  
>>  static const struct of_device_id max7360_dt_match[] = {
>>  	{ .compatible = "maxim,max7360" },
>> -	{}
>> +	{ }
>>  };
>>  MODULE_DEVICE_TABLE(of, max7360_dt_match);
>>  
> 
> Reviewed-by: Mathieu Dubois-Briand <mathieu.dubois-briand@bootlin.com> # max7360

and here

Thesr are all Acks, not reviews. Entire commit will now carry multiple
review tags, implying it was reviewed by 3 or more people but none of
these people actually reviewed the commit. None!

They looked at one line out of 100.

This is ridiculous.

Quoting:
"Reviewed-by:, instead, indicates that the patch has been reviewed and
found acceptable according to the Reviewer's Statement:"

Not piece of a patch. THE PATCH.

Best regards,
Krzysztof