Re: [PATCH v3 21/23] mfd: Unify style of of_device_id arrays - Mathieu Dubois-Briand

From: "Mathieu Dubois-Briand" <mathieu.dubois-briand@bootlin.com>
To: "Uwe Kleine-König (The Capable Hub)"
	<u.kleine-koenig@baylibre.com>, "Lee Jones" <lee@kernel.org>
Cc: "Linus Walleij" <linusw@kernel.org>,
	"Nicolas Ferre" <nicolas.ferre@microchip.com>,
	"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
	"Claudiu Beznea" <claudiu.beznea@tuxon.dev>,
	"Chen-Yu Tsai" <wens@kernel.org>,
	"Florian Fainelli" <florian.fainelli@broadcom.com>,
	"Broadcom internal kernel review list"
	<bcm-kernel-feedback-list@broadcom.com>,
	"Ray Jui" <rjui@broadcom.com>,
	"Scott Branden" <sbranden@broadcom.com>,
	"Marek Vasut" <marek.vasut+renesas@gmail.com>,
	"James Ogletree" <jogletre@opensource.cirrus.com>,
	"Fred Treven" <fred.treven@cirrus.com>,
	"Ben Bright" <ben.bright@cirrus.com>,
	"David Rhodes" <david.rhodes@cirrus.com>,
	"Richard Fitzgerald" <rf@opensource.cirrus.com>,
	"Support Opensource" <support.opensource@diasemi.com>,
	"Krzysztof Kozlowski" <krzk@kernel.org>,
	"Peter Griffin" <peter.griffin@linaro.org>,
	"Alim Akhtar" <alim.akhtar@samsung.com>,
	"Tim Harvey" <tharvey@gateworks.com>,
	"Neil Armstrong" <neil.armstrong@linaro.org>,
	"Charles Keepax" <ckeepax@opensource.cirrus.com>,
	"Sven Peter" <sven@kernel.org>, "Janne Grunau" <j@jannau.net>,
	"Neal Gompa" <neal@gompa.dev>,
	"Chanwoo Choi" <cw00.choi@samsung.com>,
	"Luca Ceresoli" <luca.ceresoli@bootlin.com>,
	"André Draszik" <andre.draszik@linaro.org>,
	"Saravanan Sekar" <sravanhome@gmail.com>,
	"Matthias Brugger" <matthias.bgg@gmail.com>,
	"AngeloGioacchino Del Regno"
	<angelogioacchino.delregno@collabora.com>,
	"Frank Li" <Frank.Li@nxp.com>,
	"Sascha Hauer" <s.hauer@pengutronix.de>,
	"Pengutronix Kernel Team" <kernel@pengutronix.de>,
	"Fabio Estevam" <festevam@gmail.com>,
	"Jonathan Neuschäfer" <j.neuschaefer@gmx.net>,
	"Aaro Koskinen" <aaro.koskinen@iki.fi>,
	"Andreas Kemnade" <andreas@kemnade.info>,
	"Kevin Hilman" <khilman@baylibre.com>,
	"Roger Quadros" <rogerq@kernel.org>,
	"Tony Lindgren" <tony@atomide.com>,
	"Matti Vaittinen" <mazziesaccount@gmail.com>,
	"Orson Zhai" <orsonzhai@gmail.com>,
	"Baolin Wang" <baolin.wang@linux.alibaba.com>,
	"Chunyan Zhang" <zhang.lyra@gmail.com>,
	"Fabrice Gasnier" <fabrice.gasnier@foss.st.com>,
	"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
	"Alexandre Torgue" <alexandre.torgue@foss.st.com>,
	"Jernej Skrabec" <jernej.skrabec@gmail.com>,
	"Samuel Holland" <samuel@sholland.org>,
	"Liviu Dudau" <liviu.dudau@arm.com>,
	"Sudeep Holla" <sudeep.holla@kernel.org>,
	"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
	"Geert Uytterhoeven" <geert+renesas@glider.be>,
	"Magnus Damm" <magnus.damm@gmail.com>,
	"Heiko Stuebner" <heiko@sntech.de>,
	mfd@lists.linux.dev, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	patches@opensource.cirrus.com,
	linux-rpi-kernel@lists.infradead.org,
	linux-renesas-soc@vger.kernel.org, linux-sound@vger.kernel.org,
	linux-samsung-soc@vger.kernel.org,
	linux-amlogic@lists.infradead.org, asahi@lists.linux.dev,
	linux-mediatek@lists.infradead.org, imx@lists.linux.dev,
	linux-omap@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-sunxi@lists.linux.dev, linux-rockchip@lists.infradead.org
Subject: Re: [PATCH v3 21/23] mfd: Unify style of of_device_id arrays
Date: Fri, 10 Jul 2026 15:00:43 +0200	[thread overview]
Message-ID: <DJUWS6ZZUDS0.2ILHWRFQ1XD1S@bootlin.com> (raw)
In-Reply-To: <e5cc82aa51da5f545f745b126923fdd6085a68a0.1783615311.git.u.kleine-koenig@baylibre.com>

On Thu Jul 9, 2026 at 6:58 PM CEST, Uwe Kleine-König (The Capable Hub) wrote:
> These arrays already mostly match the most used and generally
> recommended coding style. That is:
>
>  - no comma after the list terminator;
>  - a comma after an initializer if (and only if) the closing } is not
>    directly following;
>  - no explicit zeros in the list terminator;
>  - a space after an opening { and before a closing }, a single space in
>    the list terminator;
>
> Adapt the offenders accordingly.
>
> Reviewed-by: André Draszik <andre.draszik@linaro.org> # for Maxim MAX77759
> Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com>
> Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>
> ---

...

>  
> diff --git a/drivers/mfd/max7360.c b/drivers/mfd/max7360.c
> index 52fffed0c0dd..dc744b40bb38 100644
> --- a/drivers/mfd/max7360.c
> +++ b/drivers/mfd/max7360.c
> @@ -152,7 +152,7 @@ static int max7360_probe(struct i2c_client *client)
>  
>  static const struct of_device_id max7360_dt_match[] = {
>  	{ .compatible = "maxim,max7360" },
> -	{}
> +	{ }
>  };
>  MODULE_DEVICE_TABLE(of, max7360_dt_match);
>  

Reviewed-by: Mathieu Dubois-Briand <mathieu.dubois-briand@bootlin.com> # max7360

-- 
Mathieu Dubois-Briand, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com