From: Arnd Bergmann <arnd@arndb.de>
To: "Shevchenko, Andriy" <andriy.shevchenko@intel.com>
Cc: "Chen, Alvin" <alvin.chen@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"Kweh, Hock Leong" <hock.leong.kweh@intel.com>,
"sebastian@breakpoint.cc" <sebastian@breakpoint.cc>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"Ong, Boon Leong" <boon.leong.ong@intel.com>,
"gnurou@gmail.com" <gnurou@gmail.com>,
"linus.walleij@linaro.org" <linus.walleij@linaro.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"grant.likely@linaro.org" <grant.likely@linaro.org>,
"Westerberg, Mika" <mika.westerberg@intel.com>,
"dvhart@linux.intel.com" <dvhart@linux.intel.com>,
"atull@opensource.altera.com" <atull@opensource.altera.com>
Subject: Re: [PATCH 1/3 v2] GPIO: gpio-dwapb: Enable platform driver binding to MFD driver
Date: Fri, 05 Sep 2014 14:20:57 +0200 [thread overview]
Message-ID: <31986364.cn091cmIXU@wuerfel> (raw)
In-Reply-To: <1409918522.30155.89.camel@intel.com>
On Friday 05 September 2014 12:02:01 Shevchenko, Andriy wrote:
> > irq = irq_of_parse_and_map(node, 0);
> > If (!irq) {
> > pp->irq = -1;
> > return;
> > } else {
> > pp->irq = irq;
> > }
> > Then the code looks strange.
> >
> > How do you think?
>
> If I understood correctly you messed up with hwirq vs. virq.
> Otherwise you have mention that you are using virq everywhere (I guess
> you may rename the field in the structure), but in this case the field
> in the platform_data looks a bit strange.
The field in platform_data should be the mapped virtual irq number, it
makes no sense to use the hwirq unless you also add a pointer to the domain
in which that hwirq exists.
Also the output of irq_of_parse_and_map() is a mapped irq, as the name
suggests.
Arnd
next prev parent reply other threads:[~2014-09-05 12:21 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-05 14:53 [PATCH 0/3 v2] The Designware GPIO Supporting Weike Chen
2014-09-05 14:53 ` [PATCH 1/3 v2] GPIO: gpio-dwapb: Enable platform driver binding to MFD driver Weike Chen
2014-09-05 9:21 ` Shevchenko, Andriy
2014-09-05 9:21 ` Shevchenko, Andriy
2014-09-05 10:20 ` Chen, Alvin
2014-09-05 10:20 ` Chen, Alvin
2014-09-05 12:02 ` Shevchenko, Andriy
2014-09-05 12:02 ` Shevchenko, Andriy
2014-09-05 12:20 ` Arnd Bergmann [this message]
2014-09-09 1:50 ` Chen, Alvin
2014-09-09 9:01 ` Shevchenko, Andriy
2014-09-09 9:01 ` Shevchenko, Andriy
2014-09-05 11:50 ` Arnd Bergmann
2014-09-05 19:37 ` Sebastian Andrzej Siewior
2014-09-06 10:47 ` Chen, Alvin
2014-09-09 1:20 ` Chen, Alvin
2014-09-05 14:53 ` [PATCH 2/3 v2] GPIO: gpio-dwapb: Support Debounce Weike Chen
2014-09-05 9:23 ` Shevchenko, Andriy
2014-09-05 9:23 ` Shevchenko, Andriy
2014-09-05 9:35 ` Chen, Alvin
2014-09-05 9:35 ` Chen, Alvin
2014-09-05 12:03 ` Shevchenko, Andriy
2014-09-05 12:03 ` Shevchenko, Andriy
2014-09-09 0:47 ` Chen, Alvin
2014-09-09 0:47 ` Chen, Alvin
2014-09-05 14:53 ` [PATCH 3/3 v2] GPIO: gpio-dwapb: Suspend & Resume PM enabling Weike Chen
2014-09-05 9:24 ` Shevchenko, Andriy
2014-09-05 9:24 ` Shevchenko, Andriy
2014-09-05 9:35 ` Chen, Alvin
2014-09-05 9:35 ` Chen, Alvin
2014-09-19 17:34 ` Linus Walleij
2014-09-22 1:37 ` Chen, Alvin
2014-09-22 1:37 ` Chen, Alvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31986364.cn091cmIXU@wuerfel \
--to=arnd@arndb.de \
--cc=alvin.chen@intel.com \
--cc=andriy.shevchenko@intel.com \
--cc=atull@opensource.altera.com \
--cc=boon.leong.ong@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=dvhart@linux.intel.com \
--cc=gnurou@gmail.com \
--cc=grant.likely@linaro.org \
--cc=hock.leong.kweh@intel.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@intel.com \
--cc=robh+dt@kernel.org \
--cc=sebastian@breakpoint.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.