From: "Shevchenko, Andriy" <andriy.shevchenko@intel.com>
To: "Chen, Alvin" <alvin.chen@intel.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"Kweh, Hock Leong" <hock.leong.kweh@intel.com>,
"sebastian@breakpoint.cc" <sebastian@breakpoint.cc>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"Ong, Boon Leong" <boon.leong.ong@intel.com>,
"gnurou@gmail.com" <gnurou@gmail.com>,
"linus.walleij@linaro.org" <linus.walleij@linaro.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"grant.likely@linaro.org" <grant.likely@linaro.org>,
"Westerberg, Mika" <mika.westerberg@intel.com>,
"dvhart@linux.intel.com" <dvhart@linux.intel.com>,
"atull@opensource.altera.com" <atull@opensource.altera.com>
Subject: Re: [PATCH 2/3 v2] GPIO: gpio-dwapb: Support Debounce
Date: Fri, 5 Sep 2014 12:03:41 +0000 [thread overview]
Message-ID: <1409918621.30155.90.camel@intel.com> (raw)
In-Reply-To: <4656BEB6164FC34F8171C6538F1A595B2E98298B@SHSMSX101.ccr.corp.intel.com>
On Fri, 2014-09-05 at 09:35 +0000, Chen, Alvin wrote:
> > Subject: Re: [PATCH 2/3 v2] GPIO: gpio-dwapb: Support Debounce
> >
> > On Fri, 2014-09-05 at 07:53 -0700, Weike Chen wrote:
> > > This patch enables 'debounce' for the designware GPIO, and it is based
> > > on Josef Ahmad's previous work.
> >
> > Can we split dwapb_read/write introducing and changing from this patch to a
> > separate one?
> >
> Since the 'debounce' feature also needs read/write, if we splite this patch, then for 'debounce',
> One patch use readl/writel, and another patch change to dwapb_read/write. It seems duplicate since
> the previous patch use readl/writel and the fllowing one change it immediately.
> Since this patch is small, could we just make them together? How do you think?
Make the dwapb_writel/readl patch goes first in the series.
--
Andy Shevchenko <andriy.shevchenko@intel.com>
Intel Finland Oy
---------------------------------------------------------------------
Intel Finland Oy
Registered Address: PL 281, 00181 Helsinki
Business Identity Code: 0357606 - 4
Domiciled in Helsinki
This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.
WARNING: multiple messages have this Message-ID (diff)
From: "Shevchenko, Andriy" <andriy.shevchenko@intel.com>
To: "Chen, Alvin" <alvin.chen@intel.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"Kweh, Hock Leong" <hock.leong.kweh@intel.com>,
"sebastian@breakpoint.cc" <sebastian@breakpoint.cc>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"Ong, Boon Leong" <boon.leong.ong@intel.com>,
"gnurou@gmail.com" <gnurou@gmail.com>,
"linus.walleij@linaro.org" <linus.walleij@linaro.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"grant.likely@linaro.org" <grant.likely@linaro.org>,
"Westerberg, Mika" <mika.westerberg@intel.com>,
"dvhart@linux.intel.com" <dvhart@linux.intel.com>,
"atull@opensource.altera.com" <atull@opensource.altera.com>
Subject: Re: [PATCH 2/3 v2] GPIO: gpio-dwapb: Support Debounce
Date: Fri, 5 Sep 2014 12:03:41 +0000 [thread overview]
Message-ID: <1409918621.30155.90.camel@intel.com> (raw)
In-Reply-To: <4656BEB6164FC34F8171C6538F1A595B2E98298B@SHSMSX101.ccr.corp.intel.com>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 1513 bytes --]
On Fri, 2014-09-05 at 09:35 +0000, Chen, Alvin wrote:
> > Subject: Re: [PATCH 2/3 v2] GPIO: gpio-dwapb: Support Debounce
> >
> > On Fri, 2014-09-05 at 07:53 -0700, Weike Chen wrote:
> > > This patch enables 'debounce' for the designware GPIO, and it is based
> > > on Josef Ahmad's previous work.
> >
> > Can we split dwapb_read/write introducing and changing from this patch to a
> > separate one?
> >
> Since the 'debounce' feature also needs read/write, if we splite this patch, then for 'debounce',
> One patch use readl/writel, and another patch change to dwapb_read/write. It seems duplicate since
> the previous patch use readl/writel and the fllowing one change it immediately.
> Since this patch is small, could we just make them together? How do you think?
Make the dwapb_writel/readl patch goes first in the series.
--
Andy Shevchenko <andriy.shevchenko@intel.com>
Intel Finland Oy
---------------------------------------------------------------------
Intel Finland Oy
Registered Address: PL 281, 00181 Helsinki
Business Identity Code: 0357606 - 4
Domiciled in Helsinki
This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.
ÿôèº{.nÇ+‰·Ÿ®‰†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a¢f£¢·hšïêÿ‘êçz_è®\x03(階ŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨èÚ&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥
next prev parent reply other threads:[~2014-09-05 12:03 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-05 14:53 [PATCH 0/3 v2] The Designware GPIO Supporting Weike Chen
2014-09-05 14:53 ` [PATCH 1/3 v2] GPIO: gpio-dwapb: Enable platform driver binding to MFD driver Weike Chen
2014-09-05 9:21 ` Shevchenko, Andriy
2014-09-05 9:21 ` Shevchenko, Andriy
2014-09-05 10:20 ` Chen, Alvin
2014-09-05 10:20 ` Chen, Alvin
2014-09-05 12:02 ` Shevchenko, Andriy
2014-09-05 12:02 ` Shevchenko, Andriy
2014-09-05 12:20 ` Arnd Bergmann
2014-09-09 1:50 ` Chen, Alvin
2014-09-09 9:01 ` Shevchenko, Andriy
2014-09-09 9:01 ` Shevchenko, Andriy
2014-09-05 11:50 ` Arnd Bergmann
2014-09-05 19:37 ` Sebastian Andrzej Siewior
2014-09-06 10:47 ` Chen, Alvin
2014-09-09 1:20 ` Chen, Alvin
2014-09-05 14:53 ` [PATCH 2/3 v2] GPIO: gpio-dwapb: Support Debounce Weike Chen
2014-09-05 9:23 ` Shevchenko, Andriy
2014-09-05 9:23 ` Shevchenko, Andriy
2014-09-05 9:35 ` Chen, Alvin
2014-09-05 9:35 ` Chen, Alvin
2014-09-05 12:03 ` Shevchenko, Andriy [this message]
2014-09-05 12:03 ` Shevchenko, Andriy
2014-09-09 0:47 ` Chen, Alvin
2014-09-09 0:47 ` Chen, Alvin
2014-09-05 14:53 ` [PATCH 3/3 v2] GPIO: gpio-dwapb: Suspend & Resume PM enabling Weike Chen
2014-09-05 9:24 ` Shevchenko, Andriy
2014-09-05 9:24 ` Shevchenko, Andriy
2014-09-05 9:35 ` Chen, Alvin
2014-09-05 9:35 ` Chen, Alvin
2014-09-19 17:34 ` Linus Walleij
2014-09-22 1:37 ` Chen, Alvin
2014-09-22 1:37 ` Chen, Alvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1409918621.30155.90.camel@intel.com \
--to=andriy.shevchenko@intel.com \
--cc=alvin.chen@intel.com \
--cc=atull@opensource.altera.com \
--cc=boon.leong.ong@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=dvhart@linux.intel.com \
--cc=gnurou@gmail.com \
--cc=grant.likely@linaro.org \
--cc=hock.leong.kweh@intel.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@intel.com \
--cc=robh+dt@kernel.org \
--cc=sebastian@breakpoint.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.