From: Heiko Stuebner <heiko@sntech.de>
To: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
david@ixit.cz
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
Martin Filla <freebsd@sysctl.cz>,
David Heidelberg <david@ixit.cz>
Subject: Re: [PATCH] arm64: dts: rockchip: Fix PCIe v3 pinctrl for BPI-R2-Pro
Date: Mon, 02 Mar 2026 12:08:14 +0100 [thread overview]
Message-ID: <3404271.44csPzL39Z@phil> (raw)
In-Reply-To: <20260301-rk3568-bri-r2-pro-fix-pcie-v1-1-b9ed318b4a77@ixit.cz>
Hi David,
Am Sonntag, 1. März 2026, 16:54:41 Mitteleuropäische Normalzeit schrieb David Heidelberg via B4 Relay:
> From: David Heidelberg <david@ixit.cz>
>
> Add missing pinctrl for PD4 (PI6C PCIe clock enable,
> PCIE_CLKEN_H_GPIO0_D4) and set output high.
>
> This does fix freeze at initialization due pinctrl being in input
> state.
>
> Reported-by: Martin Filla <freebsd@sysctl.cz> # reported by private message
> Signed-off-by: David Heidelberg <david@ixit.cz>
> ---
> arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts b/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts
> index 4d3ebe50b90ba..b4c8abe37d1f3 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts
> @@ -121,6 +121,8 @@ vcc3v3_pi6c_05: regulator-vcc3v3-pi6c-05 {
> regulator-max-microvolt = <3300000>;
> enable-active-high;
> gpios = <&gpio0 RK_PD4 GPIO_ACTIVE_HIGH>;
> + pinctrl-0 = <&pi6cpcie_enable_h>;
> + pinctrl-names = "default";
please model hardware not how you want to use it.
The pi6c in the pin-name suggests, that this is a Diodes clock-generator
that creates the 100MHz frequency for PCIe [0] .
Please see [1] for one possible variant to model this.
Heiko
[0] https://www.diodes.com/part/view/PI6CG33602C or some variant of it
[1] http://lore.kernel.org/all/20260210080303.680403-1-heiko@sntech.de
WARNING: multiple messages have this Message-ID (diff)
From: Heiko Stuebner <heiko@sntech.de>
To: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
david@ixit.cz
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
Martin Filla <freebsd@sysctl.cz>,
David Heidelberg <david@ixit.cz>
Subject: Re: [PATCH] arm64: dts: rockchip: Fix PCIe v3 pinctrl for BPI-R2-Pro
Date: Mon, 02 Mar 2026 12:08:14 +0100 [thread overview]
Message-ID: <3404271.44csPzL39Z@phil> (raw)
In-Reply-To: <20260301-rk3568-bri-r2-pro-fix-pcie-v1-1-b9ed318b4a77@ixit.cz>
Hi David,
Am Sonntag, 1. März 2026, 16:54:41 Mitteleuropäische Normalzeit schrieb David Heidelberg via B4 Relay:
> From: David Heidelberg <david@ixit.cz>
>
> Add missing pinctrl for PD4 (PI6C PCIe clock enable,
> PCIE_CLKEN_H_GPIO0_D4) and set output high.
>
> This does fix freeze at initialization due pinctrl being in input
> state.
>
> Reported-by: Martin Filla <freebsd@sysctl.cz> # reported by private message
> Signed-off-by: David Heidelberg <david@ixit.cz>
> ---
> arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts b/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts
> index 4d3ebe50b90ba..b4c8abe37d1f3 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts
> @@ -121,6 +121,8 @@ vcc3v3_pi6c_05: regulator-vcc3v3-pi6c-05 {
> regulator-max-microvolt = <3300000>;
> enable-active-high;
> gpios = <&gpio0 RK_PD4 GPIO_ACTIVE_HIGH>;
> + pinctrl-0 = <&pi6cpcie_enable_h>;
> + pinctrl-names = "default";
please model hardware not how you want to use it.
The pi6c in the pin-name suggests, that this is a Diodes clock-generator
that creates the 100MHz frequency for PCIe [0] .
Please see [1] for one possible variant to model this.
Heiko
[0] https://www.diodes.com/part/view/PI6CG33602C or some variant of it
[1] http://lore.kernel.org/all/20260210080303.680403-1-heiko@sntech.de
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2026-03-02 11:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-01 15:54 [PATCH] arm64: dts: rockchip: Fix PCIe v3 pinctrl for BPI-R2-Pro David Heidelberg
2026-03-01 15:54 ` David Heidelberg via B4 Relay
2026-03-01 15:54 ` David Heidelberg via B4 Relay
2026-03-01 16:03 ` David Heidelberg
2026-03-01 16:03 ` David Heidelberg
2026-03-02 11:08 ` Heiko Stuebner [this message]
2026-03-02 11:08 ` Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3404271.44csPzL39Z@phil \
--to=heiko@sntech.de \
--cc=conor+dt@kernel.org \
--cc=david@ixit.cz \
--cc=devicetree@vger.kernel.org \
--cc=freebsd@sysctl.cz \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.