From: "Hogander, Jouni" <jouni.hogander@intel.com>
To: "intel-xe@lists.freedesktop.org" <intel-xe@lists.freedesktop.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"Manna, Animesh" <animesh.manna@intel.com>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>
Cc: "Kandpal, Suraj" <suraj.kandpal@intel.com>,
"Nikula, Jani" <jani.nikula@intel.com>
Subject: Re: [PATCH v7 04/20] drm/i915/alpm: alpm_init() for DP2.1
Date: Wed, 18 Nov 2026 11:44:43 +0000 [thread overview]
Message-ID: <345800f1fe804faf4f4246d52ae7f2afd03f85d3.camel@intel.com> (raw)
In-Reply-To: <20261026054001.799894-5-animesh.manna@intel.com>
On Mon, 2026-10-26 at 11:09 +0530, Animesh Manna wrote:
> Initialize ALPM for DP2.1 and separate out ALPM mutex-init
> from alpm-init.
>
> v2: Separate out mutex-init. [Jani]
> v3: Refactor further to avoid DISPLAY_VER check in multiple places.
> [Jani]
> v4: Cosmetic changes. [Suraj]
> v5: Reset alpm_dpcd and simplify source-supported check.
> v6: Drop display-version check for eDP for backward compatible.
> v7:
> - Read ALPM DPCD in detect only for DP, eDP already does it. [Jouni]
> - Move source-supported check into intel_alpm_init/_dpcd(). [Jouni]
> - Check source support instead of sink caps in intel_alpm_disable()
> as alpm_dpcd is reset on disconnect before the CRTC is disabled.
> [Sashiko]
>
> Cc: Jouni Högander <jouni.hogander@intel.com>
> Reviewed-by: Suraj Kandpal <suraj.kandpal@intel.com>
> Signed-off-by: Animesh Manna <animesh.manna@intel.com>
Reviewed-by: Jouni Högander <jouni.hogander@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_alpm.c | 19 ++++++++++++++++++-
> drivers/gpu/drm/i915/display/intel_dp.c | 9 ++++++---
> 2 files changed, 24 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_alpm.c
> b/drivers/gpu/drm/i915/display/intel_alpm.c
> index cb1d68fef198..b6307862b756 100644
> --- a/drivers/gpu/drm/i915/display/intel_alpm.c
> +++ b/drivers/gpu/drm/i915/display/intel_alpm.c
> @@ -43,11 +43,21 @@ bool intel_alpm_is_alpm_aux_less(struct intel_dp
> *intel_dp,
> (crtc_state->has_lobf &&
> intel_alpm_aux_less_wake_supported(intel_dp));
> }
>
> +static bool intel_alpm_source_supported(struct intel_dp *intel_dp)
> +{
> + struct intel_display *display = to_intel_display(intel_dp);
> +
> + return intel_dp_is_edp(intel_dp) || DISPLAY_VER(display) >=
> 35;
> +}
> +
> int intel_alpm_init_dpcd(struct intel_dp *intel_dp)
> {
> u8 dpcd;
> int ret;
>
> + if (!intel_alpm_source_supported(intel_dp))
> + return 0;
> +
> ret = drm_dp_dpcd_read_byte(&intel_dp->aux,
> DP_RECEIVER_ALPM_CAP, &dpcd);
> if (ret < 0)
> return ret;
> @@ -59,6 +69,9 @@ int intel_alpm_init_dpcd(struct intel_dp *intel_dp)
>
> void intel_alpm_init(struct intel_dp *intel_dp)
> {
> + if (!intel_alpm_source_supported(intel_dp))
> + return;
> +
> mutex_init(&intel_dp->alpm.lock);
> }
>
> @@ -750,7 +763,11 @@ void intel_alpm_disable(struct intel_dp
> *intel_dp)
> struct intel_display *display = to_intel_display(intel_dp);
> enum transcoder cpu_transcoder = intel_dp->alpm.transcoder;
>
> - if (DISPLAY_VER(display) < 20 || !intel_dp->alpm_dpcd)
> + /*
> + * Don't check sink ALPM caps here, they are reset on
> disconnect
> + * before the CRTC is disabled.
> + */
> + if (DISPLAY_VER(display) < 20 ||
> !intel_alpm_source_supported(intel_dp))
> return;
>
> mutex_lock(&intel_dp->alpm.lock);
> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c
> b/drivers/gpu/drm/i915/display/intel_dp.c
> index 816337efeb91..c543fe551eb8 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> @@ -6607,6 +6607,7 @@ intel_dp_detect(struct drm_connector
> *_connector,
> connector->dp.panel_replay_caps.su_support = false;
> connector->dp.panel_replay_caps.dsc_support =
> INTEL_DP_PANEL_REPLAY_DSC_NOT_SUPPORTED;
> + intel_dp->alpm_dpcd = 0;
>
> intel_dp_mst_disconnect(intel_dp);
>
> @@ -6629,8 +6630,10 @@ intel_dp_detect(struct drm_connector
> *_connector,
> if (ret == 1)
> connector->base.epoch_counter++;
>
> - if (!intel_dp_is_edp(intel_dp))
> + if (!intel_dp_is_edp(intel_dp)) {
> + intel_alpm_init_dpcd(intel_dp);
> intel_psr_init_dpcd(intel_dp, connector);
> + }
>
> intel_dp_detect_dsc_caps(intel_dp, connector);
>
> @@ -7272,8 +7275,6 @@ static bool intel_edp_init_connector(struct
> intel_dp *intel_dp,
> */
> intel_hpd_enable_detection(encoder);
>
> - intel_alpm_init(intel_dp);
> -
> /* Cache DPCD and EDID for edp. */
> has_dpcd = intel_edp_init_dpcd(intel_dp, connector);
>
> @@ -7488,6 +7489,8 @@ intel_dp_init_connector(struct
> intel_digital_port *dig_port,
>
> intel_psr_init(intel_dp);
>
> + intel_alpm_init(intel_dp);
> +
> return true;
>
> fail:
next prev parent reply other threads:[~2026-11-18 11:45 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-26 5:39 [PATCH v7 00/20] Enable DP2.1 alpm Animesh Manna
2026-10-26 5:39 ` [PATCH v7 01/20] drm/i915/alpm: Program zero-based LFPS half cycle duration Animesh Manna
2026-10-27 15:33 ` Jani Nikula
2026-10-28 5:42 ` Manna, Animesh
2026-10-26 5:39 ` [PATCH v7 02/20] drm/dp: Add DPCD definitions for DP2.1 ALPM capability Animesh Manna
2026-11-18 11:44 ` Hogander, Jouni
2026-10-26 5:39 ` [PATCH v7 03/20] drm/i915/alpm: Move alpm sink capability readout into a separate function Animesh Manna
2026-10-26 5:39 ` [PATCH v7 04/20] drm/i915/alpm: alpm_init() for DP2.1 Animesh Manna
2026-10-26 7:11 ` sashiko-bot
2026-11-18 11:44 ` Hogander, Jouni [this message]
2026-10-26 5:39 ` [PATCH v7 05/20] drm/i915/alpm: Enable debugfs " Animesh Manna
2026-11-18 11:45 ` Hogander, Jouni
2026-10-26 5:39 ` [PATCH v7 06/20] drm/i915/alpm: Refactor Auxless wake time calculation Animesh Manna
2026-11-18 11:46 ` Hogander, Jouni
2026-10-26 5:39 ` [PATCH v7 07/20] drm/i915/alpm: Auxless wake time calculation for Xe3p Animesh Manna
2026-10-26 5:39 ` [PATCH v7 08/20] drm/i915/alpm: Modify AUX_LESS_WAKE_TIME bitfield for xe3lpd Animesh Manna
2026-11-02 6:06 ` Kandpal, Suraj
2026-11-18 12:05 ` Hogander, Jouni
2026-11-18 12:12 ` Hogander, Jouni
2026-10-26 5:39 ` [PATCH v7 09/20] drm/i915/alpm: table based establishment period Animesh Manna
2026-11-18 12:15 ` Hogander, Jouni
2026-10-26 5:39 ` [PATCH v7 10/20] drm/i915/alpm: Half LFPS cycle calculation Animesh Manna
2026-10-26 7:06 ` sashiko-bot
2026-11-18 12:31 ` Hogander, Jouni
2026-10-26 5:39 ` [PATCH v7 11/20] drm/i915/alpm: Modify LFPS cycle count for DP ALPM Animesh Manna
2026-10-26 5:39 ` [PATCH v7 12/20] drm/i915/alpm: Modify LFPS_CYCLE_COUNT bitfield for xe3lpd Animesh Manna
2026-11-02 6:07 ` Kandpal, Suraj
2026-10-26 5:39 ` [PATCH v7 13/20] drm/i915/alpm: Program LTTPR count for DP 2.1 ALPM Animesh Manna
2026-11-18 12:35 ` Hogander, Jouni
2026-10-26 5:39 ` [PATCH v7 14/20] drm/i915/alpm: Enable MAC Transmitting LFPS for LT PHY Animesh Manna
2026-11-18 12:42 ` Hogander, Jouni
2026-10-26 5:39 ` [PATCH v7 15/20] drm/i915/alpm: Compute and program switch to active latency Animesh Manna
2026-11-18 12:46 ` Hogander, Jouni
2026-10-26 5:39 ` [PATCH v7 16/20] drm/i915/alpm: Replace is_edp() with alpm_is_possible() Animesh Manna
2026-10-26 7:16 ` sashiko-bot
2026-11-18 12:55 ` Hogander, Jouni
2026-10-26 5:39 ` [PATCH v7 17/20] drm/i915/alpm: Disallow ALPM for UHBR link rate Animesh Manna
2026-11-18 12:57 ` Hogander, Jouni
2026-10-26 5:39 ` [PATCH v7 18/20] drm/i915/alpm: Compute ALPM config before PSR config Animesh Manna
2026-11-18 13:08 ` Hogander, Jouni
2026-10-26 5:39 ` [PATCH v7 19/20] drm/i915/alpm: Introduce has_alpm to decouple from pr/psr2/lobf Animesh Manna
2026-10-26 7:23 ` sashiko-bot
2026-11-19 6:35 ` Hogander, Jouni
2026-10-26 5:39 ` [PATCH v7 20/20] drm/i915/dp: Enable AS SDP for DP Panel Replay with AUX-less ALPM Animesh Manna
2026-11-19 7:11 ` Hogander, Jouni
2026-10-26 5:50 ` ✗ CI.checkpatch: warning for Enable DP2.1 alpm (rev7) Patchwork
2026-10-26 5:52 ` ✓ CI.KUnit: success " Patchwork
2026-10-26 6:28 ` ✓ Xe.CI.BAT: " Patchwork
2026-10-26 6:43 ` ✗ i915.CI.BAT: failure " Patchwork
2026-10-26 8:06 ` ✗ Xe.CI.FULL: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=345800f1fe804faf4f4246d52ae7f2afd03f85d3.camel@intel.com \
--to=jouni.hogander@intel.com \
--cc=animesh.manna@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=suraj.kandpal@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.