From: "Hogander, Jouni" <jouni.hogander@intel.com>
To: "intel-xe@lists.freedesktop.org" <intel-xe@lists.freedesktop.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"Manna, Animesh" <animesh.manna@intel.com>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>
Cc: "Kandpal, Suraj" <suraj.kandpal@intel.com>,
"Nikula, Jani" <jani.nikula@intel.com>
Subject: Re: [PATCH v7 20/20] drm/i915/dp: Enable AS SDP for DP Panel Replay with AUX-less ALPM
Date: Thu, 19 Nov 2026 07:11:40 +0000 [thread overview]
Message-ID: <3d9f9f410dfb508d530b0738abc82ce478aeb683.camel@intel.com> (raw)
In-Reply-To: <20261026054001.799894-21-animesh.manna@intel.com>
On Mon, 2026-10-26 at 11:09 +0530, Animesh Manna wrote:
> AS SDP for Panel Replay with AUX-less ALPM and the related
> DP_FIXED_VTOTAL_AS_SDP_EN_IN_PR_ACTIVE setting are limited to eDP by
> intel_psr_needs_alpm_aux_less(). DP Panel Replay can now use AUX-less
> ALPM as well, so base these on the ALPM state instead.
>
> has_alpm is decided only in the late compute config, after AS SDP has
> been computed. Use alpm_state.aux_less_possible to decide whether AS
> SDP is needed, and has_alpm for the link training DPCD setting, which
> happens with the final state.
>
> intel_psr_needs_alpm_aux_less() is now used only within intel_psr.c,
> so make it static.
>
> Cc: Jouni Högander <jouni.hogander@intel.com>
> Signed-off-by: Animesh Manna <animesh.manna@intel.com>
Reviewed-by: Jouni Högander <jouni.hogander@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_dp.c | 4 +++-
> drivers/gpu/drm/i915/display/intel_dp_link_training.c | 2 +-
> drivers/gpu/drm/i915/display/intel_psr.c | 4 ++--
> drivers/gpu/drm/i915/display/intel_psr.h | 2 --
> 4 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c
> b/drivers/gpu/drm/i915/display/intel_dp.c
> index 43b17d2ed93f..02ea3f2b00ac 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> @@ -3274,7 +3274,9 @@ static bool intel_dp_needs_as_sdp(struct
> intel_dp *intel_dp,
> if (drm_dp_is_branch(intel_dp->dpcd))
> return false;
>
> - if (intel_psr_needs_alpm_aux_less(intel_dp, crtc_state) &&
> + /* has_alpm is not final yet, so check if AUX-less ALPM is
> possible */
> + if (crtc_state->has_panel_replay &&
> + crtc_state->alpm_state.aux_less_possible &&
> !intel_psr_pr_async_video_timing_supported(intel_dp))
> return true;
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dp_link_training.c
> b/drivers/gpu/drm/i915/display/intel_dp_link_training.c
> index 0dbc6174c402..c7a3cfd29e37 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp_link_training.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp_link_training.c
> @@ -1124,7 +1124,7 @@ static bool
> intel_dp_pr_with_as_sdp_enabled(struct intel_dp *intel_dp,
> const struct intel_crtc_state
> *crtc_state)
> {
> - return intel_psr_needs_alpm_aux_less(intel_dp, crtc_state)
> &&
> + return crtc_state->has_panel_replay && crtc_state->has_alpm
> &&
> (crtc_state->infoframes.enable &
> intel_hdmi_infoframe_enable(DP_SDP_ADAPTIVE_SYNC));
> }
> diff --git a/drivers/gpu/drm/i915/display/intel_psr.c
> b/drivers/gpu/drm/i915/display/intel_psr.c
> index 4c429a14b50e..0875de33f0da 100644
> --- a/drivers/gpu/drm/i915/display/intel_psr.c
> +++ b/drivers/gpu/drm/i915/display/intel_psr.c
> @@ -4566,8 +4566,8 @@ static bool intel_psr_needs_alpm(struct
> intel_dp *intel_dp,
> crtc_state-
> >has_panel_replay);
> }
>
> -bool intel_psr_needs_alpm_aux_less(struct intel_dp *intel_dp,
> - const struct intel_crtc_state
> *crtc_state)
> +static bool intel_psr_needs_alpm_aux_less(struct intel_dp *intel_dp,
> + const struct
> intel_crtc_state *crtc_state)
> {
> return intel_dp_is_edp(intel_dp) && crtc_state-
> >has_panel_replay;
> }
> diff --git a/drivers/gpu/drm/i915/display/intel_psr.h
> b/drivers/gpu/drm/i915/display/intel_psr.h
> index 2557776a402b..8adb27c21408 100644
> --- a/drivers/gpu/drm/i915/display/intel_psr.h
> +++ b/drivers/gpu/drm/i915/display/intel_psr.h
> @@ -79,8 +79,6 @@ void intel_psr_trigger_frame_change_event(struct
> intel_dsb *dsb,
> int intel_psr_min_set_context_latency(const struct intel_crtc_state
> *crtc_state);
> void intel_psr_connector_debugfs_add(struct intel_connector
> *connector);
> void intel_psr_debugfs_register(struct intel_display *display);
> -bool intel_psr_needs_alpm_aux_less(struct intel_dp *intel_dp,
> - const struct intel_crtc_state
> *crtc_state);
> bool intel_psr_wake_lines_fit_into_vblank(const struct
> intel_crtc_state *crtc_state,
> int wake_lines);
> void intel_psr_compute_config_late(struct intel_dp *intel_dp,
next prev parent reply other threads:[~2026-11-19 7:12 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-26 5:39 [PATCH v7 00/20] Enable DP2.1 alpm Animesh Manna
2026-10-26 5:39 ` [PATCH v7 01/20] drm/i915/alpm: Program zero-based LFPS half cycle duration Animesh Manna
2026-10-27 15:33 ` Jani Nikula
2026-10-28 5:42 ` Manna, Animesh
2026-10-26 5:39 ` [PATCH v7 02/20] drm/dp: Add DPCD definitions for DP2.1 ALPM capability Animesh Manna
2026-11-18 11:44 ` Hogander, Jouni
2026-10-26 5:39 ` [PATCH v7 03/20] drm/i915/alpm: Move alpm sink capability readout into a separate function Animesh Manna
2026-10-26 5:39 ` [PATCH v7 04/20] drm/i915/alpm: alpm_init() for DP2.1 Animesh Manna
2026-10-26 7:11 ` sashiko-bot
2026-11-18 11:44 ` Hogander, Jouni
2026-10-26 5:39 ` [PATCH v7 05/20] drm/i915/alpm: Enable debugfs " Animesh Manna
2026-11-18 11:45 ` Hogander, Jouni
2026-10-26 5:39 ` [PATCH v7 06/20] drm/i915/alpm: Refactor Auxless wake time calculation Animesh Manna
2026-11-18 11:46 ` Hogander, Jouni
2026-10-26 5:39 ` [PATCH v7 07/20] drm/i915/alpm: Auxless wake time calculation for Xe3p Animesh Manna
2026-10-26 5:39 ` [PATCH v7 08/20] drm/i915/alpm: Modify AUX_LESS_WAKE_TIME bitfield for xe3lpd Animesh Manna
2026-11-02 6:06 ` Kandpal, Suraj
2026-11-18 12:05 ` Hogander, Jouni
2026-11-18 12:12 ` Hogander, Jouni
2026-10-26 5:39 ` [PATCH v7 09/20] drm/i915/alpm: table based establishment period Animesh Manna
2026-11-18 12:15 ` Hogander, Jouni
2026-10-26 5:39 ` [PATCH v7 10/20] drm/i915/alpm: Half LFPS cycle calculation Animesh Manna
2026-10-26 7:06 ` sashiko-bot
2026-11-18 12:31 ` Hogander, Jouni
2026-10-26 5:39 ` [PATCH v7 11/20] drm/i915/alpm: Modify LFPS cycle count for DP ALPM Animesh Manna
2026-10-26 5:39 ` [PATCH v7 12/20] drm/i915/alpm: Modify LFPS_CYCLE_COUNT bitfield for xe3lpd Animesh Manna
2026-11-02 6:07 ` Kandpal, Suraj
2026-10-26 5:39 ` [PATCH v7 13/20] drm/i915/alpm: Program LTTPR count for DP 2.1 ALPM Animesh Manna
2026-11-18 12:35 ` Hogander, Jouni
2026-10-26 5:39 ` [PATCH v7 14/20] drm/i915/alpm: Enable MAC Transmitting LFPS for LT PHY Animesh Manna
2026-11-18 12:42 ` Hogander, Jouni
2026-10-26 5:39 ` [PATCH v7 15/20] drm/i915/alpm: Compute and program switch to active latency Animesh Manna
2026-11-18 12:46 ` Hogander, Jouni
2026-10-26 5:39 ` [PATCH v7 16/20] drm/i915/alpm: Replace is_edp() with alpm_is_possible() Animesh Manna
2026-10-26 7:16 ` sashiko-bot
2026-11-18 12:55 ` Hogander, Jouni
2026-10-26 5:39 ` [PATCH v7 17/20] drm/i915/alpm: Disallow ALPM for UHBR link rate Animesh Manna
2026-11-18 12:57 ` Hogander, Jouni
2026-10-26 5:39 ` [PATCH v7 18/20] drm/i915/alpm: Compute ALPM config before PSR config Animesh Manna
2026-11-18 13:08 ` Hogander, Jouni
2026-10-26 5:39 ` [PATCH v7 19/20] drm/i915/alpm: Introduce has_alpm to decouple from pr/psr2/lobf Animesh Manna
2026-10-26 7:23 ` sashiko-bot
2026-11-19 6:35 ` Hogander, Jouni
2026-10-26 5:39 ` [PATCH v7 20/20] drm/i915/dp: Enable AS SDP for DP Panel Replay with AUX-less ALPM Animesh Manna
2026-11-19 7:11 ` Hogander, Jouni [this message]
2026-10-26 5:50 ` ✗ CI.checkpatch: warning for Enable DP2.1 alpm (rev7) Patchwork
2026-10-26 5:52 ` ✓ CI.KUnit: success " Patchwork
2026-10-26 6:28 ` ✓ Xe.CI.BAT: " Patchwork
2026-10-26 6:43 ` ✗ i915.CI.BAT: failure " Patchwork
2026-10-26 8:06 ` ✗ Xe.CI.FULL: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3d9f9f410dfb508d530b0738abc82ce478aeb683.camel@intel.com \
--to=jouni.hogander@intel.com \
--cc=animesh.manna@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=suraj.kandpal@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.