All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Hogander, Jouni" <jouni.hogander@intel.com>
To: "intel-xe@lists.freedesktop.org" <intel-xe@lists.freedesktop.org>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	"Manna, Animesh" <animesh.manna@intel.com>,
	"intel-gfx@lists.freedesktop.org"
	<intel-gfx@lists.freedesktop.org>
Cc: "Kandpal, Suraj" <suraj.kandpal@intel.com>,
	"Nikula, Jani" <jani.nikula@intel.com>
Subject: Re: [PATCH v7 02/20] drm/dp: Add DPCD definitions for DP2.1 ALPM capability
Date: Wed, 18 Nov 2026 11:44:13 +0000	[thread overview]
Message-ID: <bc4959388cc52cad886ed54abb6ab7d71f60f5ea.camel@intel.com> (raw)
In-Reply-To: <20261026054001.799894-3-animesh.manna@intel.com>

On Mon, 2026-10-26 at 11:09 +0530, Animesh Manna wrote:
> Add the LTTPR ALPM capabilities register (0xf0009) with the AUX-less
> ALPM supported bit, and the total LTTPR count register (0xf000a),
> both
> added in DP2.1. They are needed to enable DP2.1 ALPM with LTTPRs.
> 
> Extend DP_LTTPR_COMMON_CAP_SIZE from 8 to 10 so that the LTTPR ALPM
> capability is read as part of the LTTPR common capabilities. This
> makes
> drm_dp_read_lttpr_common_caps() read two more bytes for all its
> users,
> DP_PHY_REPEATER_EQ_DONE (0xf0008) and DP_LTTPR_ALPM_CAPABILITIES
> (0xf0009). The existing helpers don't use these bytes.
> 
> v2: Add DP_LTTPR_AUX_LESS_ALPM_SUPPORTED bit definition.
> v3: Use drm/dp prefix and describe the DP_LTTPR_COMMON_CAP_SIZE
> change.
> 
> Cc: Jouni Högander <jouni.hogander@intel.com>
> Cc: dri-devel@lists.freedesktop.org
> Reviewed-by: Suraj Kandpal <suraj.kandpal@intel.com>
> Signed-off-by: Animesh Manna <animesh.manna@intel.com>

Reviewed-by: Jouni Högander <jouni.hogander@intel.com>

> ---
>  include/drm/display/drm_dp.h | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/include/drm/display/drm_dp.h
> b/include/drm/display/drm_dp.h
> index e63c7f075f54..ea8cd497b658 100644
> --- a/include/drm/display/drm_dp.h
> +++ b/include/drm/display/drm_dp.h
> @@ -1541,6 +1541,9 @@
>  /* See DP_128B132B_SUPPORTED_LINK_RATES for values */
>  #define DP_PHY_REPEATER_128B132B_RATES			    0xf0007
> /* 2.0 */
>  #define DP_PHY_REPEATER_EQ_DONE                             0xf0008
> /* 2.0 E11 */
> +#define DP_LTTPR_ALPM_CAPABILITIES                          0xf0009
> /* 2.1 */
> +# define DP_LTTPR_AUX_LESS_ALPM_SUPPORTED                   (1 << 0)
> +#define DP_TOTAL_LTTPR_CNT                                  0xf000a
> /* 2.1 */
>  
>  enum drm_dp_phy {
>  	DP_PHY_DPRX,
> @@ -1720,7 +1723,7 @@ enum drm_dp_phy {
>  #define DP_DSC_BRANCH_CAP_SIZE		3
>  #define EDP_PSR_RECEIVER_CAP_SIZE	2
>  #define EDP_DISPLAY_CTL_CAP_SIZE	5
> -#define DP_LTTPR_COMMON_CAP_SIZE	8
> +#define DP_LTTPR_COMMON_CAP_SIZE	10
>  #define DP_LTTPR_PHY_CAP_SIZE		3
>  
>  #define DP_SDP_AUDIO_TIMESTAMP		0x01

  reply	other threads:[~2026-11-18 11:44 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-26  5:39 [PATCH v7 00/20] Enable DP2.1 alpm Animesh Manna
2026-10-26  5:39 ` [PATCH v7 01/20] drm/i915/alpm: Program zero-based LFPS half cycle duration Animesh Manna
2026-10-27 15:33   ` Jani Nikula
2026-10-28  5:42     ` Manna, Animesh
2026-10-26  5:39 ` [PATCH v7 02/20] drm/dp: Add DPCD definitions for DP2.1 ALPM capability Animesh Manna
2026-11-18 11:44   ` Hogander, Jouni [this message]
2026-10-26  5:39 ` [PATCH v7 03/20] drm/i915/alpm: Move alpm sink capability readout into a separate function Animesh Manna
2026-10-26  5:39 ` [PATCH v7 04/20] drm/i915/alpm: alpm_init() for DP2.1 Animesh Manna
2026-10-26  7:11   ` sashiko-bot
2026-11-18 11:44   ` Hogander, Jouni
2026-10-26  5:39 ` [PATCH v7 05/20] drm/i915/alpm: Enable debugfs " Animesh Manna
2026-11-18 11:45   ` Hogander, Jouni
2026-10-26  5:39 ` [PATCH v7 06/20] drm/i915/alpm: Refactor Auxless wake time calculation Animesh Manna
2026-11-18 11:46   ` Hogander, Jouni
2026-10-26  5:39 ` [PATCH v7 07/20] drm/i915/alpm: Auxless wake time calculation for Xe3p Animesh Manna
2026-10-26  5:39 ` [PATCH v7 08/20] drm/i915/alpm: Modify AUX_LESS_WAKE_TIME bitfield for xe3lpd Animesh Manna
2026-11-02  6:06   ` Kandpal, Suraj
2026-11-18 12:05   ` Hogander, Jouni
2026-11-18 12:12   ` Hogander, Jouni
2026-10-26  5:39 ` [PATCH v7 09/20] drm/i915/alpm: table based establishment period Animesh Manna
2026-11-18 12:15   ` Hogander, Jouni
2026-10-26  5:39 ` [PATCH v7 10/20] drm/i915/alpm: Half LFPS cycle calculation Animesh Manna
2026-10-26  7:06   ` sashiko-bot
2026-11-18 12:31   ` Hogander, Jouni
2026-10-26  5:39 ` [PATCH v7 11/20] drm/i915/alpm: Modify LFPS cycle count for DP ALPM Animesh Manna
2026-10-26  5:39 ` [PATCH v7 12/20] drm/i915/alpm: Modify LFPS_CYCLE_COUNT bitfield for xe3lpd Animesh Manna
2026-11-02  6:07   ` Kandpal, Suraj
2026-10-26  5:39 ` [PATCH v7 13/20] drm/i915/alpm: Program LTTPR count for DP 2.1 ALPM Animesh Manna
2026-11-18 12:35   ` Hogander, Jouni
2026-10-26  5:39 ` [PATCH v7 14/20] drm/i915/alpm: Enable MAC Transmitting LFPS for LT PHY Animesh Manna
2026-11-18 12:42   ` Hogander, Jouni
2026-10-26  5:39 ` [PATCH v7 15/20] drm/i915/alpm: Compute and program switch to active latency Animesh Manna
2026-11-18 12:46   ` Hogander, Jouni
2026-10-26  5:39 ` [PATCH v7 16/20] drm/i915/alpm: Replace is_edp() with alpm_is_possible() Animesh Manna
2026-10-26  7:16   ` sashiko-bot
2026-11-18 12:55   ` Hogander, Jouni
2026-10-26  5:39 ` [PATCH v7 17/20] drm/i915/alpm: Disallow ALPM for UHBR link rate Animesh Manna
2026-11-18 12:57   ` Hogander, Jouni
2026-10-26  5:39 ` [PATCH v7 18/20] drm/i915/alpm: Compute ALPM config before PSR config Animesh Manna
2026-11-18 13:08   ` Hogander, Jouni
2026-10-26  5:39 ` [PATCH v7 19/20] drm/i915/alpm: Introduce has_alpm to decouple from pr/psr2/lobf Animesh Manna
2026-10-26  7:23   ` sashiko-bot
2026-11-19  6:35   ` Hogander, Jouni
2026-10-26  5:39 ` [PATCH v7 20/20] drm/i915/dp: Enable AS SDP for DP Panel Replay with AUX-less ALPM Animesh Manna
2026-11-19  7:11   ` Hogander, Jouni
2026-10-26  5:50 ` ✗ CI.checkpatch: warning for Enable DP2.1 alpm (rev7) Patchwork
2026-10-26  5:52 ` ✓ CI.KUnit: success " Patchwork
2026-10-26  6:28 ` ✓ Xe.CI.BAT: " Patchwork
2026-10-26  6:43 ` ✗ i915.CI.BAT: failure " Patchwork
2026-10-26  8:06 ` ✗ Xe.CI.FULL: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bc4959388cc52cad886ed54abb6ab7d71f60f5ea.camel@intel.com \
    --to=jouni.hogander@intel.com \
    --cc=animesh.manna@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    --cc=suraj.kandpal@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.